From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEy3C-0000j3-SH for guix-patches@gnu.org; Sun, 28 May 2017 09:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEy38-0006tj-Lp for guix-patches@gnu.org; Sun, 28 May 2017 09:16:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dEy38-0006tV-Iq for guix-patches@gnu.org; Sun, 28 May 2017 09:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dEy38-0004Iv-CA for guix-patches@gnu.org; Sun, 28 May 2017 09:16:02 -0400 Subject: bug#26941: New font-build-system Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Sun, 28 May 2017 18:45:02 +0530 In-reply-to: <87fufptaup.fsf@gnu.org> References: <87bbe3e5.AEAAKL2r-KIAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZGcQo@mailjet.com> <87y3tw4kw3.fsf@gnu.org> <87r2zfx0xt.fsf@gnu.org> <9591bf82.AEUAKjfDcSkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKceD@mailjet.com> <87fufptaup.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26941@debbugs.gnu.org >>>> A side issue: I feel that the `install-file' procedure should print out >>>> what it's doing to stdout (or some log port). Something like: >>>> >>>> (format #t "~a -> ~a~%" source destination) >>>> >>>> This would save us the trouble of implementing this log printing >>>> everywhere `install-file' is called. For example, this could be very >>>> useful in the 'install' phase of the font-build-sytem. WDYT? >>> >>> Do we really need to print something in the first place? :-) Some >>> procedures in (guix build utils) do that, indeed, but I’m not sure it’s >>> useful for something as simple as ‘install-file’. Thoughts? >> >> Yes, I think it is really important. Without the verbose output, one >> will have to stare at a blank screen, guessing at what is >> happening. Long verbose output feels reassuring that something is going >> on. :-) Also, verbose output for `install-file' might help in debugging >> correct source/destination paths. > > OK. I’m not entirely convinced, because I think that either the build > completes and it’s easy to check that the files are where you wanted > them to be, or it fails, and you get an exception. I’m not strongly > opposed either, so perhaps something to consider in the next > ‘core-updates’ cycle. Should I send a patch for this? >> From a0bda2fc48c6d2c7809805251154c49e8be76d67 Mon Sep 17 00:00:00 2001 >> From: Arun Isaac >> Date: Mon, 15 May 2017 20:08:57 +0530 >> Subject: [PATCH 1/5] build-system: Add 'font-build-system'. >> >> * Makefile.am (MODULES): Add 'guix/build-system/font.scm' and >> 'guix/build/font-build-system.scm'. >> * guix/build-system/font.scm: New file. >> * guix/build/font-build-system.scm: New file. >> * doc/guix.texi (Build Systems): Add 'font-build-system'. > > Alright, OK for this and the following patches. I'll push these shortly, and begin work on migrating the other font packages to the new font-build-system.