From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Chuan Wei Foo <chuanwei.foo@hotmail.com>, 51015@debbugs.gnu.org
Subject: [bug#51015] [PATCH] Add Random Identity Generator (rig)
Date: Tue, 05 Oct 2021 15:22:45 +0200 [thread overview]
Message-ID: <df9ce3cb7666d5b84544b1f5f48b9f221f79b4e6.camel@gmail.com> (raw)
In-Reply-To: <PU1PR01MB2155F7CACB67ADAA58FAF72F8DAE9@PU1PR01MB2155.apcprd01.prod.exchangelabs.com>
Hi,
Am Montag, den 04.10.2021, 23:35 +0800 schrieb Chuan Wei Foo:
> ---
The commit message is missing here. In particular, a ChangeLog is
always required, see “info '(guix)Submitting Patches'”.
> gnu/packages/patches/rig.patch | 42
> ++++++++++++++++++++++++++++++++++
> gnu/packages/shellutils.scm | 29 +++++++++++++++++++++++
> 2 files changed, 71 insertions(+)
> create mode 100644 gnu/packages/patches/rig.patch
>
> diff --git a/gnu/packages/patches/rig.patch
> b/gnu/packages/patches/rig.patch
> new file mode 100644
> index 0000000000..34b4ff6533
> --- /dev/null
> +++ b/gnu/packages/patches/rig.patch
> @@ -0,0 +1,42 @@
> +--- rig-1.11.orig/Makefile
> ++++ rig-1.11/Makefile
> +@@ -1,20 +1,23 @@
> +-PREFIX=/usr/local
> ++PREFIX=${out}
> + BINDIR=${PREFIX}/bin
> + MANDIR=${PREFIX}/man
> + DATADIR=${PREFIX}/share/rig
> ++CXX=g++
> +
> + all: rig rig.6
> + rig: rig.cc
> +- g++ -g rig.cc -o rig -Wall -DDATADIR="\"$(DATADIR)\""
> ++ ${CXX} -O2 -g rig.cc -o rig -Wall -DDATADIR="\"$(DATADIR)\""
> +
> + rig.6: rig.6.in
> + sed s@DATADIR@"$(DATADIR)"@g < rig.6.in > rig.6
> +
> + install: rig rig.6
> +- install -g 0 -m 755 -o 0 -s rig $(BINDIR)
> +- install -g 0 -m 644 -o 0 rig.6 $(MANDIR)/man6/rig.6
> +- install -g 0 -m 755 -o 0 -d $(DATADIR)
> +- install -g 0 -m 644 -o 0 data/*.idx $(DATADIR)
> ++ install -m 755 -d $(DESTDIR)$(BINDIR)
> ++ install -m 755 -d $(DESTDIR)$(DATADIR)
> ++ install -m 755 -d $(DESTDIR)$(MANDIR)/man6/
> ++ install -m 755 rig $(DESTDIR)$(BINDIR)/rig
> ++ install -m 644 data/*.idx $(DESTDIR)$(DATADIR)
> ++ install -m 644 rig.6 $(DESTDIR)$(MANDIR)/man6/rig.6
You could provide the right #:make-flags, but more accurately replacing
the install phase would also work for this, no?
> + clean:
> + rm -rf *~ *.rej *.orig *.o rig rig.6
> +--- rig-1.11.orig/rig.cc
> ++++ rig-1.11/rig.cc
> +@@ -26,6 +26,7 @@
> + #include <time.h>
> + #include <errno.h>
> + #include <assert.h>
> ++#include <string.h>
> +
> + using namespace std;
> +
This one could technically be patched with a substitute* after unpack,
which is probably better than shipping a patch for it.
> diff --git a/gnu/packages/shellutils.scm
> b/gnu/packages/shellutils.scm
> index 94b5536df7..ef93977eb9 100644
> --- a/gnu/packages/shellutils.scm
> +++ b/gnu/packages/shellutils.scm
> @@ -35,6 +35,7 @@
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system go)
> #:use-module (guix build-system python)
> + #:use-module (gnu packages)
> #:use-module (gnu packages autotools)
> #:use-module (gnu packages base)
> #:use-module (gnu packages bison)
> @@ -398,3 +399,31 @@ the UNIX philosophy, these commands are designed
> to be composed via pipes. A
> large collection of functions such as basename, replace, contains or
> is_dir
> are provided as arguments to these commands.")
> (license license:expat)))
> +
> +(define-public rig
> + (package
> + (name "rig")
> + (version "1.11")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/rig/rig/"
> + version "/rig-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "1f3snysjqqlpk2kgvm5p2icrj4lsdymccmn3igkc2f60smqck
> gq0"))
> + (patches (search-patches "rig.patch"))))
> + (build-system gnu-build-system)
> + (arguments '(#:phases (modify-phases %standard-phases
> + (delete 'configure))
> + #:tests? #f))
> + (synopsis "Random identity generator")
> + (description
> + "RIG (Random Identity Generator) is a free replacement for a
> shareware
> +program out there called 'fake'. It generates random, yet real-
> looking,
> +personal data. It is useful if you need to feed a name to a Web
> site,
> +BBS, or real person, and are too lazy to think of one yourself.
> Also,
> +if the Web site/BBS/person you are giving the information to tries
> to
> +cross-check the city, state, zip, or area code, it will check out.")
I think we can do without references to non-free software in that
description.
> + (home-page "http://rig.sourceforge.net")
> + (license license:gpl2))
License is actually GPL2+.
Regards,
Liliana
next prev parent reply other threads:[~2021-10-05 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 15:35 [bug#51015] [PATCH] Add Random Identity Generator (rig) Chuan Wei Foo
2021-10-05 5:11 ` Chuan Wei Foo
2021-10-05 13:22 ` Liliana Marie Prikler [this message]
2021-10-06 15:23 ` [bug#51015] [PATCH v2] gnu: " Foo Chuan Wei
2021-10-12 9:12 ` [bug#51015] [PATCH v3] " Foo Chuan Wei
2021-10-26 10:43 ` [bug#51015] [PATCH] " Ludovic Courtès
2021-10-29 6:53 ` [bug#51015] [PATCH v4] gnu: " Foo Chuan Wei
2021-10-30 14:10 ` bug#51015: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9ce3cb7666d5b84544b1f5f48b9f221f79b4e6.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=51015@debbugs.gnu.org \
--cc=chuanwei.foo@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.