From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UEEgISIhg2BL5gAAgWs5BA (envelope-from ) for ; Fri, 23 Apr 2021 21:33:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qN+6HCIhg2CAXAAAB5/wlQ (envelope-from ) for ; Fri, 23 Apr 2021 19:33:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DA481D9CD for ; Fri, 23 Apr 2021 21:33:54 +0200 (CEST) Received: from localhost ([::1]:52730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1la1Yn-0001ab-Av for larch@yhetil.org; Fri, 23 Apr 2021 15:33:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la1Yd-0001aG-S7 for guix-devel@gnu.org; Fri, 23 Apr 2021 15:33:43 -0400 Received: from mail.zaclys.net ([178.33.93.72]:34703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la1Ya-0000ym-Pc for guix-devel@gnu.org; Fri, 23 Apr 2021 15:33:43 -0400 Received: from guix-xps.local (lsl43-1_migr-78-195-19-20.fbx.proxad.net [78.195.19.20] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 13NJXIgJ005327 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 23 Apr 2021 21:33:18 +0200 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 13NJXIgJ005327 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1619206399; bh=JMMAR3kBr56N+gIqhYyls4HdLTA8GaosgfD8vwVH+vA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=QSBzA3+o5lCbVcuuu3x90+ZxAbalMKGLw3tnOTS5ZK1zTh+uBkf6NqwQZiIFgBD4W KxQK9UtJGv3V0kobG9v0m/jP9GPqBPQB7GoA+AhgPfsW54cWUO4XlkGZXLm4o0Aeht sQW1xV2OugO26PLW4oktAaCOTwfahbW5P+bbL6Fs= Message-ID: Subject: Re: A "cosmetic changes" commit that removes security fixes From: =?ISO-8859-1?Q?L=E9o?= Le Bouter To: Leo Famulari Cc: Maxim Cournoyer , Mark H Weaver , Raghav Gururajan , Guix Devel , Leo Prikler , Sou Bunnbu Date: Fri, 23 Apr 2021 21:33:07 +0200 In-Reply-To: References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> <87czumypz3.fsf@netris.org> <87o8e4zy5k.fsf@gmail.com> <5cbbfa9b258fb28beb9288685ccc85b4d015cd8a.camel@zaclys.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RhQgF0khz0rMGJCMdSg0" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@zaclys.net; helo=mail.zaclys.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619206434; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JMMAR3kBr56N+gIqhYyls4HdLTA8GaosgfD8vwVH+vA=; b=r5WjFXmJbuZWZeME0xTpGV4SkluKmbMGDWzRk68nOx/rfW83H4+9isjTxmND23nR28S1OH BoZ6bDb9EFCve9tX7Sl3anTLmEFkUWlopjY5x0hJRbUSQbac4+BTVwGwrXh0RWlY4XRwnn MYc0Pw2+vMBgULrNcMS1ki7jW73WSCcWeEms/iYOkGlG9n46p/S7kA9nPr+Ta+E36RxaMK 4WRSq6f4xjPfRHloWLLwPdIhlapVx3qVhSiCDV9RTWmcgJxdbuDHM3iYgs3wsVics6U3jU vkoCdn1vnifwfUneyr+Pnes9Bir+X0wWfNiRPVJ10oMVxBOAPvONbmD3ZietHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619206434; a=rsa-sha256; cv=none; b=eC+71E3NogCS909xjCnVH8Fpou+Q07luMw8tpcib4SFlsE6FutifW0Vc4z8kE5QBNfrqTn 5lk0Ml450uNcSyDRXdVE8GSa6QjsRFPqienPDRdfdJnhnGBvtwAxBcX2xFWVC4PYu/gmN3 HQmjesRCi7lxkGvL2oAYQUf0ZY1YXNfqbBd0VM8lcGyxVBGm7zloCmqR4PHTrEiv1rn7l3 30HXaM6x9zB+bAazyn9vw3YFZ8LMXiQTIFCkoWhm94/6P2KzszYcIdLiXkdpSvSTSSqRAf 048+rKL5CDgcEgrb7KG7l9h7PVQdNdNOnhQmaPxi7KA3Dha/8ulXVVtVvbxacg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b=QSBzA3+o; dmarc=pass (policy=reject) header.from=zaclys.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.74 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b=QSBzA3+o; dmarc=pass (policy=reject) header.from=zaclys.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 3DA481D9CD X-Spam-Score: -3.74 X-Migadu-Scanner: scn0.migadu.com X-TUID: jQY7zmvHNrlx --=-RhQgF0khz0rMGJCMdSg0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2021-04-23 at 15:18 -0400, Leo Famulari wrote: > L=C3=A9o and Raghav, you need to keep learning our workflow around > security > updates. It's not okay to remove security patches and later update a > package to a fixed version in a different commit. `git rebase` is the > tool to learn for cases like this one. I knew about this but I didnt feel like telling Raghav to do yet another rebase. I felt like Raghav was taking on with so much already. The rebase was specially complicated because Raghav's commit changed indentation, git has bad quite bad UX for cases like these. At the time I had lots of things to handle also and couldnt spend lots of time on it myself. I didnt feel like blocking the merge of these patches for commit history was worth it at all. Such blocking could have hindered the GNOME upgrade effort even more. Thankfully now there's lots of energy being put to it, at the time there wasnt anyone else than Raghav and me. L=C3=A9o --=-RhQgF0khz0rMGJCMdSg0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmCDIPMACgkQRaix6GvN EKYWDQ//fBOIBxw6x39WYavB/IzzLda4MiXClBTqmYQsqqvJxbmAUjXcbRoffhZc rPWX2zHvdFOY9hoNL3yytO/ic8iqCc26gdIyFCp3Z4YlCMO71YvbHpCxpXAyRgTN BNAqSsOV4L+hKFXExmMTrrIsP6Tx5JY5VJC25Nc7092Zq5T4CaggompoLebpsW3y hrHDdiSTyDlS4AZLFMopP2if0zQc0/X6vZVZgbLU5Qq+2Bpiacbf5KBDBd9+Lrh5 xemyxjiOb1C3+NNsrNbS7MFQ5uIvOwyCfzy4p4m0tWoWHiGflbAl/on2M+AIYmNT p4jLDQ+fn1FgwpoqYWhyGJJde3iP1yw8o8mmWMTi+Y8L0VhPfVaNOEW4Sf3u18bC yrHvV7vAXfYFGJUwCJNQomOZJw8a0jNf1JmGauQ1P9xFi1sxbZTE7xVtWu/4IbPo +ibLS5M2uaPGVQ//pLelTYY3k8vPYvf/JaKc9U2eO5Z0LJxa/DSFyNFOhtR++2QK AoDF8Luu4wbaq7hm5QurdIga6EgDotJ+EzVLJvvgEJ/OIXdnhuqB22nG7j0aQHRW zrYJ401772rsKCe8L7FTucieGbyeVvnboPYxFVF0ppE4tK0f37Bj58660D0sG8fz IrbGS7dAXDvFjeFIXG7Zh9T0Y7kKIPSXPGemPZOf3tJy17o0lI8= =vMFY -----END PGP SIGNATURE----- --=-RhQgF0khz0rMGJCMdSg0--