[bug#41446] [PATCH 0/2] dconf: Enable tests.

[bug#41446] [PATCH 0/2] dconf: Enable tests.

[Brice Waegeneire]

Brice Waegeneire (2):
  gnu: dconf: Appease 'guix lint'.
  gnu: dconf: Enable tests.

 gnu/packages/gnome.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.26.2

[bug#41446] [PATCH 1/2] gnu: dconf: Appease 'guix lint'.

[Brice Waegeneire]

* gnu/packages/gnome.scm (dconf)[homepage]: Avoid permanent redirect.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ed668c280b..e9d2965f70 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3436,7 +3436,7 @@ and RDP protocols.")
                    ; or /etc/machine-id.
        #:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
-    (home-page "https://developer.gnome.org/dconf")
+    (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
     (description "Dconf is a low-level configuration system.  Its main purpose
 is to provide a backend to GSettings on platforms that don't already have
-- 
2.26.2

[bug#41446] [PATCH 2/2] gnu: dconf: Enable tests.

[Brice Waegeneire]

* gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
---
 gnu/packages/gnome.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e9d2965f70..803ac8fe5a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3432,9 +3432,7 @@ and RDP protocols.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (arguments
-     `(#:tests? #f ; To contact dbus it needs to load /var/lib/dbus/machine-id
-                   ; or /etc/machine-id.
-       #:glib-or-gtk? #t
+     `(#:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
     (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
-- 
2.26.2

[bug#41446] [PATCH 2/2] gnu: dconf: Enable tests.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.

dconf has over 400 dependent packages, so this should wait for the next
'staging' branch.  Can you fork off the current branch and push a
'staging-next' so it does not get forgotten?

Otherwise LGTM.  The other patch can go directly on 'master'.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#41446: [PATCH 2/2] gnu: dconf: Enable tests.

[Brice Waegeneire]

On 2020-05-23 17:42, Marius Bakke wrote:
> Brice Waegeneire <brice@waegenei.re> writes:
> 
>> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
> 
> dconf has over 400 dependent packages, so this should wait for the next
> 'staging' branch.  Can you fork off the current branch and push a
> 'staging-next' so it does not get forgotten?
> 
> Otherwise LGTM.  The other patch can go directly on 'master'.
> 
> Thanks!

Pushed the first patch on master as 
79d7b5277f803d474f8934b1680ce598c9c27e2d.
And the second on staging-next as 
27106f465382fc95f0f19e1cd3147cab5716a173.