From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UCNVGS3zMWKSUgAAgWs5BA (envelope-from ) for ; Wed, 16 Mar 2022 15:24:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6P78ES3zMWLtfwAAG6o9tA (envelope-from ) for ; Wed, 16 Mar 2022 15:24:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3A2D36582 for ; Wed, 16 Mar 2022 15:24:44 +0100 (CET) Received: from localhost ([::1]:43066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUUZv-00079P-Qe for larch@yhetil.org; Wed, 16 Mar 2022 10:24:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUUEw-0002nA-CE for guix-patches@gnu.org; Wed, 16 Mar 2022 10:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUUEw-0002Qn-37 for guix-patches@gnu.org; Wed, 16 Mar 2022 10:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUUEv-0006FR-Qm for guix-patches@gnu.org; Wed, 16 Mar 2022 10:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Mar 2022 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy LE CARROUR Cc: 54396@debbugs.gnu.org Received: via spool by 54396-submit@debbugs.gnu.org id=B54396.164743936023987 (code B ref 54396); Wed, 16 Mar 2022 14:03:01 +0000 Received: (at 54396) by debbugs.gnu.org; 16 Mar 2022 14:02:40 +0000 Received: from localhost ([127.0.0.1]:51909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUUEa-0006Ep-Kc for submit@debbugs.gnu.org; Wed, 16 Mar 2022 10:02:40 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:15504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUUEY-0006Ef-S9 for 54396@debbugs.gnu.org; Wed, 16 Mar 2022 10:02:39 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KJX5z3GxMz1LZWn; Wed, 16 Mar 2022 15:02:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KJX5z3GxMz1LZWn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1647439351; bh=CElcQsuJ7jyttu+yNJVcrm2ynCxdyKXcDHzsMsm6SUw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=GwfODmCMN2L1D5Ok8w16SetdMM7nq13ka8H7OoQYT4ezYP1D9pKIYZfJHBHnOPzcl H5QbJhFubq1OBxIhCQY63TnYcXbChHQK9Mfbwm3t7Hjy7oInqtn0GIRCpUqPMcxcKC 0D30UQ4TzXkEsRdWxccJorAGJg3M5rCV3hz57hgI= Message-ID: From: Liliana Marie Prikler Date: Wed, 16 Mar 2022 15:02:30 +0100 In-Reply-To: <164743841502.31835.14352244026552742248@localhost> References: <20220316111624.26189-1-tanguy@bioneland.org> <6b3d3874c3953688431be77f08989ef709780443.camel@ist.tugraz.at> <164743841502.31835.14352244026552742248@localhost> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647440685; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CElcQsuJ7jyttu+yNJVcrm2ynCxdyKXcDHzsMsm6SUw=; b=tNJYgvRWkME/4JarBc8cvSfLiRIF4w9qTjiK50f29Oikz4am59QEvKBpRgOgvf0o4hSkgm KPkaTW2lmr2XzWjiRZlZ1qjCJulO8vgBvXXLDPY17bDyzkeI2zRWYwNm0hC/dPOjdKFsqq y1VHQ1JoKvX0io1GQA74uhNddwY1zhDa/3OjH0zwYVrzDCVF8W1bxpPxDcNqmlMFVZtWHA wq6roeJ8JvU7To1xbkzMlq9ASFEWgtVr0tgxkPDBIB8q+pNqWaiPAD9XyrF6GETzQuUZjQ lU8Z8OKXdZ/sQAscXmA+KO/fL0eXjv9I1YDNcGesJIlmI9bgu/11NHzwjlcjdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647440685; a=rsa-sha256; cv=none; b=V7L8z+y7bri65QWHN1bQqcbv5IW5dcQu60tWjzhg2AGE2dVINWBpvJYCqiq49pDyiriqJ6 UowNrhDUSrDfgvrO94r3+UE5R4wmTRWeZ630gJx6r3fWF5PV7XtzvtYIWuQFJGLIe2V0oy Ju6UB0jnU4d+ek5rUxnJNEQCx8bGpXJTmZYpZl2SD8TqHfe6kVbQmE//rweBeiaAq4tWCE Ez7t2le/eqSjCc/Pdz6RiQTeMc9DAjw/SgoTWqdDHOqW1uODRT5+xoujzR6TyBA0QMWh2p 4XW8nZPIQxM+Tbg53s5K1Uml39tuRvENqJNOq0owVB82F6YhUHIzIu+4tG+mkQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=GwfODmCM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=GwfODmCM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F3A2D36582 X-Spam-Score: 5.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: A5A6dBRxyy/f Hi, Am Mittwoch, dem 16.03.2022 um 14:46 +0100 schrieb Tanguy LE CARROUR: > Hi Liliana, > [...] > > > i.e. (dirname (search-input-file inputs "notmuch.h")) and > > (dirname (search-input-file inputs "libnotmuch.so")). > > Unfortunately, I couldn't make those work. :-( > > So I ended up with a less "sexy" version: > > ``` > "NOTMUCH_INCLUDE_DIR='" (assoc-ref inputs "notmuch") > "/include/notmuch.h" "'\n" > "NOTMUCH_LIB_DIR='" (assoc-ref inputs "notmuch") "/lib/libnotmuch.so" > "'" > ``` That is actually a mistake on my part, search-input-file should search inputs for "include/notmuch.h" and likewise "lib/libnotmuch.so". The dirname is important here, since both constants want directories. Alternatively, forgoing those constants might be a good idea, but is not worth investing too much time in. > > As for the version file, that should probably be set to an error > > value such as None or NotImplemented or even unset.  It does not > > appear to be currently used and we don't install any such file > > for notmuch. > > If I set `NOTMUCH_VERSION_FILE=''`, I get a "file does not exist" > error at build time. So I decided to set it to `/dev/null` instead. > Or would it be better if I patched `notmuch` to create the actual > version file?! I think you ought to debug the build and short-circuit the logic by inferring the version number directly where it is needed. Without actual build output that's as much as I can propose. Cheers