From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH] gnu: Add tvtime.
Date: Tue, 28 Apr 2015 17:14:37 -0500
Message-ID: <de1bea4ac77d429cd1a90fa7fd4005c0@openmailbox.org>
References: <87pp6oc8hg.fsf@gmail.com>
Reply-To: bavier@member.fsf.org
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YnDm9-0003uA-Mp
	for guix-devel@gnu.org; Tue, 28 Apr 2015 18:14:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YnDm4-0003jX-Mc
	for guix-devel@gnu.org; Tue, 28 Apr 2015 18:14:45 -0400
Received: from mail2.openmailbox.org ([62.4.1.33]:33122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YnDm4-0003jO-GF
	for guix-devel@gnu.org; Tue, 28 Apr 2015 18:14:40 -0400
In-Reply-To: <87pp6oc8hg.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On 2015-04-28 15:18, Alex Kost wrote:
> From dcc331e7ab3fd0687c5a4ef8f084bc0bf4ca1cef Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Tue, 28 Apr 2015 22:21:37 +0300
> Subject: [PATCH] gnu: Add tvtime.
> 
> * gnu/packages/tvtime.scm,
>   gnu/packages/patches/tvtime-gcc41.patch,
>   gnu/packages/patches/tvtime-pngoutput.patch,
>   gnu/packages/patches/tvtime-videodev2.patch,
>   gnu/packages/patches/tvtime-xmltv.patch: New files.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add package.
>   (dist_patch_DATA): Add patches.

Perhaps we could name the file "tv.scm", in anticipation of other 
TV-related code?

> +    (inputs
> +     `(("libx11"      ,libx11)
> +       ("libxt"       ,libxt)
> +       ("libxtst"     ,libxtst)
> +       ("libxinerama" ,libxinerama)
> +       ("libxv"       ,libxv)
> +       ("libxxf86vm"  ,libxxf86vm)
> +       ("libpng"      ,libpng)
> +       ("libxml2"     ,libxml2)
> +       ("freetype"    ,freetype)
> +       ("zlib"        ,zlib)))

I think we were lately trying to stay away from aligning inputs like 
this (ISTR Ludo requesting it not be done on some other patch reviews).  
Not sure where the consensus is yet.

> +    (synopsis "High quality television application")

How about "Television viewer"?

Otherwise the rest look good to me.