From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kdvlEdjWBGStDAEAbAwnHQ (envelope-from ) for ; Sun, 05 Mar 2023 18:52:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4A+uEdjWBGQEPgAA9RJhRA (envelope-from ) for ; Sun, 05 Mar 2023 18:52:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1403BE1F6 for ; Sun, 5 Mar 2023 18:52:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYsWo-0008O6-Eo; Sun, 05 Mar 2023 12:52:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYsWh-0008NM-0o for guix-patches@gnu.org; Sun, 05 Mar 2023 12:52:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYsWg-0004Fa-HK for guix-patches@gnu.org; Sun, 05 Mar 2023 12:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYsWg-0007cv-2D for guix-patches@gnu.org; Sun, 05 Mar 2023 12:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61789] =?UTF-8?Q?=E2=80=98tor-hidden-service=E2=80=99?= deprecation Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Mar 2023 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61789@debbugs.gnu.org Received: via spool by 61789-submit@debbugs.gnu.org id=B61789.167803867629261 (code B ref 61789); Sun, 05 Mar 2023 17:52:02 +0000 Received: (at 61789) by debbugs.gnu.org; 5 Mar 2023 17:51:16 +0000 Received: from localhost ([127.0.0.1]:40582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYsVv-0007bt-Nc for submit@debbugs.gnu.org; Sun, 05 Mar 2023 12:51:16 -0500 Received: from smtpmciv4.myservices.hosting ([185.26.107.240]:38150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYsVt-0007bj-56 for 61789@debbugs.gnu.org; Sun, 05 Mar 2023 12:51:13 -0500 Received: from smtpmciv8.myservices.hosting (smtpmciv8.myservices.hosting [185.26.106.203]) by smtpmciv4.myservices.hosting (Postfix) with ESMTP id A55BE20550; Sun, 5 Mar 2023 18:51:10 +0100 (CET) Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv8.myservices.hosting (Postfix) with ESMTP id 00A3C20899; Sun, 5 Mar 2023 18:51:09 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 9FA9180097; Sun, 5 Mar 2023 18:51:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8X9vlMLrZFAn; Sun, 5 Mar 2023 18:51:09 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 0A80B80079; Sun, 5 Mar 2023 18:51:08 +0100 (CET) Message-ID: Date: Sun, 5 Mar 2023 17:51:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <55d9d97eabbb72cf59713b31015e654d028d8623.1677350249.git.mirai@makinata.eu> <87mt4tvl9i.fsf_-_@gnu.org> From: Bruno Victal In-Reply-To: <87mt4tvl9i.fsf_-_@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678038744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=TtvI/yzLWXPZQYgizMlIqB/Tbm1GONhD2yanFs3vqF4=; b=PpkJjdm58tZMDZ+yMpvVKJavtVRQY+gpTaphYOovDtN4buc6y/nDxh+1Dp++ymffAJFlkY 1DUMLe/VNxoIfiFyaSVtoLKNR1wyjDrn05jxoTcmABz0NriyJkZkb0Fj0AkFoo14sACO2e xO3XWMSBCsrZhzFxQEsMBrfd1rA/PCcgBq8kxJsnjPzS+Ep/G30bSotu4fkCOMScruyXtq ynauQfmobYDcmwoaQpWGqbmoCwljeJD4JpzKvIMO0eR6WDzCgZmx3vMDJSNPxC5GdlQzKi pohdKZocuJtgdf45DqqxHxO6wZSvw3iYooy04FDhiiUhd6x26IBD6xMNCeiXNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678038744; a=rsa-sha256; cv=none; b=ejxL2QEETXupOQaqtql/9bqlLeTE+B2p8PL7KsoPrOkoY0dzOptCjyROB31V52DGjcfA6H kU3y3v7ohLRr+Zjp8ZJhka7j2ZiHXoeq072bOc+MlqcK1RqU2Ds1IbVSpi7aMqmltl4jD8 E9/acr7VBv54VeRGrSM6hovpcNk1ly/vs0VloXsg/Wtu7Roykfwi8JkMs2rQYrYCPrKtDa Oi3GBTI7HxEkprVIyLyl9zyBz+Scj/hCwMUV1HzDhO2vCXHXY1X8PhUBoC8MtGtnDGkX2W gmKqlk74Thc7C3QnWZRq4gSAt+f7LTc8/rauVG14sLX1p8SRjLeGsPk4e8kg+A== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.21 X-Spam-Score: -3.21 X-Migadu-Queue-Id: 1403BE1F6 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: aODE9Kkt0/XB Hi Ludo’, On 2023-03-03 16:43, Ludovic Courtès wrote: > Bruno Victal skribis: > >> Due to (now renamed) 'hidden-service' record type not being exported, >> the only way hidden services could have worked is through the now deprecated >> 'tor-hidden-service' procedure which also had the issue that it can only >> be used once since the returned service always had the same name. >> >> This commit fixes the Tor service documentation and >> deprecates 'tor-hidden-service' procedure, correcting some inconsistencies along the way. > > I’m also leaving this one out for now. > > Could you please make it a separate patch series, with each aspect in > its own patch? I realize I’m asking you for extra boring work, but this > should help clarify the kind of changes we’re talking about. I think it's difficult to split this one into meaningful patches, reason being that 'tor-hidden-service-type' can't be used alone since the record constructor for a Tor hidden service (hidden-service, which is IMO a "collision prone" name) is not exported. The fact that it isn't exported also means that the 'hidden-services field from was impossible to configure. Extending 'tor-service-type' was also impossible save for the (to be deprecated) 'tor-hidden-service' procedure which provisions a 'tor-hidden-service-type' that is simply a service extension for 'tor-service-type'. The 'tor-hidden-service' and 'tor-hidden-service-type' are extremely misleading to what will happen behind the scenes should more than one hidden-service be provisioned (with 'tor-hidden-service'). Since it does so via a 'tor-hidden-service-type' which has its own name, only one of the hidden-services will get configured, which one = dice roll. IMO this 'tor-hidden-service-type' shouldn't exist at all and tor-hidden-service can safely be converted into a simple-service that extends tor-service-type. Cheers, Bruno