From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wC5wAKxBUWQwLwEASxT56A (envelope-from ) for ; Tue, 02 May 2023 19:00:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2AJNAKxBUWQ9GAEAauVa8A (envelope-from ) for ; Tue, 02 May 2023 19:00:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA7483FFE5 for ; Tue, 2 May 2023 19:00:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pttMO-0003kb-2F; Tue, 02 May 2023 13:00:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pttMB-0003jX-4E for guix-patches@gnu.org; Tue, 02 May 2023 13:00:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pttMA-0005V7-IU for guix-patches@gnu.org; Tue, 02 May 2023 13:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pttMA-0002Fr-Df for guix-patches@gnu.org; Tue, 02 May 2023 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63208] [PATCH v2] gnu: gstreamer: Ensure no bundle sources used Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 May 2023 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63208 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai , 63208@debbugs.gnu.org Received: via spool by 63208-submit@debbugs.gnu.org id=B63208.16830467698599 (code B ref 63208); Tue, 02 May 2023 17:00:02 +0000 Received: (at 63208) by debbugs.gnu.org; 2 May 2023 16:59:29 +0000 Received: from localhost ([127.0.0.1]:44913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pttLd-0002Ec-3U for submit@debbugs.gnu.org; Tue, 02 May 2023 12:59:29 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:50199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pttLa-0002EH-AQ for 63208@debbugs.gnu.org; Tue, 02 May 2023 12:59:27 -0400 Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-50bc075d6b2so6005287a12.0 for <63208@debbugs.gnu.org>; Tue, 02 May 2023 09:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683046759; x=1685638759; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=PRlvA6Da707QEGaeOqe4dfZOtkuAh6OGdWnRfF2cZAU=; b=BkypuDh2NVznmXRsk3EsawkiMjy7HcMlSt2Lh1ZdKxf380+s7rPcdm4eBCQ7aPjvXX 0IBKUidrhJ4NTEjWUj1J/ZjzaElFLJ6wpMe9ui7mSaJmsH38msRqtvkLN3zr1yrvZ1U0 y3ECFrz5ickOsfMT0UElRPUEKyLV6QV/X+ZwbqZrh5NROy/lA3wb0jKixSGMa7FSd7QM Zg+bn9aZtYVkXufsxEgmKjZV5VJugKC0jLXpHXj9ommR8ujXyS+sfQmsZZpFFc1+POLP OnPQRD5iAEaKc3dFDuoA2urLrXGI6rH26q8yK6Tc5Qkj8jtyyh5f7r+3Ix9ctT6kIBCP 8QjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683046759; x=1685638759; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PRlvA6Da707QEGaeOqe4dfZOtkuAh6OGdWnRfF2cZAU=; b=WxtIqSF/O+a/qOJF1s572ibYP5TrJI/dspm12MJdnryIHJY1WgbMdbh4XeQM7jljI5 vtT8fs1TVBVnMjiqPd/2yt/ZBeXBPq16HtuTnUkn9VT31N8TTlBQVsgzOxqtdp7Tti7k lYrnISobmdAkvcyy2Ol3WnPSdGhuRkx48vSjci7yfKEXby2MYlkdep/5O0stuUVCT0AY RMf1GoFIakOwgPSU6d7Bzi9f7jEhFfU0RXAtKvl8fz5BpQ4ca1GIuVonT2MUzbdex5uJ M7VEMfRoRgSUnFDVm9eJp/gN/m+3Aq2F6VP1ocBePmELSZ2O5P35jlAxEBruQEFAsVRN VM4Q== X-Gm-Message-State: AC+VfDzMlL8DX6sgdUEaWdEZWGU247GH9Oc0YVaBUBMMxMHUngNXO6Pt x2BwlpqVWKEjfkGQhN8TItG1sG7UD4EXeQ== X-Google-Smtp-Source: ACHHUZ4kosl2PgmLtSPFapiWR23TNxpLCfXzrv9sVNLXNDmT/FCeWtcljxIws8EieRnVJyaIix20kg== X-Received: by 2002:aa7:dc03:0:b0:506:bce0:48d6 with SMTP id b3-20020aa7dc03000000b00506bce048d6mr8268351edu.5.1683046759317; Tue, 02 May 2023 09:59:19 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id w7-20020a50fa87000000b0050bc7c882bfsm1997788edr.65.2023.05.02.09.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 09:59:18 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Tue, 02 May 2023 18:59:18 +0200 In-Reply-To: <20230502054853.31446-1-atai@atai.org> References: <20230502054853.31446-1-atai@atai.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683046827; a=rsa-sha256; cv=none; b=Ckv1CWIdOWz2EUPYkvz5D7nxKhJh9WhkaXhH5uMTnz4AGaYt4iaUFuSaxx1MfsdS9fYUb1 s0FVVX7jPwzGMjonPDFl9z/9s1ytdWEH37eOk0elJx5dSWl7fse/tBxOmN9PxbHw5FrgH7 F+DeABhAAJnqG5XyfStNkTdLbXR12X2XpafCraQI/0ZOVPsm9yVoAqjsCrqruO/EvtmKeM SU/DlK1G5+lLA4F4qx2aVejpQIJUICs+UeiSQoqhvb2AdXZk0ttOwJ2WVWsrbYrrsunAFi CWil6WTyQZmARi9ynE0XoC7iwdUHxAzteLXTfKtvpkbhOd3a5PsieNcJFMN4Ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BkypuDh2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683046827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PRlvA6Da707QEGaeOqe4dfZOtkuAh6OGdWnRfF2cZAU=; b=COewgAfCcBUPinYinvKFty7Jr9cJqvpqPWhoVD1qQlDgDCIwnW4dL64ZzjhR1tcx1b2Z65 vhDvHfJK/GaMVASk8k1YFg8P//Bd6+fp450c5d6CkGP1wYSgi46ddn1ktQSCgFZ1lzjS2o B3AJlEdxPusvj4v4SX4S+9dkkTjf82rT7VxZtcEavc77Nnvgxn/q3IQxHfiv0WcNHDtuOJ /KhEzjHaiz7ksdREl9D1KXYlgbECzKD8FQM8hJT1cB6g2yiRhgq3thRbcdX8H7nku9ooQQ XJCMNA++J2NvqGTbLR7J/1ENC5vVgtiPw6W22kWZc59Sd5j1vzg9IDpfvNmM3g== X-Migadu-Spam-Score: -1.60 X-Spam-Score: -1.60 X-Migadu-Queue-Id: AA7483FFE5 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BkypuDh2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: jQuP57iiq9+b Am Montag, dem 01.05.2023 um 22:48 -0700 schrieb Andy Tai: > * gnu/packages/gstreamer.scm: gstreamer: [arguments] (configure- > flags): Add "--wrap-mode=3Dnofallback" to ensure no subproject sources > in repo are used For the ChangeLog part, "Add ." is typically enough. Rationale ought to be explained before the ChangeLog or in the code -- preferably the latter for simple patches like the one at hand and the former if a complex topic needs to be summarized. =20 > --- > =C2=A0gnu/packages/gstreamer.scm | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm > index 8971c11479..55876268cc 100644 > --- a/gnu/packages/gstreamer.scm > +++ b/gnu/packages/gstreamer.scm > @@ -474,6 +474,7 @@ (define-public gstreamer > =C2=A0=C2=A0=C2=A0=C2=A0 (build-system meson-build-system) > =C2=A0=C2=A0=C2=A0=C2=A0 (arguments > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list #:disallowed-references (list python= ) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:configure= -flags #~(list "--wrap-mode=3Dnofallback") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phas= es > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #~(mod= ify-phases %standard-phases > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 #$@%common-gstreamer-phases >=20 > base-commit: 854c57c3525325070e261a2e6f81d4016ef44bfa On the topic of wrapping dependencies: In Guix, we prefer to unbundle them already through snippets in the source; thus, this configure-flag would be obsolete in the ideal case. You can of course still add it for good measure, but I'd argue it's more important to tackle the the actual bundle first. Cheers