From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mKKxLLSQfWBzRAAAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 16:16:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CEJgKLSQfWCBJwAA1q6Kng (envelope-from ) for ; Mon, 19 Apr 2021 14:16:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 239B78848 for ; Mon, 19 Apr 2021 16:16:20 +0200 (CEST) Received: from localhost ([::1]:49540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYUhG-0003aU-Vm for larch@yhetil.org; Mon, 19 Apr 2021 10:16:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYUh0-0003aE-Qt for guix-patches@gnu.org; Mon, 19 Apr 2021 10:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYUh0-0000NG-JM for guix-patches@gnu.org; Mon, 19 Apr 2021 10:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYUh0-0007c6-Fi for guix-patches@gnu.org; Mon, 19 Apr 2021 10:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [PATCH v2 00/26] Add github-cli and dependencies Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Apr 2021 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.161884175429247 (code B ref 47539); Mon, 19 Apr 2021 14:16:02 +0000 Received: (at 47539) by debbugs.gnu.org; 19 Apr 2021 14:15:54 +0000 Received: from localhost ([127.0.0.1]:51460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUgo-0007bb-N9 for submit@debbugs.gnu.org; Mon, 19 Apr 2021 10:15:54 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:13759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYUgj-0007bP-Aw for 47539@debbugs.gnu.org; Mon, 19 Apr 2021 10:15:49 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FP83x2p8Zz1LBCr; Mon, 19 Apr 2021 16:15:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FP83x2p8Zz1LBCr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618841741; bh=92t22CziaMTK51P3yO8LWCXZ+HYMXGZzkzkoMiSEokM=; h=Subject:From:To:Date:In-Reply-To:References:From; b=JLW/KzE9nV4IEpfAW61gisIle7MwpQ6dXiAL0ZfCTkYva9ehVpRgbJKNKW171ztPV lX8QVbDt6Rn32K380UBZJeiAX8BVB/0gye5mm0ktKfujYRan9KoLus7wlXtyZmjdqm pKictQdLZJoFn95tO6ISq7gjyTvMymWSq8q2yvd0= Message-ID: From: Leo Prikler Date: Mon, 19 Apr 2021 16:15:40 +0200 In-Reply-To: <87im4ie7bg.fsf@yoctocell.xyz> References: <87im4ie7bg.fsf@yoctocell.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618841780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=92t22CziaMTK51P3yO8LWCXZ+HYMXGZzkzkoMiSEokM=; b=lPfmxT9bgh6RnPSS6iZ6TzVQtyy2lg8x3e7HhYJv1M5QcRlQy/AHAej7mOyZe+Qez/L9F5 crrT1tU16t/sRNLvT+gnwO2kJtaJEex13TaDJVcPK0NOHmfe4hMAOgDlstaqn+ly1BqcjJ ptJ//0M1FarLSdso1ub1V9RcIBfGAKm8N6vemnhBvd0l+fBBuKll6oKa97INQIb7hLWMl+ NNI70Rz18v1pKkqPx9HKJnw0hFjde0blo4KF7l8ZZfGghshFuon/azCU7IkWteGZXqVl/x OzsPdmwAkVA0AslbVciRK5xhylseRUm/n/6qVcovTQ93Ived1GTUp2oHU4h7Hw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618841780; a=rsa-sha256; cv=none; b=qxRuAU+Mz9LYGEX7fllRZrS03/vyVLBJj7oywq7Bo9KPOGBezLO1x6VFNApm6VLWYQs7o1 8GxSpbJ0BYb1v8mKPrKyFoe7RlRBChQB/eb7wqVn5bJKW4oORhxRFLJtun1d/OgQHA4Hes +6q+1/UzCajYpCDtjAzKdKIgNweWQ8ussxD2f7F31Z9Uj78oZ0l0HBeQJQb3Ru1q58Ux8+ FmeuuckRf4eNwasj9WkNd11XtmVSDQZ1JPACan40fRyhLtUc971A/Q3SCSGumi/FyUYB/H sNO2ocJHPNwWN63TxWPx00oXketblNagAf/7YbxA0VO9JabznmwNW8Dhoz8Y/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="JLW/KzE9"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="JLW/KzE9"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 239B78848 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: hdbzKIBecguU Am Montag, den 19.04.2021, 15:24 +0200 schrieb Xinglu Chen: > Friendly ping! :) I think you fixed most of my concerns from the previous run, but looking at Patchwork, there appear to still be a few issues: 1. Some patches don't seem to apply correctly over at Patchwork [1]. This can perhaps be ignored, as it seems to be an issue with patches being received out of order and the last one applies cleanly. 2. The corresponding revision fails to build [2]. 3. The patch for safeexec still seems to be part of the series even though it's unused. Didn't you mean to exclude that one? Again, I'm not really familiar with the Go side of things, so while as a reviewer I can point out stuff, that is not aesthetically pleasing, as a committer I'm somewhat forced to trust what the CI tells me. I would personally feel more reassured if someone with a bit of Go experience had a look at this patch set, but judging from the 2 weeks of silence, it seems they are all sleeping or silently trusting me to do a good job. Regards, Leo [1] https://patches.guix-patches.cbaines.net/project/guix-patches/list/?series=7514 [2] https://data.guix-patches.cbaines.net/job/12256