From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +IrSBCyNN2I/FwAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 21:23:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8M+2ASyNN2LagQAAauVa8A (envelope-from ) for ; Sun, 20 Mar 2022 21:23:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B057139EAD for ; Sun, 20 Mar 2022 21:23:07 +0100 (CET) Received: from localhost ([::1]:46362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nW24w-0004wJ-TF for larch@yhetil.org; Sun, 20 Mar 2022 16:23:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nW24s-0004w4-CP for guix-patches@gnu.org; Sun, 20 Mar 2022 16:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nW24s-0001ok-3o for guix-patches@gnu.org; Sun, 20 Mar 2022 16:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nW24r-00044D-Pv for guix-patches@gnu.org; Sun, 20 Mar 2022 16:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd Resent-From: fesoj000 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 20:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.164780774015569 (code B ref 54309); Sun, 20 Mar 2022 20:23:01 +0000 Received: (at 54309) by debbugs.gnu.org; 20 Mar 2022 20:22:20 +0000 Received: from localhost ([127.0.0.1]:35185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW24C-000433-0v for submit@debbugs.gnu.org; Sun, 20 Mar 2022 16:22:20 -0400 Received: from mail-ej1-f44.google.com ([209.85.218.44]:42694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW249-00042k-A8 for 54309@debbugs.gnu.org; Sun, 20 Mar 2022 16:22:18 -0400 Received: by mail-ej1-f44.google.com with SMTP id j15so12196799eje.9 for <54309@debbugs.gnu.org>; Sun, 20 Mar 2022 13:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ikvD9lPIqfLH87srYPfq/TFoLobDizeZb0Bxb9KT/Jc=; b=V5jX/f/SdoruUTvaJ9ebQvYm18oJZeQVZI0O/dOjQwnQMMyeMQEaFGP9HZB0O0Xdzw I60LOAaIxN12bvkpwqXnqMjOTZrcMKT12NV5+ARJ3CBOaJh6lrvKupnGhB7EThFyUUeH a0kB4zEmz8+QFEbE0T+GjgBZQE3DQwrST+3ZQKG2STe/zxi+9JUhcdSIVU5YVynrg/2Z NjZszhCaocUuXXTy3a6y+o8BOc635/Q48OxhjApm4rhKd2DiTGN8QrastUwybYMwFBk7 YMY5kzLrqiEGzDHkTTxRDeE6P5PJgiVbWud2QcerRodnaEL5j5Mfm7GZWGeddSx+xx0H FZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ikvD9lPIqfLH87srYPfq/TFoLobDizeZb0Bxb9KT/Jc=; b=nDTiEMOgYAw+5CLKpdfBLAEZQgkx8PPky2fPV5UTc8JiUJXBcVY/PLxPujOoKO1h5Y DwFokfbMSuINX3OASpNLRAPJuKzIhBVTDYV0UIvO+007SB8osWIb2WXiMfXr3LK0Ye3B Vrvsf2cVfgAacKCLz1Gwa5CUmTfQtKEuoSxlvOYs/2QtY86rDN4z1sLvR2JWwE9KPHqR hLvVBNtp/40Sh2xgZsdmn84d1/MjSaGJYs5DBRvYNU2UyxdN2uz+3ay25b62dMvP6gG+ p+vBPRYsozETDoVYNaZBvh+1gVqqKK9fTSA7Q6hzgIOHJVK90SLtIAF+6il68w572FRr n/bQ== X-Gm-Message-State: AOAM530FsRDL76U+zjpgXFKKiqir3a3yr07zcThLOBcas7SVR60n6tNS d6itJKS1+iQCq+OWeKcrgLs= X-Google-Smtp-Source: ABdhPJyxmNR2IkjLogfAu8HBL+yQ/fhhF/tOJ+Iz13iK9T27Nwl58rs+4dF74hNUOuhfPG97zzM7HQ== X-Received: by 2002:a17:906:6158:b0:6ce:61d6:f243 with SMTP id p24-20020a170906615800b006ce61d6f243mr17203920ejl.268.1647807731388; Sun, 20 Mar 2022 13:22:11 -0700 (PDT) Received: from ?IPV6:2003:ee:af2f:e00:c2f9:c2bb:bf95:1fc5? (p200300eeaf2f0e00c2f9c2bbbf951fc5.dip0.t-ipconnect.de. [2003:ee:af2f:e00:c2f9:c2bb:bf95:1fc5]) by smtp.gmail.com with ESMTPSA id dm11-20020a170907948b00b006cf488e72e3sm5987860ejc.25.2022.03.20.13.22.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 13:22:11 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 21:22:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US References: <80cc8802439c49138638dee6d4fb9015723f9727.camel@telenet.be> From: fesoj000 In-Reply-To: <80cc8802439c49138638dee6d4fb9015723f9727.camel@telenet.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647807787; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ikvD9lPIqfLH87srYPfq/TFoLobDizeZb0Bxb9KT/Jc=; b=GN+T4AZX+7XTdnQ2E7+GvKw0AdDhen9lCXaFJaL/WA1EsZZ4RvCwMqQpCSHLW2acLZDovo lUpomsUdGolLc++GLB340z49fRz38Q+zqyJXlv4ZwWqvSKOkVCtI/J3wlIuLO0TSziwVuu sY37I0mP5b3nKfqz+ji2YFUak2xpphFTx+AdF/1DsFOu/5WjPdHQUw1OTuTmzMblrBHQdt U9DqpZw9v964sE3X4HacAovtf3CeApvkt4Z0OWWpMZcev2YK5cVenBaqxiz+P9aTE1virf kTLncmCfbn3lLABZNvIRFruCpcbHP9GU0VyHKQfJgo+ds0yWNNnV1Y/8lhMlew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647807787; a=rsa-sha256; cv=none; b=UzZxgNPHdofl3d/aXgZVGWaEJXvYrqBAgPwR7ayiryCyTQuOb1dP9EnDsz4d2LtCUnypIf pTtoNDX4cDlf+E/r9xOvCLYCnZCawDkyPSKZCOnFrHXC1XQpocdMWALRBMf1HxQXUvQmNr jCLWMs/OODLP04EXR47xEx46ki9dDp1/3XS3toeMURxgYzI6G/ZkIAOIq1USISV+/bvpvL gy6lCzthG4072w79128uSezxn/txpzne4ZohlBcsnYBaghqGeO1ndCnsArKSP5dqcdNjqb o3A44WqvAqQexjGY24H5WhssD0p1YMIROBAizOfvBctfj0ryItLLtR/sLa70pA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="V5jX/f/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="V5jX/f/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B057139EAD X-Spam-Score: 4.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: O+p0rcEvEHQf On 3/20/22 12:13 AM, Maxime Devos wrote: > fesoj000 schreef op za 19-03-2022 om 12:34 [+0100]: >> +        (let* ((previous-umask (umask #o077))) >> +          (mkdir-p "/var/log/audit") >> +          (umask previous-umask))))) > > I cannot recommend this, what if 'mkdir-p' throws an exception? > That might cause problems. Or maybe not, but it would require > some analysis that can be avoided with 'mkdir-p/perms'. Hm, but i still have to set umask to prevent TOCTOU, the implementation of 'mkdir-p/perms' does not take care of that. BR