all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonathan Brielmaier <jonathan.brielmaier@web.de>
To: 38994@debbugs.gnu.org
Subject: [bug#38994] [PATCH core-updates] gnu: glib: Fix g_app_info_get_default_for_type.
Date: Tue, 7 Jan 2020 00:04:32 +0100	[thread overview]
Message-ID: <dcb6ecd9-2a4b-469a-09e7-8928318a47f9@web.de> (raw)
In-Reply-To: <20200106193751.725-1-dannym@scratchpost.org>

Hey Danny,

On 06.01.20 20:37, Danny Milosavljevic wrote:
> Fixes <https://bugs.gnu.org/38524>.
> Reported by Reza Alizadeh Majd <r.majd@pantherx.org>.

I think the bug link is wrong (it's about dhcp services).

>
> * gnu/packages/glib.scm (glib)[arguments]<#:phases>[patch-gio-launch-desktop]:
> New phase.
> [move-executables]: Modify.
> ---
>  gnu/packages/glib.scm | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index 369bd373ac..9551509a53 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -213,6 +213,15 @@ shared NFS home directories.")
>                   (string-append "command_line = g_strdup_printf (\""
>                                  dbus "/bin/dbus-launch")))
>                #t)))
> +        (add-after 'unpack 'patch-gio-launch-desktop
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let ((out (assoc-ref outputs "out")))
> +              ;; See also <https://gitlab.gnome.org/GNOME/glib/issues/1633>
> +              ;; for another future fix.
> +              (substitute* "gio/gdesktopappinfo.c"
> +               (("gio-launch-desktop")
> +                (string-append out "/bin/gio-launch-desktop")))
> +              #t)))
>          (add-before 'build 'pre-build
>            (lambda* (#:key inputs outputs #:allow-other-keys)
>              ;; For tests/gdatetime.c.
> @@ -321,6 +330,13 @@ shared NFS home directories.")
>                (mkdir-p bin)
>                (rename-file (string-append out "/bin")
>                             (string-append bin "/bin"))
> +              ;; This one is an implementation detail of glib.
> +              ;; It is wrong that that's in "/bin" in the first place,
> +              ;; but that's what upstream does right now.
> +              ;; See <https://gitlab.gnome.org/GNOME/glib/issues/1633>.
> +              (mkdir (string-append out "/bin"))
> +              (rename-file (string-append bin "/bin/gio-launch-desktop")
> +                           (string-append out "/bin/gio-launch-desktop"))
>                ;; Do not refer to "bindir", which points to "${prefix}/bin".
>                ;; We don't patch "bindir" to point to "$bin/bin", because that
>                ;; would create a reference cycle between the "out" and "bin"

I would personally like, if we can update to 2.62. Because that is
needed for updating gnome to 3.34
(https://gitlab.com/jonsger/Guix/commits/wip-gnome-3.34). What do you think?

~Jonathan

  reply	other threads:[~2020-01-06 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 19:37 [bug#38994] [PATCH core-updates] gnu: glib: Fix g_app_info_get_default_for_type Danny Milosavljevic
2020-01-06 23:04 ` Jonathan Brielmaier [this message]
2020-01-06 23:45   ` Danny Milosavljevic
2020-01-07  9:22     ` Jonathan Brielmaier
2020-01-13 21:50 ` Marius Bakke
2020-01-14  0:59   ` bug#38994: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcb6ecd9-2a4b-469a-09e7-8928318a47f9@web.de \
    --to=jonathan.brielmaier@web.de \
    --cc=38994@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.