From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sLZmI43tL2Pv5wAAbAwnHQ (envelope-from ) for ; Sun, 25 Sep 2022 07:56:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KH9yIo3tL2M/AwEAG6o9tA (envelope-from ) for ; Sun, 25 Sep 2022 07:56:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AB7F3C8B5 for ; Sun, 25 Sep 2022 07:56:29 +0200 (CEST) Received: from localhost ([::1]:43824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocKct-0005sH-NI for larch@yhetil.org; Sun, 25 Sep 2022 01:56:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocKbX-0005ru-K6 for guix-patches@gnu.org; Sun, 25 Sep 2022 01:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocKbW-0001W7-3w for guix-patches@gnu.org; Sun, 25 Sep 2022 01:55:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocKbW-0007zc-0r for guix-patches@gnu.org; Sun, 25 Sep 2022 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57675] [PATCH v11 7/8] gnu: telegram-desktop: Update to 4.2.0. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Sep 2022 05:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57675 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: 57675@debbugs.gnu.org Received: via spool by 57675-submit@debbugs.gnu.org id=B57675.166408526830676 (code B ref 57675); Sun, 25 Sep 2022 05:55:01 +0000 Received: (at 57675) by debbugs.gnu.org; 25 Sep 2022 05:54:28 +0000 Received: from localhost ([127.0.0.1]:45692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocKay-0007yi-6o for submit@debbugs.gnu.org; Sun, 25 Sep 2022 01:54:28 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:34458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocKaw-0007yV-1q for 57675@debbugs.gnu.org; Sun, 25 Sep 2022 01:54:27 -0400 Received: by mail-ej1-f65.google.com with SMTP id y3so8156611ejc.1 for <57675@debbugs.gnu.org>; Sat, 24 Sep 2022 22:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date; bh=+34yVbo6LQ+lcKVSeRYww2kAjxTiqQq5mPoyUB2cFHI=; b=BNZIEyPRFZmOwGmqU13KPnMm2IPwdLv435/OYt5+yBVMvhIAIE0Sdt/hmBMwajYyVZ uBSMIpcUT6FJHGbMNj2oWndXfcMeySAV3YOWcFDLZZdEHLpvNuhg9JCR1rt2m/spB8w6 cCxaOpC07UJsKL2v9+JZZxC98UBKuitKDTr+oR8Sk6RdZMtp2TqKDv64BVtGPrN7q87w 2tXOf2fL65B9SQm7Y9RCpezsVDQJNUMsfZNMc2iFo3Y2ljwfNlsTF9R3D0sMQKOy1XW+ Iy+1fyx5gvD9yJ1DYRvvvnRkGw+OCVFHH2EuBsYAMlRFR09ysLXw4fxhbCu6lkIyoBTo fZ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=+34yVbo6LQ+lcKVSeRYww2kAjxTiqQq5mPoyUB2cFHI=; b=CCVbJa8rN1G1iJppNVrQ5y5zDiZ8UqAfOLfYH0qU+vkBv7TFX4bgkaQHuTrDfIuclw hExZPqaPFHFCMFA72Cldl7gy/5UF89pPxzMq8qAIb/7YGbFAOMMF+GpDybXa3kKXNiI0 EnvJum5jg9nIuLb6S8/NPq0YkSVmkbwT9JaUfCXz6sX1JI5QqN2MuUUtC8/FqnTYPbEi hOqH8ylWDbUZxYvPpDeprJbaPqHJMeIQsNd8wKINZKRR/Qw5bDnuqYlTH7WeiWBv2PqO NFfkJ8pPcqxo7BBKSE8Du19ZLercuuWgBJnacSwHrhBrJZ5NknjW6l2YOBaSOG2tZ3y4 q4uw== X-Gm-Message-State: ACrzQf3cJCs8/cjfck4ngoJw040BSnHSy/OiD9V/OJdKu/k5MBiG0zuX gix5O/2kZOhFBW7BsiEpdp0= X-Google-Smtp-Source: AMsMyM7yMZqxtEpyeSprGoHnwsqkll26eErt1Q1kC/FhSSug/llTM+s1e8PAAURyk+xeBOz8vlCrXA== X-Received: by 2002:a17:907:2721:b0:77f:d471:47b3 with SMTP id d1-20020a170907272100b0077fd47147b3mr13704589ejl.591.1664085260225; Sat, 24 Sep 2022 22:54:20 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id en26-20020a056402529a00b0043ba7df7a42sm8846572edb.26.2022.09.24.22.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 22:54:19 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sun, 25 Sep 2022 07:54:18 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664085389; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+34yVbo6LQ+lcKVSeRYww2kAjxTiqQq5mPoyUB2cFHI=; b=K3mL95BYKYZM+uRTojOwgr0wlvTAn9ayE8V9mF50NwsVMIgxXC/tQG2YHqVffVfcWQpZZa rQ4h79FXphRV0p4bz2XqGTawZVsbr+CqmPvgAYnwXWdQaeiVSo9de9JHbHFDnMrXq6NR0e w8V4DOEKyW7V9/otcAeIaiQoqY3JmgT04gH7eiDwkT558CNqymalRa7POFrTlWLSVTg3wX ziVt2Yp8euigySS3rJqXPRqn7llovq017Vddj3Qss/p6A96ul6GJ7jULMoGjeuzw/Q+smf 3IZENPPYKIHnUo3R1ceSZUcO/BbjhukWaJgWIh16EV4nSbRKuuUYBJFTnX+oLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664085389; a=rsa-sha256; cv=none; b=QNNL5Z35N9KBGcQiHGqEVJBn0iO1kghFTCvyGp9q7w3JQhsnSDeFKYok6kbHx0UoX6VUYn gzuzOz2VkBh6uvYwevMc1yrhWESaX2pxgHSb5Fv8l3gss6+/aU47nuenmtK/NK+CmF0s6U SZaHFl0mf+Z+Dj1rUczhkECW9+3pJQl268olMEmAN0etbIt/iUjgtX8nblmGNx9pWOEz7r zknIf2Af3iK7jisBm39qlfAmYiDP56yEVJDvLkHHE43gKWOg3MA1JEENXzd58T9NBdF7zk 6w7qXdqXUq3sRY0s66lQLaZ/MY4slrF0NTmCCrpMh9KXTf80Bm2OO2buPsHH1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BNZIEyPR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BNZIEyPR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2AB7F3C8B5 X-Spam-Score: 7.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: yXgdAoeMKkIB Am Sonntag, dem 25.09.2022 um 07:52 +0800 schrieb Hilton Chain: > On Sat, 24 Sep 2022 15:58:33 +0800, > Liliana Marie Prikler wrote: > > Please introduce this in an earlier commit.=C2=A0 Also, since this is a > > third-party package, not a telegram-owned one, it'd be nice if we > > could use upstream versioning, but that seems tied to another > > package too (swift in particular).=C2=A0 Alternatively, you could simpl= y > > use "1.3" as per CMakeLists as a base point. >=20 > I'd tried packaging both crc32c and libdispatch, are those two names > suitable? And then, what's the proper place to place libdispatch in? Probably maybe. I'm not aware of any other project taking their name (apart from forks, obviously), and they're more than 3 letters each, so I think it'll be fine. As for the location of libdispatch, if we had a swift.scm (which we probably won't until someone packages swift), it'd go there, but for now c.scm is fine imho. > Applied Gentoo's patch (for unbundling crc32c) to webrtc-for- > telegram-desktop, however when > configuring telegram-desktop with this, it errors out as follows, > what should I do next? Uhm... which patch is "Gentoo's patch"? I don't see anything relevant here [1]. > #+BEGIN_QUOTE > CMake Error at Telegram/CMakeLists.txt:7 (add_executable): > =C2=A0 Target "Telegram" links to target "Crc32c::crc32c" but the target > was not > =C2=A0 found.=C2=A0 Perhaps a find_package() call is missing for an IMPOR= TED > target, or > =C2=A0 an ALIAS target is missing? >=20 > CMake Error at Telegram/cmake/lib_tgcalls.cmake:7 (add_library): > =C2=A0 Target "lib_tgcalls" links to target "Crc32c::crc32c" but the > target was > =C2=A0 not found.=C2=A0 Perhaps a find_package() call is missing for an > IMPORTED > =C2=A0 target, or an ALIAS target is missing? > Call Stack (most recent call first): > =C2=A0 Telegram/CMakeLists.txt:34 (include) >=20 >=20 > CMake Error at Telegram/cmake/td_ui.cmake:7 (add_library): > =C2=A0 Target "td_ui" links to target "Crc32c::crc32c" but the target was > not > =C2=A0 found.=C2=A0 Perhaps a find_package() call is missing for an IMPOR= TED > target, or > =C2=A0 an ALIAS target is missing? > Call Stack (most recent call first): > =C2=A0 Telegram/CMakeLists.txt:39 (include) > #+END_QUOTE Hmm, I think you'll have to patch the CMakeLists, which expect a slightly different version. You could also try packaging a second crc32c, which inherits from upstream, but uses the Telegram-blessed commit. Cheers [1] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/telegram-desktop/= files