From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55385) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAW92-00072N-2F for guix-patches@gnu.org; Wed, 18 Sep 2019 05:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAW91-0005F8-1r for guix-patches@gnu.org; Wed, 18 Sep 2019 05:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44771) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAW90-0005F2-Oa for guix-patches@gnu.org; Wed, 18 Sep 2019 05:21:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iAW90-0001gV-HG for guix-patches@gnu.org; Wed, 18 Sep 2019 05:21:02 -0400 Subject: [bug#37444] [PATCH] added aerc, a simple email client and its dependcies Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Wed, 18 Sep 2019 02:20:26 -0700 From: Martin Becze In-Reply-To: <87woe6nfka.fsf@elephly.net> References: <20190918082313.3514-1-mjbecze@riseup.net> <87woe6nfka.fsf@elephly.net> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 37444@debbugs.gnu.org Certainly! I'll get that up later today. On the propagated-inputs issue. So I might be wrong here. But since all the go libraries are source only it doesn't matter to the end result if the are propagated or not if the libraries are used as `native-inputs`.. they shouldn't be left lying around (I think?). Now the reason why the need to be propagated is that when the go compiler go to compile the top level app (aerc) it needs to have in it's GOPATH all of the dependencies and the dependencies of the dependencies. The other way to do it is to put all of dependencies and the dependencies of the dependencies in the native-input. But that didn't seem right to me. Let me know what you think! On 2019-09-18 09:01, Ricardo Wurmus wrote: > Hi Martin, > >> This adds aerc, which is a terminal based email client written in go. > > Thank you for your patch! > > Could you please separate the independent changes into separate commits > and add commit summaries? For example, the update of > go-github-com-mitchellh-go-homedir should be done separately. > > Please also explain why “inputs” had to be changed to > “propagated-inputs” in some packages, and mention these kind of changes > in the commit summary. > > Thanks!