From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mH0UIVE9pmP6LQAAbAwnHQ (envelope-from ) for ; Sat, 24 Dec 2022 00:44:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SG55IFE9pmOpcgEAG6o9tA (envelope-from ) for ; Sat, 24 Dec 2022 00:44:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FF5C13C33 for ; Sat, 24 Dec 2022 00:44:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8rhs-0002WF-O8; Fri, 23 Dec 2022 18:44:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8rhq-0002Vk-U2 for guix-patches@gnu.org; Fri, 23 Dec 2022 18:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8rhq-0000YZ-Ls for guix-patches@gnu.org; Fri, 23 Dec 2022 18:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p8rhq-0003SZ-9P for guix-patches@gnu.org; Fri, 23 Dec 2022 18:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60153] [PATCH v2 1/3] gnu: python-pygame: Update to 2.1.2. Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Dec 2022 23:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60153 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Faiz Cc: 60153@debbugs.gnu.org Received: via spool by 60153-submit@debbugs.gnu.org id=B60153.167183899513265 (code B ref 60153); Fri, 23 Dec 2022 23:44:02 +0000 Received: (at 60153) by debbugs.gnu.org; 23 Dec 2022 23:43:15 +0000 Received: from localhost ([127.0.0.1]:39497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8rh5-0003Rs-2W for submit@debbugs.gnu.org; Fri, 23 Dec 2022 18:43:15 -0500 Received: from knopi.disroot.org ([178.21.23.139]:56810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8rh3-0003Rm-A9 for 60153@debbugs.gnu.org; Fri, 23 Dec 2022 18:43:14 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4817540DDE; Sat, 24 Dec 2022 00:43:11 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id llFMdo7fTmgV; Sat, 24 Dec 2022 00:43:10 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1671838990; bh=jU6ZOn0yTU3CU4CJKRakh6IwXzk7GT10gwX6BisfMwg=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=Mu60V0Jw1xYC8E4TkF8eOx6e8Jm7fNW8j2jz/Mfs0c2VVCM9R2WUf2pZo+NQrYVC1 M36g+JoN6LFOlRGY1TzVkpl6a78D2wHFTaH8B7sXUtsJjSxk2HgOJ8e4GljrxQG8YJ NmvMJNbVLeoeEkxR2ce9khaxnQ/pGGqmNoggi+B8H5i+zCVh4TSQWji/3TXQScOe6v OSc6GfehcFUEyyEfnjkkxeQGFc0rIHaJhbkTTvC8vDRCJrhrjHCdyce99cDJNpWR0Q 4Cd03rmBsEuEYC8r6Cw3CRD4bDLGPMq0tMqUKmcDPBiEGuNWJAByDFtlIRHZkUOH0L McA7QxBnfTWLg== Date: Sat, 24 Dec 2022 07:43:06 +0800 MIME-Version: 1.0 Content-Language: en-US References: <8c518a46ea2d8332ccbb55cb00574b75db982558.camel@disroot.org> <61b652bc-7769-4cc7-43e2-fd08e73313ed@disroot.org> In-Reply-To: <61b652bc-7769-4cc7-43e2-fd08e73313ed@disroot.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671839057; a=rsa-sha256; cv=none; b=LOiqfat3VoxCSw1VbSLOhIrgoE889nmb3JIkupgVAxPUxHktmrvxUW5DiNg2NzfXAQR+Yn /cchwOWuVPQAdrhci78NuPvVaa070N7x8a1OqF83OpvbXInjnkJRCgsLxd2Fp4DCeltUCu N04AMXaqx6XTNfyWu5LCJLF4osCIRVwB//uUp8O8qApcHeQi+rGAtjrCoClePjkhoxADTz FONYvJiMOIBwIL+Jyyl/nIH3M/xMr75NOCKhz8Kjren78/Hdu8I8dsLb5TQU0UMgwo414p ASsH3dDl5r74c5lm+IGzTzCOC+SngcW74QigfzCuCJwwM1zyjAKK3gvG9kRYsg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Mu60V0Jw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671839057; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=N3VOfsuHCR5ftRdhNbEc79dkvLGGQC71Km0TjJxZceE=; b=u2gMyWF1JudM3umHRAJjoVciVW9Wy5UlKyBX5TzHED1TLKpROMNDZNkF9JPRJhaQ1ThdBR AF6DfeVF7S8An+Ci5rO3WDnIwgGHGRt7KPUHirmDYNaSjM6+CDtYe57z1pot/ZnXj652gi gT7hxoEy05DfiXGaBOH7IlwZH6DFasJlQBQWKr1sDoclM739PZFH4aQEROzjROY70734ds KmpkvVmqbovX9qiVvS+3EYDGhzjuafoFGzie5Q0EslC7DKD9+qm6e2ieLYx73W/bbG0wfD /ATABq5lOHVidyzMxslFJ9qF8iLjIwUgHIgfmkYpQ++Kl84vlStLCM5S4ZC8MQ== X-Spam-Score: -2.31 X-Migadu-Queue-Id: 2FF5C13C33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Mu60V0Jw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.31 X-TUID: syh3o5oPXzlu On 12/24/22 07:20, Adam Faiz wrote: > + (("incdirs = \\[\\]") "incdirs = origincdirs") > + (("libdirs = \\[\\]") "libdirs = origlibdirs")))) I didn't do this kind of thing, because I didn't want to hardcode these. Most systems that pygame supports want to stay with the defaults. > (substitute* "buildconfig/config_unix.py" > (("localbase.d") "d" > #~(modify-phases %standard-phases > ;; Pass the dependencies to the configure script > ;; through environment variables. > (add-before 'build 'set-library-paths > (lambda _ > (setenv "LOCALBASE" " ")))))) I added this so that Guix as well as other systems can choose to pass the dependencies at the precise locations, otherwise it uses the defaults and doesn't affect those that use the defaults. I hope this clarifies my understanding of this issue. I like that Guix can provide patched and sometimes enhanced package sources while Guix-specific things stay in the build phases.