From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTZxL-0006YN-8Y for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTZxK-0001SP-Nv for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTZxK-0001SK-C2 for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTZxK-0000LB-9K for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:02 -0400 Subject: [bug#40918] [PATCH] openjdk 14 package Resent-Message-ID: References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> <20200429003859.3abd5a7a@alma-ubu> From: Michael Zucchi Message-ID: Date: Wed, 29 Apr 2020 09:17:22 +0930 MIME-Version: 1.0 In-Reply-To: <20200429003859.3abd5a7a@alma-ubu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-AU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 40918@debbugs.gnu.org On 29/4/20 8:08 am, Björn Höfling wrote: > On Tue, 28 Apr 2020 10:56:55 +0930 > Michael Zucchi wrote: > >> This mostly is just a simple copy of openjdk12 with changed links. >> openjdk13 is also included as it must be used to bootstrap openjdk14. >> >> openjdk14 uses "help" as a rather poor choice of autoconf test for >> the availability of a shell builtin and this isn't available in >> bash-minimal, so a small patch is needed to make configure complete. >> I've contacted the openjdk developers with a suggested change but so >> far have had no response after a couple of business days. >> >> > Hi Michael, > > thank you for your patch. > > When sending in the second version of your > patch, could you please split up the commits, having one distinct > commit per added/changed package. > > Please update your commit message according to the Changelog-style. You > will find examples in the old commit logs, for example for how to add > the patch-file. > > Excited to see your second version, > > Björn > I'm sorry i don't understand your second point, i used emacs changelog mode to create the commit message.