all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* GuixSD system reconfigure error
@ 2018-08-29 21:20 Hebi Li
  2018-08-30 10:28 ` Pierre Neidhardt
                   ` (2 more replies)
  0 siblings, 3 replies; 18+ messages in thread
From: Hebi Li @ 2018-08-29 21:20 UTC (permalink / raw)
  To: help-guix


Hi,

I installed GuixSD on my machine a few months ago. I have reconfigured
about 10 times, and the latest build was Aug 02, 2018. I was
reconfiguring the system today to add SSH service, but the build was
unsuccessful (I don't think the SSH service is the culprit, I tried to
remove it, using the exact config.scm on Aug 02, still the same error).

Here's the config.scm I'm using:

    https://github.com/lihebi/dothebi/blob/master/config.scm

I did:

              sudo guix pull
              sudo guix system reconfigure config.scm

The error message is attached at the end of this email. The `guix system
build` and `guix system vm` both failed for the same reason.  I tried
the QEMU image downloaded from GuixSD website, and the exact config.scm
file can be built successfully.

Does anyone has clue about what's going on?

------------------------------
The error message:

grafting ...
grafting ...
grafting ...
grafting ...
grafting '/gnu/store/n3vlhlkgmrdjzxyb9rpz4j6zs952q467-libinput-1.11.3' -> '/gnu/store/p9gq0lwgrbc1kmxw7zq2vavzh4yzdii5-libinput-1.11.3'...
Backtrace:
           8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
In ice-9/eval.scm:
    619:8  7 (_ #f)
   626:19  6 (_ #<directory (guile-user) 7cf140>)
    159:9  5 (_ _)
In gnu/build/linux-modules.scm:
   184:47  4 (recursive-module-dependencies _ #:lookup-module _)
    98:14  3 (module-dependencies _)
    85:18  2 (modinfo-section-contents _)
In ice-9/ports.scm:
   439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
In unknown file:
           0 (open-file #f "r" #:encoding #f #:guess-encoding #f)

ERROR: In procedure open-file:
Wrong type (expecting string): #f
builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1
cannot build derivation `/gnu/store/m61r4m2aaz46njlk99zy3jni6xzdv321-init.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/8a2axqx8v0kmmg8gxg350zhqbp934dfm-raw-initrd.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/np7cbyg43ddr2aanqlhvvr5swrkwyi18-grub.cfg.drv': 1 dependencies couldn't be built
guix system: error: build failed: build of `/gnu/store/np7cbyg43ddr2aanqlhvvr5swrkwyi18-grub.cfg.drv' failed


-- 
Hebi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-29 21:20 GuixSD system reconfigure error Hebi Li
@ 2018-08-30 10:28 ` Pierre Neidhardt
  2018-08-30 11:05   ` Tobias Geerinckx-Rice
  2018-08-30 15:22 ` Ricardo Wurmus
  2018-11-09 11:55 ` GuixSD system reconfigure error swedebugia
  2 siblings, 1 reply; 18+ messages in thread
From: Pierre Neidhardt @ 2018-08-30 10:28 UTC (permalink / raw)
  To: Hebi Li; +Cc: help-guix

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

Is your guix out of date?
To update guix, don't use sudo:

   guix pull

is enough.  Can you build libinput directly?

   guix build -K libinput

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-30 10:28 ` Pierre Neidhardt
@ 2018-08-30 11:05   ` Tobias Geerinckx-Rice
  0 siblings, 0 replies; 18+ messages in thread
From: Tobias Geerinckx-Rice @ 2018-08-30 11:05 UTC (permalink / raw)
  To: Hebi Li; +Cc: help-guix

Hebi, Pierre,

Pierre Neidhardt wrote:
> To update guix, don't use sudo:
>
>    guix pull
>
> is enough.

You'll also have to adjust your sudo invocation accordingly:

  $ sudo -E guix system reconfigure config.scm

This lets sudo keep your regular user's environment (and hence 
guix version).

Kind regards,

T G-R

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-29 21:20 GuixSD system reconfigure error Hebi Li
  2018-08-30 10:28 ` Pierre Neidhardt
@ 2018-08-30 15:22 ` Ricardo Wurmus
  2018-08-30 19:51   ` Hebi Li
  2018-11-09 22:47   ` [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it swedebugia
  2018-11-09 11:55 ` GuixSD system reconfigure error swedebugia
  2 siblings, 2 replies; 18+ messages in thread
From: Ricardo Wurmus @ 2018-08-30 15:22 UTC (permalink / raw)
  To: Hebi Li; +Cc: help-guix


Hi,

>     https://github.com/lihebi/dothebi/blob/master/config.scm

I see you use the “shpchp” kernel module.  This no longer exists in the
latest version of the kernel Linux.  That’s what this really bad error
message tries to tell you:

> Backtrace:
>            8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
> In ice-9/eval.scm:
>     619:8  7 (_ #f)
>    626:19  6 (_ #<directory (guile-user) 7cf140>)
>     159:9  5 (_ _)
> In gnu/build/linux-modules.scm:
>    184:47  4 (recursive-module-dependencies _ #:lookup-module _)
>     98:14  3 (module-dependencies _)
>     85:18  2 (modinfo-section-contents _)
> In ice-9/ports.scm:
>    439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
> In unknown file:
>            0 (open-file #f "r" #:encoding #f #:guess-encoding #f)
>
> ERROR: In procedure open-file:
> Wrong type (expecting string): #f
> builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1

(I only know this because I had the same problem.)  Obviously, this
error message should be changed.

As a workaround you could switch to the LTS kernel where that module
still exists.

--
Ricardo

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-30 15:22 ` Ricardo Wurmus
@ 2018-08-30 19:51   ` Hebi Li
  2018-08-30 20:54     ` Ricardo Wurmus
  2018-11-09 22:47   ` [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it swedebugia
  1 sibling, 1 reply; 18+ messages in thread
From: Hebi Li @ 2018-08-30 19:51 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: help-guix

Hi Ricardo,

Thanks, I believe this is the reason. Today when I run several rounds of
build, the `kernel module not found "shpchp"` error pops out here and
there (it isn't there yesterday ..)

I used initrd-modules and "shpchp", because back when I first installed
the system, the example configure file had them. I don't think I really
need the modules. So I tried removing it, but system seems to prevent me
from doing that, by throwing the error:

   <unknown location>: error: you may need these modules in the initrd
   for /dev/sda2: shpchp

It seems weired to me, in two ways:

1. why the system is preventing me from removing "shpchp" module? How
does it relate to /dev/sda2 (which is my root partition in ext4)?

2. I downloaded the latest QEMU image [1], run as root the `guix pull`
and `guix system reconfigure` with the exact config.scm (with modified
boot loader configure of course), and there isn't any issue. I believe
that build should also use the latest kernel, which should also have
missed the module "shpchp".

Next, I would probably try to reinstall the system, without the
`initrd-modules` configuration.


[1] https://alpha.gnu.org/gnu/guix/guixsd-vm-image-0.15.0.x86_64-linux.xz

-- 
Hebi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-30 19:51   ` Hebi Li
@ 2018-08-30 20:54     ` Ricardo Wurmus
  2018-08-30 22:48       ` Hebi Li
  0 siblings, 1 reply; 18+ messages in thread
From: Ricardo Wurmus @ 2018-08-30 20:54 UTC (permalink / raw)
  To: Hebi Li; +Cc: help-guix


Hi,

> I used initrd-modules and "shpchp", because back when I first installed
> the system, the example configure file had them. I don't think I really
> need the modules. So I tried removing it, but system seems to prevent me
> from doing that, by throwing the error:
>
>    <unknown location>: error: you may need these modules in the initrd
>    for /dev/sda2: shpchp
>
> It seems weired to me, in two ways:
>
> 1. why the system is preventing me from removing "shpchp" module? How
> does it relate to /dev/sda2 (which is my root partition in ext4)?

You may need to pass --skip-checks after removing the module.  By
default Guix tries to prevent you from accidentally installing an
unusable system.

The reason for the problem here is that the current kernel needs
“shpchp”, but the target kernel doesn’t.  We cannot know what the target
kernel needs before it is built.

This problem is currently being discussed here:

  http://issues.guix.info/issue/32524

In short: there’s nothing wrong with what you’re doing and Guix is a
little over-protective in this rare instance where a kernel module
ceases to exist with an upgrade of Linux.

--
Ricardo

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-30 20:54     ` Ricardo Wurmus
@ 2018-08-30 22:48       ` Hebi Li
  0 siblings, 0 replies; 18+ messages in thread
From: Hebi Li @ 2018-08-30 22:48 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: help-guix

Awesome, removing the modules and adding --skip-checks fixed my
problem. Thanks!

-- 
Hebi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-08-29 21:20 GuixSD system reconfigure error Hebi Li
  2018-08-30 10:28 ` Pierre Neidhardt
  2018-08-30 15:22 ` Ricardo Wurmus
@ 2018-11-09 11:55 ` swedebugia
  2018-11-12  7:53   ` Hebi Li
  2 siblings, 1 reply; 18+ messages in thread
From: swedebugia @ 2018-11-09 11:55 UTC (permalink / raw)
  To: Hebi Li, help-guix

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi :)

On 2018-08-29 23:20, Hebi Li wrote:
> Hi,
>
>
> Here's the config.scm I'm using:
>
>      https://github.com/lihebi/dothebi/blob/master/config.scm

Reading your config out of curiosity I stumpled upon this:

;; FIXME how to declare a local package list to install automatically?

Did you find a solution to this?
To my knowledge the simplest way, albeit not automatic, is to login as 
the user and install a manifest with
$ guix package --manifest (see the manual for details)

-- 
Cheers
Swedebugia

[-- Attachment #2: Type: text/html, Size: 1436 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-08-30 15:22 ` Ricardo Wurmus
  2018-08-30 19:51   ` Hebi Li
@ 2018-11-09 22:47   ` swedebugia
  2018-11-10 12:03     ` swedebugia
  1 sibling, 1 reply; 18+ messages in thread
From: swedebugia @ 2018-11-09 22:47 UTC (permalink / raw)
  To: 33329, rekado


[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

Hi

Ricardo, you mentioned that this needs to be fixed.

I made a patch to fix this. I did not test the patch as I have no idea 
how to do that.

I have not run the indent script on it.

Se attachment


-------- Forwarded Message --------
Subject: 	Re: GuixSD system reconfigure error
Date: 	Thu, 30 Aug 2018 17:22:53 +0200
From: 	Ricardo Wurmus <rekado@elephly.net>
To: 	Hebi Li <lihebi.com@gmail.com>
CC: 	help-guix@gnu.org




Hi,

>      https://github.com/lihebi/dothebi/blob/master/config.scm

I see you use the “shpchp” kernel module. This no longer exists in the
latest version of the kernel Linux. That’s what this really bad error
message tries to tell you:

> Backtrace:
>             8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
> In ice-9/eval.scm:
>      619:8  7 (_ #f)
>     626:19  6 (_ #<directory (guile-user) 7cf140>)
>      159:9  5 (_ _)
> In gnu/build/linux-modules.scm:
>     184:47  4 (recursive-module-dependencies _ #:lookup-module _)
>      98:14  3 (module-dependencies _)
>      85:18  2 (modinfo-section-contents _)
> In ice-9/ports.scm:
>     439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
> In unknown file:
>             0 (open-file #f "r" #:encoding #f #:guess-encoding #f)
>
> ERROR: In procedure open-file:
> Wrong type (expecting string): #f
> builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1

(I only know this because I had the same problem.) Obviously, this
error message should be changed.

As a workaround you could switch to the LTS kernel where that module
still exists.

--
Ricardo



[-- Attachment #1.2: Type: text/html, Size: 3496 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Deprecate-linux-module-shpchp-and-tell-user-to-r.patch --]
[-- Type: text/x-patch; name="0001-gnu-Deprecate-linux-module-shpchp-and-tell-user-to-r.patch", Size: 5108 bytes --]

From d67d90b9ab0aa6b7a9532ccb3788a34edde7bc52 Mon Sep 17 00:00:00 2001
From: swedebugia <swedebugia@riseup.net>
Date: Fri, 9 Nov 2018 22:52:12 +0100
Subject: [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove
 it.

 * gnu/build/linux-modules.scm (load-linux-module*): Add argument
 'remove-deprecated-modules'.
 * gnu/build/linux-modules.scm (load-dependencies): Add keyword
 '#:remove-deprecate-modules'.
 * gnu/system/mapped-devices.scm (check-device-initrd-modules): New if
 statement raising a condition if shpchp is found.
---
 gnu/build/linux-modules.scm   | 13 +++++++++++--
 gnu/system/mapped-devices.scm | 28 +++++++++++++++++++---------
 2 files changed, 30 insertions(+), 11 deletions(-)

diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 2d8117504..999ab4fc6 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -1,6 +1,8 @@
+
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2016, 2018 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2018 swedebugia <swedebugia@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -227,7 +229,13 @@ not a file name."
                              #:key
                              (recursive? #t)
                              (lookup-module dot-ko)
-                             (black-list (module-black-list)))
+                             (black-list (module-black-list))
+                             ;; Deprecate modules included in linux-libre but
+                             ;; which might still be present in the users
+                             ;; config.scm.
+                             ;; We tell the users to remove it from their
+                             ;; config.scm in gnu/system/mapped-devices.scm
+                             (remove-deprecated-modules 'shpchp))
   "Load Linux module from FILE, the name of a '.ko' file; return true on
 success, false otherwise.  When RECURSIVE? is true, load its dependencies
 first (à la 'modprobe'.)  The actual files containing modules depended on are
@@ -245,7 +253,8 @@ appears in BLACK-LIST are not loaded."
     (let ((dependencies (module-dependencies file)))
       (every (cut load-linux-module* <>
                   #:lookup-module lookup-module
-                  #:black-list black-list)
+                  #:black-list black-list
+                  #:remove-deprecate-modules remove-deprecate-modules)
              (map lookup-module dependencies))))
 
   (and (not (black-listed? (file-name->module-name file)))
diff --git a/gnu/system/mapped-devices.scm b/gnu/system/mapped-devices.scm
index a87466646..d30372c25 100644
--- a/gnu/system/mapped-devices.scm
+++ b/gnu/system/mapped-devices.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014, 2015, 2016, 2017, 2018 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2017, 2018 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2018 swedebugia <swedebugia@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -142,13 +143,22 @@ DEVICE must be a \"/dev\" file name."
         ;; "usb_storage"), not file names (e.g., "usb-storage.ko").  This is
         ;; OK because we have machinery that accepts both the hyphen and the
         ;; underscore version.
-        (raise (condition
-                (&message
-                 (message (format #f (G_ "you may need these modules \
+        (if (eqv (missing 'shpchp)
+                 ;; Tell user to remove shpchp from config.scm
+                 ;; True
+                 (raise (condition
+                         (&message
+                          (message (format #f (G_ "shpchp is no longer \
+needed because it has been included in linux-libre. Please remove it from \
+your config.scm to continue"))))))
+                 ;; Else
+                 (raise (condition
+                         (&message
+                          (message (format #f (G_ "you may need these modules \
 in the initrd for ~a:~{ ~a~}")
-                                  device missing)))
-                (&fix-hint
-                 (hint (format #f (G_ "Try adding them to the
+                                           device missing)))
+                         (&fix-hint
+                          (hint (format #f (G_ "Try adding them to the
 @code{initrd-modules} field of your @code{operating-system} declaration, along
 these lines:
 
@@ -161,9 +171,9 @@ these lines:
 
 If you think this diagnostic is inaccurate, use the @option{--skip-checks}
 option of @command{guix system}.\n")
-                               missing)))
-                (&error-location
-                 (location (source-properties->location location)))))))))
+                                        missing)))
+                         (&error-location
+                          (location (source-properties->location location)))))))))
 
 \f
 ;;;
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-09 22:47   ` [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it swedebugia
@ 2018-11-10 12:03     ` swedebugia
  2018-11-10 22:31       ` Ludovic Courtès
  0 siblings, 1 reply; 18+ messages in thread
From: swedebugia @ 2018-11-10 12:03 UTC (permalink / raw)
  To: 33329, rekado


[-- Attachment #1.1: Type: text/plain, Size: 1906 bytes --]

Hi

Updated patch attached with a fix of parens and removed my changes to 
linux-modules.scm.

I look forward to the review.

Cheers

On 2018-11-09 23:47, swedebugia wrote:
>
> Hi
>
> Ricardo, you mentioned that this needs to be fixed.
>
> I made a patch to fix this. I did not test the patch as I have no idea 
> how to do that.
>
> I have not run the indent script on it.
>
> Se attachment
>
>
> -------- Forwarded Message --------
> Subject: 	Re: GuixSD system reconfigure error
> Date: 	Thu, 30 Aug 2018 17:22:53 +0200
> From: 	Ricardo Wurmus <rekado@elephly.net>
> To: 	Hebi Li <lihebi.com@gmail.com>
> CC: 	help-guix@gnu.org
>
>
>
>
> Hi,
>
>>      https://github.com/lihebi/dothebi/blob/master/config.scm
>
> I see you use the “shpchp” kernel module. This no longer exists in the
> latest version of the kernel Linux. That’s what this really bad error
> message tries to tell you:
>
>> Backtrace:
>>             8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
>> In ice-9/eval.scm:
>>      619:8  7 (_ #f)
>>     626:19  6 (_ #<directory (guile-user) 7cf140>)
>>      159:9  5 (_ _)
>> In gnu/build/linux-modules.scm:
>>     184:47  4 (recursive-module-dependencies _ #:lookup-module _)
>>      98:14  3 (module-dependencies _)
>>      85:18  2 (modinfo-section-contents _)
>> In ice-9/ports.scm:
>>     439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
>> In unknown file:
>>             0 (open-file #f "r" #:encoding #f #:guess-encoding #f)
>>
>> ERROR: In procedure open-file:
>> Wrong type (expecting string): #f
>> builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1
>
> (I only know this because I had the same problem.) Obviously, this
> error message should be changed.
>
> As a workaround you could switch to the LTS kernel where that module
> still exists.
>
> --
> Ricardo
>
>
-- 
Cheers
Swedebugia


[-- Attachment #1.2: Type: text/html, Size: 4292 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-V2-gnu-Check-for-linux-module-shpchp-and-tell-user-t.patch --]
[-- Type: text/x-patch; name="0001-V2-gnu-Check-for-linux-module-shpchp-and-tell-user-t.patch", Size: 3062 bytes --]

From 4d70dda8c2f119fc6ff9d221eae6f060ff1fcd98 Mon Sep 17 00:00:00 2001
From: swedebugia <swedebugia@riseup.net>
Date: Fri, 9 Nov 2018 22:52:12 +0100
Subject: [PATCH] [V2] gnu: Check for linux-module shpchp and tell user to
 remove it.

 * gnu/system/mapped-devices.scm (check-device-initrd-modules): New if
 statement raising a condition if shpchp is found.
---
 gnu/packages/cran.go.3Q3wbP   |  0
 gnu/system/mapped-devices.scm | 28 +++++++++++++++++++---------
 2 files changed, 19 insertions(+), 9 deletions(-)
 create mode 100644 gnu/packages/cran.go.3Q3wbP

diff --git a/gnu/packages/cran.go.3Q3wbP b/gnu/packages/cran.go.3Q3wbP
new file mode 100644
index 000000000..e69de29bb
diff --git a/gnu/system/mapped-devices.scm b/gnu/system/mapped-devices.scm
index a87466646..483f952c6 100644
--- a/gnu/system/mapped-devices.scm
+++ b/gnu/system/mapped-devices.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014, 2015, 2016, 2017, 2018 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2017, 2018 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2018 swedebugia <swedebugia@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -142,13 +143,22 @@ DEVICE must be a \"/dev\" file name."
         ;; "usb_storage"), not file names (e.g., "usb-storage.ko").  This is
         ;; OK because we have machinery that accepts both the hyphen and the
         ;; underscore version.
-        (raise (condition
-                (&message
-                 (message (format #f (G_ "you may need these modules \
+        (if (eqv? (missing 'shpchp))
+                 ;; Tell user to remove shpchp from config.scm
+                 ;; True
+                 (raise (condition
+                         (&message
+                          (message (format #f (G_ "shpchp is no longer \
+needed because it has been included in linux-libre. Please remove it from \
+your config.scm to continue"))))))
+                 ;; Else
+                 (raise (condition
+                         (&message
+                          (message (format #f (G_ "you may need these modules \
 in the initrd for ~a:~{ ~a~}")
-                                  device missing)))
-                (&fix-hint
-                 (hint (format #f (G_ "Try adding them to the
+                                           device missing)))
+                         (&fix-hint
+                          (hint (format #f (G_ "Try adding them to the
 @code{initrd-modules} field of your @code{operating-system} declaration, along
 these lines:
 
@@ -161,9 +171,9 @@ these lines:
 
 If you think this diagnostic is inaccurate, use the @option{--skip-checks}
 option of @command{guix system}.\n")
-                               missing)))
-                (&error-location
-                 (location (source-properties->location location)))))))))
+                                        missing)))
+                         (&error-location
+                          (location (source-properties->location location))))))))))
 
 \f
 ;;;
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-10 12:03     ` swedebugia
@ 2018-11-10 22:31       ` Ludovic Courtès
  2018-11-11  0:15         ` Brett Gilio
  0 siblings, 1 reply; 18+ messages in thread
From: Ludovic Courtès @ 2018-11-10 22:31 UTC (permalink / raw)
  To: swedebugia; +Cc: rekado, 33329

Hello,

swedebugia <swedebugia@riseup.net> skribis:

> From 4d70dda8c2f119fc6ff9d221eae6f060ff1fcd98 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Fri, 9 Nov 2018 22:52:12 +0100
> Subject: [PATCH] [V2] gnu: Check for linux-module shpchp and tell user to
>  remove it.
>
>  * gnu/system/mapped-devices.scm (check-device-initrd-modules): New if
>  statement raising a condition if shpchp is found.

I don’t think we should hard-code things like this: they would
accumulate over the years and become unmanageable.

If anything, what should be improved IMO is the error message you get
when specifying a module that is unavailable.  That’s not easily done
though since that happens at build time.

Thoughts?

Ludo’.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-10 22:31       ` Ludovic Courtès
@ 2018-11-11  0:15         ` Brett Gilio
  2018-11-11  7:27           ` swedebugia
  2018-11-11 11:27           ` [bug#33329] " Ludovic Courtès
  0 siblings, 2 replies; 18+ messages in thread
From: Brett Gilio @ 2018-11-11  0:15 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: rekado, 33329


Ludovic Courtès writes:

> If anything, what should be improved IMO is the error message you get
> when specifying a module that is unavailable.  That’s not easily done
> though since that happens at build time.

I think Ludo is correct in this, an error message seems to be the only
option we have to ensure that maintainability and reproducibility are
respected. To add onto that, I was thinking that maybe it could be part
of the configuration process that we could modify to ensure that all of
the specified modules that are needed are available else it throws an
error?

Brett Gilio

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-11  0:15         ` Brett Gilio
@ 2018-11-11  7:27           ` swedebugia
  2018-11-11 11:32             ` Ludovic Courtès
  2018-11-11 11:27           ` [bug#33329] " Ludovic Courtès
  1 sibling, 1 reply; 18+ messages in thread
From: swedebugia @ 2018-11-11  7:27 UTC (permalink / raw)
  To: Brett Gilio, Ludovic Courtès; +Cc: rekado, 33329

On 2018-11-11 01:15, Brett Gilio wrote:
> 
> Ludovic Courtès writes:
> 
>> If anything, what should be improved IMO is the error message you get
>> when specifying a module that is unavailable.  That’s not easily done
>> though since that happens at build time.
> 
> I think Ludo is correct in this, an error message seems to be the only
> option we have to ensure that maintainability and reproducibility are
> respected. To add onto that, I was thinking that maybe it could be part
> of the configuration process that we could modify to ensure that all of
> the specified modules that are needed are available else it throws an
> error?

Ok. Would my patch have worked anyway?

So where would that error message be produced?
In gnu/build/linux-modules? load-linux-modules?

-- 
Cheers
Swedebugia

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-11  0:15         ` Brett Gilio
  2018-11-11  7:27           ` swedebugia
@ 2018-11-11 11:27           ` Ludovic Courtès
  1 sibling, 0 replies; 18+ messages in thread
From: Ludovic Courtès @ 2018-11-11 11:27 UTC (permalink / raw)
  To: Brett Gilio; +Cc: rekado, 33329

Brett Gilio <brettg@posteo.net> skribis:

> Ludovic Courtès writes:
>
>> If anything, what should be improved IMO is the error message you get
>> when specifying a module that is unavailable.  That’s not easily done
>> though since that happens at build time.
>
> I think Ludo is correct in this, an error message seems to be the only
> option we have to ensure that maintainability and reproducibility are
> respected. To add onto that, I was thinking that maybe it could be part
> of the configuration process that we could modify to ensure that all of
> the specified modules that are needed are available else it throws an
> error?

That already happens, but the check cannot be 100% accurate because it
relies on information from the currently running kernel, which is why
there’s the ‘--skip-checks’ option.

Ludo’.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-11  7:27           ` swedebugia
@ 2018-11-11 11:32             ` Ludovic Courtès
  2018-11-11 18:42               ` swedebugia
  0 siblings, 1 reply; 18+ messages in thread
From: Ludovic Courtès @ 2018-11-11 11:32 UTC (permalink / raw)
  To: swedebugia; +Cc: rekado, 33329

swedebugia <swedebugia@riseup.net> skribis:

> On 2018-11-11 01:15, Brett Gilio wrote:
>>
>> Ludovic Courtès writes:
>>
>>> If anything, what should be improved IMO is the error message you get
>>> when specifying a module that is unavailable.  That’s not easily done
>>> though since that happens at build time.
>>
>> I think Ludo is correct in this, an error message seems to be the only
>> option we have to ensure that maintainability and reproducibility are
>> respected. To add onto that, I was thinking that maybe it could be part
>> of the configuration process that we could modify to ensure that all of
>> the specified modules that are needed are available else it throws an
>> error?
>
> Ok. Would my patch have worked anyway?

I spotted a typo: (eqv? (missing 'shpchp)) is wrong because ‘eqv?’
should take two arguments and ‘missing’ is not a procedure.

Apart from this the patch could have worked I guess.

> So where would that error message be produced?
> In gnu/build/linux-modules? load-linux-modules?

An error message is produced while building the initrd; see commit
4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.

For now, what about closing this issue and opening a new one when we
have an idea on how to improve on this?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-11 11:32             ` Ludovic Courtès
@ 2018-11-11 18:42               ` swedebugia
  2018-11-12  8:42                 ` bug#33329: " Ludovic Courtès
  0 siblings, 1 reply; 18+ messages in thread
From: swedebugia @ 2018-11-11 18:42 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: rekado, 33329

On 2018-11-11 12:32, Ludovic Courtès wrote:
>> swedebugia <swedebugia@riseup.net> skribis:

snip

>> Ok. Would my patch have worked anyway?
> 
> I spotted a typo: (eqv? (missing 'shpchp)) is wrong because ‘eqv?’
> should take two arguments and ‘missing’ is not a procedure.

Ok. Thanks for taking your time.

> 
> Apart from this the patch could have worked I guess.
> 
>> So where would that error message be produced?
>> In gnu/build/linux-modules? load-linux-modules?
> 
> An error message is produced while building the initrd; see commit
> 4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.

Good, I had not seen that.

> 
> For now, what about closing this issue and opening a new one when we
> have an idea on how to improve on this?

Fine with me :)

-- 
Cheers
Swedebugia

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: GuixSD system reconfigure error
  2018-11-09 11:55 ` GuixSD system reconfigure error swedebugia
@ 2018-11-12  7:53   ` Hebi Li
  0 siblings, 0 replies; 18+ messages in thread
From: Hebi Li @ 2018-11-12  7:53 UTC (permalink / raw)
  To: swedebugia; +Cc: help-guix


Thanks for the help. I didn't research into it because it was not an
urgent need. I only have GuixSD installed on one machine.

> To my knowledge the simplest way, albeit not automatic, is to login as
> the user and install a manifest with
> $ guix package --manifest (see the manual for details)

Previously I was keeping the output of `guix package --list-installed`
under version control. Reading the document, looks like the manifest is
exactly what I was looking for. I'm going to use the manifest instead.

-- 
Hebi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* bug#33329: [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
  2018-11-11 18:42               ` swedebugia
@ 2018-11-12  8:42                 ` Ludovic Courtès
  0 siblings, 0 replies; 18+ messages in thread
From: Ludovic Courtès @ 2018-11-12  8:42 UTC (permalink / raw)
  To: swedebugia; +Cc: rekado, 33329-done

swedebugia <swedebugia@riseup.net> skribis:

> On 2018-11-11 12:32, Ludovic Courtès wrote:

[...]

>>> So where would that error message be produced?
>>> In gnu/build/linux-modules? load-linux-modules?
>>
>> An error message is produced while building the initrd; see commit
>> 4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.
>
> Good, I had not seen that.
>
>>
>> For now, what about closing this issue and opening a new one when we
>> have an idea on how to improve on this?
>
> Fine with me :)

Alright, done!

Ludo’.

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2018-11-12  8:54 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 21:20 GuixSD system reconfigure error Hebi Li
2018-08-30 10:28 ` Pierre Neidhardt
2018-08-30 11:05   ` Tobias Geerinckx-Rice
2018-08-30 15:22 ` Ricardo Wurmus
2018-08-30 19:51   ` Hebi Li
2018-08-30 20:54     ` Ricardo Wurmus
2018-08-30 22:48       ` Hebi Li
2018-11-09 22:47   ` [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it swedebugia
2018-11-10 12:03     ` swedebugia
2018-11-10 22:31       ` Ludovic Courtès
2018-11-11  0:15         ` Brett Gilio
2018-11-11  7:27           ` swedebugia
2018-11-11 11:32             ` Ludovic Courtès
2018-11-11 18:42               ` swedebugia
2018-11-12  8:42                 ` bug#33329: " Ludovic Courtès
2018-11-11 11:27           ` [bug#33329] " Ludovic Courtès
2018-11-09 11:55 ` GuixSD system reconfigure error swedebugia
2018-11-12  7:53   ` Hebi Li

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.