all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Adam Faiz <adam.faiz@disroot.org>
Cc: 60153@debbugs.gnu.org
Subject: [bug#60153] Fwd: [PATCH] gnu: python-pygame: Update to 2.1.2.
Date: Sat, 17 Dec 2022 11:52:27 +0100	[thread overview]
Message-ID: <da9162387ef2b7c5bd921c30ff422bcaa2c784ba.camel@gmail.com> (raw)
In-Reply-To: <93aa8b09-cc29-4030-3c76-458158ea0c0f@disroot.org>

Am Samstag, dem 17.12.2022 um 18:06 +0800 schrieb Adam Faiz:
> * gnu/packages/game-development.scm (python-pygame): Update to 2.1.2.
Since this is a major bump, did you check whether dependant packages
still build?
> [inputs]: Use the new style.
I'd split the style adjustments into a separate commit.  Also note,
that #:phases needs similar treatment w.r.t. using the newer API.
> [description]: Re-indent.
IMHO that one's noise generated by guix style.
> ---
>   gnu/packages/game-development.scm | 119 +++++++++++++--------------
> ---
>   1 file changed, 51 insertions(+), 68 deletions(-)
> 
> diff --git a/gnu/packages/game-development.scm 
> b/gnu/packages/game-development.scm
> index 4a0435045b..c3d8d9a8a9 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -1194,92 +1194,75 @@ (define-public quesoglc
>   (define-public python-pygame
>     (package
>       (name "python-pygame")
> -    (version "1.9.4")
> +    (version "2.1.2")
>       (source (origin
>                 (method url-fetch)
>                 (uri (pypi-uri "pygame" version))
>                 (sha256
>                  (base32
> -               
> "1dn0nb86jl7yr8709cncxdr0yrmviqakw7zx3g8jbbwrr60if3bh"))))
> +               
> "0g6j79naab7583kymf1bgxc5l5c9h5laq887rmvh8vw8iyifrl6n"))
> +              (modules '((guix build utils)))
> +              ;; Fix the configure script to allow passing the 
> dependencies as
> +              ;; environment variables.
> +              (snippet
> +               #~(begin
> +                   (substitute* "buildconfig/config_unix.py"
> +                     (("localbase.d") "d")
> +                     (("origincdirs = .*/include.*")
> +                      "origincdirs = 
> os.environ['ORIGINCDIRS'].split(\":\")\n"))))))
Can't we make it so that the normal GCC search paths suffice?
Also note the value of fill-column at 80 (or 79?).


Cheers

  parent reply	other threads:[~2022-12-17 10:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 10:01 [bug#60153] [PATCH] gnu: python-pygame: Update to 2.1.2 Adam Faiz via Guix-patches via
     [not found] ` <93aa8b09-cc29-4030-3c76-458158ea0c0f@disroot.org>
2022-12-17 10:52   ` Liliana Marie Prikler [this message]
2022-12-18 14:15     ` [bug#60153] Fwd: " Adam Faiz via Guix-patches via
2022-12-18 15:02       ` Liliana Marie Prikler
2022-12-18 15:51 ` [bug#60153] [PATCH v2 1/3] " Adam Faiz
2022-12-23 23:20   ` Adam Faiz via Guix-patches via
2022-12-23 23:43     ` Adam Faiz via Guix-patches via
2022-12-23 23:54       ` Adam Faiz via Guix-patches via
2022-12-24  5:51       ` Liliana Marie Prikler
2022-12-24 13:19         ` Adam Faiz via Guix-patches via
2022-12-24  5:39     ` Liliana Marie Prikler
2022-12-18 15:51 ` [bug#60153] [PATCH v1 " Adam Faiz via Guix-patches via
2022-12-18 15:54   ` [bug#60153] [PATCH v1 2/3] gnu: python-pygame: Use gexps and new style inputs Adam Faiz via Guix-patches via
2022-12-18 15:57     ` [bug#60153] [PATCH v1 3/3] gnu: python-pygame: Fix description Adam Faiz via Guix-patches via
2022-12-18 15:54 ` [bug#60153] [PATCH v2 2/3] gnu: python-pygame: Use G-Expressions and new-style inputs Adam Faiz
2022-12-22 20:45 ` [bug#60153] [PATCH v2 3/3] gnu: python-pygame: Reword description Liliana Marie Prikler
2022-12-22 21:09 ` [bug#60153] [PATCH v2 0/3] Update python-pygame to 2.1.2 Liliana Marie Prikler
2022-12-31  7:34   ` bug#60153: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da9162387ef2b7c5bd921c30ff422bcaa2c784ba.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=60153@debbugs.gnu.org \
    --cc=adam.faiz@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.