[bug#74305] [PATCH 0/2] Improve piem package

[bug#74305] [PATCH 0/2] Improve piem package

[Liam Hupfer]

Hi all, new contributor here. Please let me know if there are any issues
with commit message conventions or mail etiquette.

Liam Hupfer (2):
  gnu: emacs-piem: Build Info manual
  gnu: emacs-piem: Canonicalize home-page URL

 gnu/packages/emacs-xyz.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


base-commit: 9cdcfb52ace77fe3b497b21deb639a3027ff02f0
-- 
2.46.0

[bug#74305] [PATCH 1/2] gnu: emacs-piem: Build Info manual

[Liam Hupfer]

* gnu/packages/emacs-xyz (emacs-piem): Build Info manual

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
 gnu/packages/emacs-xyz.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..7772a80192 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9785,7 +9785,13 @@ (define-public emacs-piem
                  (lambda* (#:key inputs #:allow-other-keys)
                    (emacs-substitute-variables "piem-b4.el"
                      ("piem-b4-b4-executable"
-                      (search-input-file inputs "/bin/b4"))))))))
+                      (search-input-file inputs "/bin/b4")))))
+               (add-after 'install 'makeinfo
+                 (lambda _
+                   (invoke "makeinfo" "Documentation/piem.texi")
+                   (install-file "piem.info"
+                                 (string-append #$output "/share/info")))))))
+    (native-inputs (list texinfo))
     (inputs
      (list b4
            emacs-debbugs
-- 
2.46.0

[bug#74305] [PATCH 0/2] Improve piem package

[Noé Lopez via Guix-patches via]

Hi,

Thanks for your patch,

Everything is great, you just forgot a dot at the end of your commit
messages and description :P You can check the git log for examples.

Can you send an updated patch?

Have a good day,
Noé Lopez


> * gnu/packages/emacs-xyz (emacs-piem): Build Info manual
> 
> Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 88e1ab89a9..7772a80192 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9785,7 +9785,13 @@ (define-public emacs-piem
>                   (lambda* (#:key inputs #:allow-other-keys)
>                     (emacs-substitute-variables "piem-b4.el"
>                       ("piem-b4-b4-executable"
> -                      (search-input-file inputs "/bin/b4"))))))))
> +                      (search-input-file inputs "/bin/b4")))))
> +               (add-after 'install 'makeinfo
> +                 (lambda _
> +                   (invoke "makeinfo" "Documentation/piem.texi")
> +                   (install-file "piem.info"
> +                                 (string-append #$output "/share/info")))))))
> +    (native-inputs (list texinfo))
>      (inputs
>       (list b4
>             emacs-debbugs
> -- 
> 2.46.0

[bug#74305] [PATCH 2/2] gnu: emacs-piem: Canonicalize home-page URL

[Liam Hupfer]

guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7772a80192..ddd691faa3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9797,7 +9797,7 @@ (define-public emacs-piem
            emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
-    (home-page "https://docs.kyleam.com/piem")
+    (home-page "https://docs.kyleam.com/piem/")
     (synopsis "Glue for working with public-inbox archives")
     (description "This package provides a collection of Emacs libraries for
 working with public-inbox archives.  As much of the hard work here is already
-- 
2.46.0

[bug#74305] [PATCH v2 0/2] Improve piem package

[Liam Hupfer]

Thanks Noé, I fixed the commit message punctuation and added a copyright
notice now.

Liam Hupfer (2):
  gnu: emacs-piem: Build Info manual.
  gnu: emacs-piem: Canonicalize home-page URL.

 gnu/packages/emacs-xyz.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: 1592f1ac3b39ba7217d3e0d43f589ead8818c449
-- 
2.46.0

[bug#74305] [PATCH v2 1/2] gnu: emacs-piem: Build Info manual.

[Liam Hupfer]

* gnu/packages/emacs-xyz (emacs-piem): Build Info manual.

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
 gnu/packages/emacs-xyz.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b3517b7bd9..39f43824b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -147,6 +147,7 @@
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom@gmail.com>
 ;;; Copyright © 2024 Spencer King <spencer.king@nursiapress.com>
 ;;; Copyright © 2024 emma thompson <bigbookofbug@proton.me>
+;;; Copyright © 2024 Liam Hupfer <liam@hpfr.net>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -9785,7 +9786,13 @@ (define-public emacs-piem
                  (lambda* (#:key inputs #:allow-other-keys)
                    (emacs-substitute-variables "piem-b4.el"
                      ("piem-b4-b4-executable"
-                      (search-input-file inputs "/bin/b4"))))))))
+                      (search-input-file inputs "/bin/b4")))))
+               (add-after 'install 'makeinfo
+                 (lambda _
+                   (invoke "makeinfo" "Documentation/piem.texi")
+                   (install-file "piem.info"
+                                 (string-append #$output "/share/info")))))))
+    (native-inputs (list texinfo))
     (inputs
      (list b4
            emacs-debbugs
-- 
2.46.0

[bug#74305] [PATCH v2 2/2] gnu: emacs-piem: Canonicalize home-page URL.

[Liam Hupfer]

guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 39f43824b8..850c22863b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9798,7 +9798,7 @@ (define-public emacs-piem
            emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
-    (home-page "https://docs.kyleam.com/piem")
+    (home-page "https://docs.kyleam.com/piem/")
     (synopsis "Glue for working with public-inbox archives")
     (description "This package provides a collection of Emacs libraries for
 working with public-inbox archives.  As much of the hard work here is already
-- 
2.46.0