From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MKDLGDcrjV8FaQAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 05:59:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8FWCFDcrjV8VUAAAbx9fmQ (envelope-from ) for ; Mon, 19 Oct 2020 05:59:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 253CD9402A6 for ; Mon, 19 Oct 2020 05:59:18 +0000 (UTC) Received: from localhost ([::1]:39466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUOCR-0003ox-Kz for larch@yhetil.org; Mon, 19 Oct 2020 01:59:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUOCD-0003nF-UA for bug-guix@gnu.org; Mon, 19 Oct 2020 01:59:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUOCD-0001s7-Ib for bug-guix@gnu.org; Mon, 19 Oct 2020 01:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUOCD-0007iF-HV for bug-guix@gnu.org; Mon, 19 Oct 2020 01:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 19 Oct 2020 05:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe , Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160308708729580 (code B ref 44027); Mon, 19 Oct 2020 05:59:01 +0000 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 05:58:07 +0000 Received: from localhost ([127.0.0.1]:39618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUOBL-0007h1-D6 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 01:58:07 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:30264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUOBJ-0007gW-2I for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 01:58:05 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4CF5dg010XzQlBM; Mon, 19 Oct 2020 07:57:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1603087077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69XAYxC+DhViaOqCLFtTcoZUdGEsbaFs1qspj0Be5Qs=; b=1t1JNeQYCcqvW03lUsRXeUrDcLGziZLwKmAfGfKUF1pS20NmXylQELxqdAKh3rrHYaetO8 vpZ3Hem9q1H6WBmIWaapzAhocxfKDpH3rgWiNZZlIrki9H0vo2u82iGzoUORTUiR+SqBl5 RK2GLPviqfyhLaaJCt1MEiFlNiXcImZHDwEdJqmQjhmHimhAXVqXvNNRL84tul4mP7/n/4 g9uqjx65RFblCD497g2RaensilLSW1Tr7QOlgRZtQwZCcARpBlqo6fz4sqBv5+T8pQ84jJ Er/Ao6pUkuHI61wkK1xB/MtyKpDGDw07uysnzkAUT88YQt4YyTPcrJ8U0oJpCQ== Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id U3JAJwipljPx; Mon, 19 Oct 2020 07:57:55 +0200 (CEST) References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> From: Brendan Tildesley Message-ID: Date: Mon, 19 Oct 2020 16:57:49 +1100 MIME-Version: 1.0 In-Reply-To: <87imb7zctc.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -3.81 / 15.00 / 15.00 X-Rspamd-Queue-Id: DF30117EA X-Rspamd-UID: 330e5c X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44027@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=brendan.scot header.s=MBO0001 header.b=1t1JNeQY; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: 7Y5mA0u4PhBz On 19/10/20 3:03 am, Mathieu Othacehe wrote: > Hello Miguel & Brendan, > >> AFAIU from the code, the first partition should not be created by the >> installer but it won't be removed if it was found on the disk >> beforehand. Tomorrow I'll give a try at the full installation process, >> I must have overlooked something if it still being created in that >> case... > Thanks for your help on this topic! Brendan is probably using a GPT > partitionned disk on a non-UEFI compatible machine. Hence, as you > noticed, the installer does not create a bios_grub partition. > > This is a problem as this partition is necessary for GRUB and I think > that your patch is fixing the problem. The "auto-partition!" procedure > is also leaving a probably pre-existing ESP partition, but I don't > really understand how it appeared in the first place. > > Brendan, did you use "manual partitioning" to create an ESP partition? Hmm I forget what was on this drive. I used to have Windows 10 on it, then I can't remember. I may have installed Arch Linux on it. What ever was on it, I just ran the installer letting it do it's thing selecting Encrypted root with LVM because I wanted to see if that worked. it didn't, then I tried the default, before posting the bug report. Finally I went though with Miguel's patch selecting all the defaults and that was the result. I feel the installer should not care what was on the drive to begin with, it should just format the drive how it sees fit. Why should the existing contents of the drive affect the outcome when we are reformatting everything anyway? > > Thanks, > > Mathieu