all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages.
@ 2024-07-20 11:09 Vinicius Monego
  2024-09-05  6:43 ` Ludovic Courtès
  2024-09-05  6:43 ` Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: Vinicius Monego @ 2024-07-20 11:09 UTC (permalink / raw)
  To: 72206; +Cc: Vinicius Monego

* guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
python-pyflakes, python-pylint, python-pytest-cov, python-yapf.

Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
---
There are several flake8 extensions too which could be added.

 guix/lint.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index 7612832a5a..49e9b73676 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -586,9 +586,18 @@ (define (check-inputs-should-be-native package)
 (define (check-inputs-should-not-be-an-input-at-all package)
   ;; Emit a warning if some inputs of PACKAGE are likely to should not be
   ;; an input at all.
-  (let ((input-names '("python-setuptools"
+  (let ((input-names '("python-black"
+                       "python-coverage"
+                       "python-flake8"
+                       "python-mypy"
                        "python-pip"
-                       "python-pre-commit")))
+                       "python-pre-commit"
+                       "python-pycodestyle"
+                       "python-pyflakes"
+                       "python-pylint"
+                       "python-pytest-cov"
+                       "python-setuptools"
+                       "python-yapf")))
     (map (lambda (input)
            (make-warning
             package

base-commit: 9df5289c6687cd5688c275d16417389fbab6d384
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages.
  2024-07-20 11:09 [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages Vinicius Monego
@ 2024-09-05  6:43 ` Ludovic Courtès
  2024-09-05  6:43 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2024-09-05  6:43 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 72206

Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but I this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages.
  2024-07-20 11:09 [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages Vinicius Monego
  2024-09-05  6:43 ` Ludovic Courtès
@ 2024-09-05  6:43 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2024-09-05  6:43 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 72206

Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

> * guix.lint.scm (check-inputs-should-not-be-an-input-at-all): Add
> python-black, python-coverage, python-flake8, python-mypy, python-pycodestyle,
> python-pyflakes, python-pylint, python-pytest-cov, python-yapf.
>
> Change-Id: I4e7071f21b84313a117c4487d5977adbb91efe92
> ---
> There are several flake8 extensions too which could be added.

I’m not a Python person but this looks reasonable to me.  I think you
can go ahead and push.

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-05  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-20 11:09 [bug#72206] [PATCH] lint: check-inputs-should-not-be-an-input-at-all: Add more packages Vinicius Monego
2024-09-05  6:43 ` Ludovic Courtès
2024-09-05  6:43 ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.