From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Charles <Charles.b.jackson@proton.me>, 58620@debbugs.gnu.org
Subject: [bug#58620] Update blur my shell
Date: Thu, 20 Oct 2022 15:01:00 +0200 [thread overview]
Message-ID: <d92a4c07aec043f7fef4af1cd3301d23cfc784b9.camel@ist.tugraz.at> (raw)
In-Reply-To: <2mjT77G4wrrOWhYBkiBVH1zVeRlE9KRuQTFzbT2F9essoggB089RP0JjKU9srju0FpoQyexx9DI-s5eXWMKNiVY6nKGL01rmlB18SbRFf-I=@proton.me>
Am Mittwoch, dem 19.10.2022 um 04:25 +0000 schrieb Charles:
> [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
> 44.
Should be: "gnu: update gnome-shell-extension-blur-my-shell to 44".
>
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell)
> Update version and hash. Add a phase to move the contents of the src
> and resources directories to project root so they get installed
> properly.
Break lines between changes and make clear what's changed. Use
indicators such as [#:phases].
> ---
> gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index 68166978a1..89bb9c9d7b 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-
> windows
> (define-public gnome-shell-extension-blur-my-shell
> (package
> (name "gnome-shell-extension-blur-my-shell")
> - (version "29")
> + (version "44")
> (source
> (origin
> (method git-fetch)
> @@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-
> shell
> (file-name (git-file-name name version))
> (sha256
> (base32
> - "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
> - (snippet
> - '(begin (delete-file "src/schemas/gschemas.compiled")))))
> + "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
Why is the snippet removed?
> (build-system copy-build-system)
> (arguments
> `(#:install-plan
> @@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-
> shell
> "share/gnome-shell/extensions/"
> "blur-my-shell@aunetx")
> #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> "\\.png$"
> - "\\.xml$" "\\.compiled$")))
> + "\\.svg$" "\\.xml$" "\\.compiled$")))
Note the addition of "\\.svg$" in the ChangeLog.
> #:phases
> (modify-phases %standard-phases
> - (add-after 'unpack 'cd-src
> - (lambda _ (chdir "src")))
> - (add-before 'install 'compile-schemas
> + (add-after 'unpack 'compile-schemas
> (lambda _
> (with-directory-excursion "schemas"
> - (invoke "glib-compile-schemas" ".")))))))
> + (invoke "glib-compile-schemas" "."))))
> + (add-before 'install 'unpack-src
> + (lambda _
> + (use-modules (ice-9 ftw))
> + (define (explode-dir dir)
> + (for-each
> + (lambda (file)
> + (let ((full-file-name
> + (string-append (getcwd) "/" dir "/" file)))
> + (rename-file
> + full-file-name
> + (string-append (getcwd) "/" file))))
> + (filter (lambda (file)
> + (not (or (string=? file ".")
> + (string=? file ".."))))
> + (scandir (string-append (getcwd) "/"
> dir)))))
> + (explode-dir "src")
> + (explode-dir "resources"))))))
Adjust #:install-plan instead.
> (native-inputs
> (list (list glib "bin"))) ; for glib-compile-schemas
> (home-page "https://github.com/aunetx/blur-my-shell")
> --
Cheers
next prev parent reply other threads:[~2022-10-20 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 4:25 [bug#58620] Update blur my shell Charles via Guix-patches via
2022-10-20 13:01 ` Liliana Marie Prikler [this message]
2022-10-22 4:33 ` Charles via Guix-patches via
2022-10-22 9:07 ` bug#58620: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92a4c07aec043f7fef4af1cd3301d23cfc784b9.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=58620@debbugs.gnu.org \
--cc=Charles.b.jackson@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.