From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SDpqHR4uAmRIgQEAbAwnHQ (envelope-from ) for ; Fri, 03 Mar 2023 18:27:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KIx5HR4uAmQ9GAEA9RJhRA (envelope-from ) for ; Fri, 03 Mar 2023 18:27:58 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 269883ABC3 for ; Fri, 3 Mar 2023 18:27:58 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pY9Bh-0000kv-1T; Fri, 03 Mar 2023 12:27:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY9BQ-0000Sv-BR for guix-patches@gnu.org; Fri, 03 Mar 2023 12:27:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pY9BO-0006VX-Vb for guix-patches@gnu.org; Fri, 03 Mar 2023 12:27:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pY9BO-0000dY-Jn for guix-patches@gnu.org; Fri, 03 Mar 2023 12:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61587] [PATCH 0/8] networking services refactoring Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Mar 2023 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61587@debbugs.gnu.org Received: via spool by 61587-submit@debbugs.gnu.org id=B61587.16778644162429 (code B ref 61587); Fri, 03 Mar 2023 17:27:02 +0000 Received: (at 61587) by debbugs.gnu.org; 3 Mar 2023 17:26:56 +0000 Received: from localhost ([127.0.0.1]:33881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9BH-0000d6-LN for submit@debbugs.gnu.org; Fri, 03 Mar 2023 12:26:55 -0500 Received: from smtpm3.myservices.hosting ([185.26.105.234]:41086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9BF-0000cy-Nf for 61587@debbugs.gnu.org; Fri, 03 Mar 2023 12:26:55 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 4BAC620FDA; Fri, 3 Mar 2023 18:26:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id E68848009A; Fri, 3 Mar 2023 18:26:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zh2OmArbAb33; Fri, 3 Mar 2023 18:26:51 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 8249280098; Fri, 3 Mar 2023 18:26:51 +0100 (CET) Message-ID: Date: Fri, 3 Mar 2023 17:26:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <502d6efbde6d7e372ab6bc414fbbe2c065c23b4e.1676667941.git.mirai@makinata.eu> <87sfelu5a2.fsf_-_@gnu.org> From: Bruno Victal In-Reply-To: <87sfelu5a2.fsf_-_@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677864478; a=rsa-sha256; cv=none; b=b4TM9/jtq1Vjxxrd27EZ5P9LRHohfQMSkFOCRBkE+pKsVvqVdF//NcK+6Xnu3tfzG3sjEb eiLynhV0CQfdMiTkiAwa/yFvpMT+2x5VmpS8WUlhasUt5TmpiafGbpuTxhhtcT5NeNj2f7 Qvk61TOWquBAYoLPmqcxIlsco6pGQHv0LlWrLqbImv6uql9LBPblW0BINUM8JisLzhtAme ebCvIg+IH0sJXCP9KFp7xYkfvS0HdSmmXZWwlcAg4XO3b9vi2XSMttbwjKnbdnsoiiHQYA /InwTdTeR2aNpXNeHbsGTM0W9rCCreFi+v5z3EPXZjGvtETSCVow/Lgs4syTfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677864478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GuOqZLCk9Ux6TYiMdFk2/ZV9vLO7W/iWsPvg0wpQcgM=; b=cYkcuw2H0b4matuOJlELg1AHsGIZLN8FjANdVdqp973tdOFwHyJvcdI+Ho2a10etPHCAdy bPtrdpIzG68H6rDR+U/AGJSIv0mW7kO+YfIMvomEH/Kd+ahIM0EY9oO0ZPzZUSHyyge1cF 75b9ylmGHEiPcWIogy+vyaFEViJZ2UcpN3qSPUGv7zvdYHUk8DDazl6ZpMV/bu+1JMqYDs NPuLcGnOA3aeSz9YHlWx/sLg7Rb09Ub7cchpl/Q5SaS0bgNDdPDVFV+rIA6rayqEPYLYzf d+vSjOVLzMzZxgrdKOPg1NFgSarjaOfUKkg0k/JLQpEGkat2z2zzWPDAKdJKog== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.70 X-Spam-Score: -1.70 X-Migadu-Queue-Id: 269883ABC3 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: 5A2QnTBunfDh On 2023-03-03 17:13, Ludovic Courtès wrote:> Bruno Victal skribis: > >> Supersedes #47253. (Note: Shepherd no longer blocks since shepherd 0.9.3) > > What does that mean? Oops, I didn't intend to include this in the commit message, it was for the mail body. At the time I didn't notice that #47253 already had a patch to solve this issue which resulted in independent rewrite of the same fix. I only noticed it while I was searching for open issues to attach to the message as potential issues that would be closed by this. The note refers to what made #47253 untenable back then. >> * gnu/services/networking.scm (network-manager-shepherd-service): Await for >> NetworkManager to finish starting up. > > [...] > >> + (start >> + #~(lambda args >> + (let ((constructor >> + (apply >> + (make-forkexec-constructor >> + (list #$(file-append network-manager >> + "/sbin/NetworkManager") >> + (string-append "--config=" #$conf) >> + "--no-daemon") > > Rather: > > (let ((pid (fork+exec-command (list …)))) > … > pid) I'll send a v2 with the required touch-ups. Cheers, Bruno