all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: jbranso@dismail.de
To: "Feng Shu" <tumashu@163.com>, guix-devel@gnu.org
Subject: Re: lightdm updates need to review.
Date: Wed, 08 Jan 2025 13:44:32 +0000	[thread overview]
Message-ID: <d691a8c641ad61c35ab22224231d8cac9d62bf06@dismail.de> (raw)
In-Reply-To: <87plkygk2m.fsf@163.com>

Thanks for the submission Feng!

Just a couple of things:

1) Try to send your email as plaintext, not html.  Most developers prefer 
plaintext emails.  :)

2)  I would encourage you to read this webpage: 
    https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

   Essentially you should submit patches with "git send-email"
   ( https://git-send-email.io/ ), and you should submit patches to:
   guix-patches@gnu.org .  Guix devel does not create an bug report.
   BUT guix-patches@gnu.org will create a correspending bug report at
   issues.guix.gnu.org.

Thanks again for helping guix!


Joshua
A very helpful elf


January 7, 2025 at 8:39 PM, "Feng Shu" <tumashu@163.com mailto:tumashu@163.com?to=%22Feng%20Shu%22%20%3Ctumashu%40163.com%3E > wrote:



> 
> Hello everyone.
> 
> I have try many display-manager in guix: gdm, sddm, slim and lightdm,
> and finally find lightdm is very comfortable to use after it fix session
> menu dispear problem in gux:
> 
> 1. it start very fast.
> 2. lightdm-gtk-greeter can change font, background easy.
> 3. it can support other greeters.
> 
> I have send the below patches, please review them if someone have time,
> thanks,
> 
> 1. Add lightdm-greeter-general-configuration and simplify code
> 
>  https://issues.guix.gnu.org/75048
> 
> with this configuration, user can use other greeter, for example:
> slick-greeter, lightdm-mini-greeter, lightdm-tiny-greeter or
> lightdm-pantheon-greeter easily.
> 
> 2. Add slick-greeter
> 
>  https://issues.guix.gnu.org/75043
> 
> 3. Add lightdm-tiny-greeter
> 
>  https://issues.guix.gnu.org/75417
> 
> 4. Add lightdm-pantheon-greeter 
> 
>  https://issues.guix.gnu.org/75186
> 
> For I use xfce4, so I just package some greeter using gtk, and do not
> package greeter using qt, if someone interesting, can try :-)
> 
> the below is lightdm configuration to test:
> 
> ```
> (service lightdm-service-type
>  (lightdm-configuration
>  (greeters
>  (list (lightdm-greeter-general-configuration
>  (greeter-package slick-greeter)
>  (greeter-session-name "slick-greeter")
>  (greeter-config-name "slick-greeter.conf")
>  (config (list "[Greeter]"
>  "font-name = San 12"
>  "background = /run/current-system/profile/share/backgrounds/guix/guix-checkered-16-9.svg")))
>  (lightdm-greeter-general-configuration
>  (greeter-package lightdm-mini-greeter)
>  (greeter-session-name "lightdm-mini-greeter")
>  (greeter-config-name "lightdm-mini-greeter.conf")
>  (config (list "[greeter]"
>  "user = guest"
>  "[greeter-hotkeys]"
>  "mod-key = control"
>  "session-key = e")))
>  (lightdm-greeter-general-configuration
>  (greeter-package (customize-lightdm-tiny-greeter #:session "icewm"))
>  (greeter-session-name "lightdm-tiny-greeter")
>  (greeter-config-name "lightdm-tiny-greeter.conf")
>  (config (list "## Lightdm-mini-greeter have no config, ignore it!")))
>  (lightdm-greeter-general-configuration)
>  (lightdm-gtk-greeter-configuration
>  (lightdm-gtk-greeter lightdm-gtk-greeter-gee)
>  (extra-config
>  (list "font-name = San 10"
>  "icon-size = 64"
>  "xft-dpi = 140"
>  "clock-format = %Y-%m-%d %H:%M"
>  ;; We need to use "~~" to generate a tilde, for
>  ;; extra-config sting will be handle as
>  ;; control-string of format function.
>  "indicators = ~~host;~~spacer;~~session;~~a11y;~~clock;~~power")))))
>  (seats
>  (list (lightdm-seat-configuration
>  (name "*")
>  (greeter-session 'lightdm-tiny-greeter))))
> 
>  (xorg-configuration
>  (xorg-configuration
>  ;; The QXL virtual GPU driver is added to provide a better
>  ;; SPICE experience.
>  (modules (cons xf86-video-qxl
>  %default-xorg-modules))
>  (keyboard-layout keyboard-layout)
>  (server-arguments
>  (append %default-xorg-server-arguments
>  '("-dpi" "140")))))))
> 
> ```
> 
> --
>


  reply	other threads:[~2025-01-08 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  1:39 lightdm updates need to review Feng Shu
2025-01-08 13:44 ` jbranso [this message]
2025-01-08 22:00   ` Feng Shu
2025-01-09 13:33     ` jbranso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d691a8c641ad61c35ab22224231d8cac9d62bf06@dismail.de \
    --to=jbranso@dismail.de \
    --cc=guix-devel@gnu.org \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.