From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GLc9AjY8k2NEpgAAbAwnHQ (envelope-from ) for ; Fri, 09 Dec 2022 14:46:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0KpBAjY8k2PWDgAA9RJhRA (envelope-from ) for ; Fri, 09 Dec 2022 14:46:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B3B7B537 for ; Fri, 9 Dec 2022 14:46:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3dhW-00063S-WB; Fri, 09 Dec 2022 08:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3dhT-00061o-D1 for guix-patches@gnu.org; Fri, 09 Dec 2022 08:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3dhT-0002Tz-3x for guix-patches@gnu.org; Fri, 09 Dec 2022 08:46:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3dhS-00025y-VW for guix-patches@gnu.org; Fri, 09 Dec 2022 08:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59866] [PATCH 0/2] services: mpd: Refactor MPD service Resent-From: mirai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Dec 2022 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 59866@debbugs.gnu.org Cc: 54986@debbugs.gnu.org Received: via spool by 59866-submit@debbugs.gnu.org id=B59866.16705935067966 (code B ref 59866); Fri, 09 Dec 2022 13:46:02 +0000 Received: (at 59866) by debbugs.gnu.org; 9 Dec 2022 13:45:06 +0000 Received: from localhost ([127.0.0.1]:36197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3dgX-00024L-KZ for submit@debbugs.gnu.org; Fri, 09 Dec 2022 08:45:05 -0500 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]:50898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3dgV-00023u-DU; Fri, 09 Dec 2022 08:45:03 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id E947520BE5; Fri, 9 Dec 2022 14:45:00 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 865A080098; Fri, 9 Dec 2022 14:45:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qmuGHNF6oe9n; Fri, 9 Dec 2022 14:45:00 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id DD71480093; Fri, 9 Dec 2022 14:44:59 +0100 (CET) Message-ID: Date: Fri, 9 Dec 2022 13:44:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US References: <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@gmail.com> <71f31a0d-cc58-a0e6-4aa4-b5c46513c835@makinata.eu> From: mirai In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670593589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=DpAAoZUnJ3MAGELwF66TaeAncfHQT12rF/rtxx+F03I=; b=JB3twgz6xywJpscq+KUHA2nynM0vrqZW/zq/y6QoAMMdd+TAmRf4A9QRdLEA4UlPpwdhmW uO9y91uecwEl49z3+panGb44FO07AnADebcwQIEfta7LqFOrr0GAsPrIdfEQDb06mBRBZL 7AA33JWLFeMQYNAS7n6HC/rP6B3HdvHvh1t9kxYlhZ3crTq+BPUZ8j91qUengCgdYWesH8 eqKRW7mAYHWwTx72EZMFIBM3glYUXY8pQsosaWT3DELsigwkPhs8169pdZK8jxgo5RS3DN 7c4x/qn/rgPlxXRxufDY7Gr8PeCB55kOCRgPfpw6NCBLDihM2ac/gaeBGU27Aw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670593589; a=rsa-sha256; cv=none; b=KqsXMxIgsZObk9BGuiISZRBuZTvfjqd5VIUgYedHPJc2sNC/YJKPyGRsy2iSi56UYQVbkV UKjrMFIvSxROsWSSnSOaXl8N6WgH9Xqbs87XfYp0JO3tKQZFxHCezPly81TvKEdP0luzDy wKZCrwBtiwy7h4uaNGjhDQAAkB79bKCGDZMpJocjnlmDscKRUGGEeDNNMDMmerKK0u/sR/ 5ekAyeh1k29vY1xQIJ6GubupWyS/N2m4p86edHp4Wbrajxe4KzJEK+2MUj8G3cpNPhdERY 3GlylHsUCkb543z+F6kXj2hjapV5De2NInfMMMt9H3t+vDyIqwUsVBpttPecEw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3B3B7B537 X-Spam-Score: -2.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: gzf9W2MlaNVP On 2022-12-08 13:35, Liliana Marie Prikler wrote: > This doesn't work for #54986, which makes it so that in-file addresses > are ignored in favour of handing over the sockets directly through > shepherd. Looking at [4], it appears the meaning of "port" is closer > to that of a default port, as addresses can have ports in them. But I > would still prefer addresses to be "endpoints", which if they happen to > be a list of strings are taken as MPD addresses and if they happen to > be shepherd endpoints are passed on to the shepherd service. Are you proposing for the 'addresses' field to be a "maybe-list-of-string-or-shepherd-endpoint"? (more of a xor as they can't be used simultaneously) Example: --8<---------------cut here---------------start------------->8--- ;; should fire a error message during guix system reconfigure (mpd-configuration (addresses `("[::]:6645" ,(shepherd-endpoint (address "/var/run/mpd-shepherd-socket"))))) --8<---------------cut here---------------end--------------->8--- I don't think it breaks backward compatibility to introduce this after #59866 is merged. The type of field 'addresses' could be changed transparently to something like: --8<---------------cut here---------------start------------->8--- (define list-of-addresses (list-of (lambda (x) (or (string? x) (shepherd-endpoint? x))))) --8<---------------cut here---------------end--------------->8---