From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>, 57704@debbugs.gnu.org
Subject: [bug#57704] [PATCH v2] guix: packages: Remove #f from inputs when sanitizing.
Date: Sat, 10 Sep 2022 08:40:14 +0200 [thread overview]
Message-ID: <d53c94cb177679260842edc30212c245dea18bdb.camel@gmail.com> (raw)
In-Reply-To: <7c897510-3362-2ca1-641a-2728c013678f@telenet.be>
Am Samstag, dem 10.09.2022 um 02:33 +0200 schrieb Maxime Devos:
> The docstring is nice, but with documentation, I meant the manual,
> presumably in ‘(guix)package Reference’, maybe also in the packaging
> tutorial in the cookbook.
I don't see the current practice documented, so I think we're actually
good on this front.
> Also, something I forgot: performance. sanitize-inputs is called for
> every package, and the change adds additional memory allocations (due
> to the use of 'filter'), is there an observable performance impact
> (maybe "GUIX_PROFILING=gc time guix refresh -l pkg-config" would be a
> good test)? If there is, some optimisations may be in order
Looking at the numbers below
Garbage collection statistics:
heap size: 212.66 MiB
allocated: 739.15 MiB
GC times: 20
time spent in GC: 5.30 seconds (65% of user time)
real 0m3,606s
user 0m8,140s
sys 0m0,109s
Garbage collection statistics:
heap size: 276.29 MiB
allocated: 1292.10 MiB
GC times: 28
time spent in GC: 10.48 seconds (64% of user time)
real 0m11,638s
user 0m16,422s
sys 0m0,308s
it does appear that this increases times by a factor of two. Use of
filter! instead of filter brings only marginal benefits. I'll check if
we could instead simply ignore unspecified? values when collecting the
inputs – that would allow the natural use of (when) and (unless).
Cheers
next prev parent reply other threads:[~2022-09-10 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:56 [bug#57704] [PATCH core-updates] guix: packages: Remove #f from inputs when sanitizing Liliana Marie Prikler
2022-09-09 15:56 ` [bug#57704] [PATCH v2] " Liliana Marie Prikler
2022-09-10 0:33 ` Maxime Devos
2022-09-10 6:40 ` Liliana Marie Prikler [this message]
2022-09-10 7:44 ` Liliana Marie Prikler
2022-09-09 18:54 ` [bug#57704] [PATCH core-updates] " Maxime Devos
2022-09-10 7:41 ` [bug#57704] [PATCH v3] guix: Filter unspecified " Liliana Marie Prikler
2022-09-10 10:19 ` Maxime Devos
2022-09-26 20:51 ` [bug#57704] [PATCH core-updates] guix: packages: Remove #f from " Ludovic Courtès
2024-01-20 20:43 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d53c94cb177679260842edc30212c245dea18bdb.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=57704@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.