From: kei@openmailbox.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add p7zip.
Date: Tue, 09 Aug 2016 12:15:32 -0400 [thread overview]
Message-ID: <d2af6f069d7b8bbf217d39583f98cf2d@openmailbox.org> (raw)
In-Reply-To: <871t1y74fe.fsf@mdc-berlin.de>
On 2016-08-09 04:05, Ricardo Wurmus wrote:
> Leo Famulari <leo@famulari.name> writes:
>
>>> > I see that you took care of removing non-free parts in a patch and a
>>> > build phase. Since “guix build -S p7zip” doesn’t run the build phase
>>> > users would still end up with a source archive containing the non-free
>>> > parts. The best way is thus to remove things in a snippet.
>>> >
>>> > In “shogun” from the “machine-learning” module we remove supporting code
>>> > for non-free features in a snippet by cutting out anything between some
>>> > ifdef markers, but looking at the patch I see that it wouldn’t be
>>> > feasible for p7zip.
>>>
>>> Also note that it is not completely desirable for nonfree code to be
>>> removed
>>> with a patch, and is one of the reasons Guix supports snippets in the
>>> first
>>> place.
>>
>> Is there a reason to not use a patch in this case? Or can we proceed
>> with packaging p7zip, using a patch to remove non-free parts?
>
> We don’t want to have a “reverse image” of the non-free code in a
> patch.
> Arguably that would just be a derivative of the non-free code, so we
> also couldn’t freely distribute it.
>
If this is the case, then should we alert the Parabola GNU/Linux-libre
packagers?
The patch I submitted is the same one they use when installing p7zip
from the
source code (see
https://git.parabola.nu/abslibre.git/tree/libre/p7zip/libre.patch).
next prev parent reply other threads:[~2016-08-09 16:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 0:52 [PATCH] gnu: Add p7zip Kei Kebreau
2016-08-02 7:06 ` Ricardo Wurmus
2016-08-02 15:54 ` Kei Kebreau
2016-08-04 2:45 ` Kei Kebreau
2016-08-02 18:38 ` Eric Bavier
2016-08-08 19:58 ` Leo Famulari
2016-08-09 8:05 ` Ricardo Wurmus
2016-08-09 16:15 ` kei [this message]
2016-08-09 19:16 ` Ricardo Wurmus
2016-08-09 20:06 ` Kei Kebreau
2016-08-09 20:33 ` Ricardo Wurmus
2016-08-12 19:29 ` Kei Kebreau
2016-08-22 11:06 ` Ricardo Wurmus
2016-08-22 23:58 ` Kei Kebreau
2016-08-27 10:36 ` Kei Kebreau
2016-08-31 20:45 ` Ricardo Wurmus
2016-09-01 15:57 ` Kei Kebreau
2016-09-01 18:29 ` Ricardo Wurmus
2016-09-01 19:05 ` Kei Kebreau
2016-09-02 8:26 ` Efraim Flashner
2016-09-02 11:51 ` Ricardo Wurmus
2016-09-02 12:06 ` Efraim Flashner
2016-09-02 12:12 ` Ricardo Wurmus
2016-09-02 13:49 ` Kei Kebreau
2016-09-04 14:31 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2af6f069d7b8bbf217d39583f98cf2d@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.