From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 1/9] gnu: Add ttfautohint. Date: Wed, 06 Apr 2016 09:57:59 -0500 Message-ID: References: <1459917181-19626-1-git-send-email-ericbavier@openmailbox.org> <87wpobvssk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anouS-0003t8-6f for guix-devel@gnu.org; Wed, 06 Apr 2016 10:58:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anouN-00063u-Sg for guix-devel@gnu.org; Wed, 06 Apr 2016 10:58:20 -0400 Received: from smtp6.openmailbox.org ([62.4.1.40]:44985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anouN-00060P-JP for guix-devel@gnu.org; Wed, 06 Apr 2016 10:58:15 -0400 In-Reply-To: <87wpobvssk.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org On Wed, 06 Apr 2016 15:13:47 +0300 Alex Kost wrote: > ericbavier@openmailbox.org (2016-04-06 07:32 +0300) wrote: > > > From: Eric Bavier > > > > * gnu/packages/fontutils.scm (ttfautohint): New variable. > > * gnu/packages/patches/ttfautohint-source-date-epoch.patch: New patch. > > * gnu-system.am (dist_patch_DATA): Add it. > > --- > > gnu-system.am | 1 + > > gnu/packages/fontutils.scm | 36 ++++++++++- > > .../patches/ttfautohint-source-date-epoch.patch | 70 ++++++++++++++++++++++ > > 3 files changed, 106 insertions(+), 1 deletion(-) > > create mode 100644 gnu/packages/patches/ttfautohint-source-date-epoch.patch > [...] > > +(define-public ttfautohint > > + (package > > + (name "ttfautohint") > > + (version "1.5") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "mirror://savannah/freetype/ttfautohint-" > > + version ".tar.gz")) > > + (sha256 > > + (base32 > > + ;; /gnu/store/5kzmy7061aimljpga9qfz49227283sfr-ttfautohint-1.5.tar.gz > ^^^^^^^^^^ > Leftover line? Yes, thanks for catching it. > > + "1lgghck46p33z3hg8dnl76jryig4fh6d8rhzms837zp7x4hyfkv4")) > > + (patches (map search-patch '("ttfautohint-source-date-epoch.patch"))))) > > Since it's just a single patch, I don't see a reason to use 'map' here. Just that it's less to change if more patches are added later. The same has been used in other packages. > > > + (build-system gnu-build-system) > > + (native-inputs > > + `(("flex" ,flex) > > + ("bison" ,bison) > > + ("pkg-config" ,pkg-config))) > > + (inputs > > + `(("freetype" ,freetype) > > + ("harfbuzz" ,harfbuzz))) > > + (arguments > > + `(#:configure-flags '("--with-qt=no"))) ;no gui > > + (synopsis "Automated font hinting") > > + (description > > + "ttfautohint provides a 99% automated hinting process and a platform for > > +finely hand-hinting the last 1%. It is ideal for web fonts and supports many > > +scripts.") > > + (license license:gpl2+) ;or FreeType license > > Or FreeType? Sorry, what does it mean? If some files are under GPL2+ > and some under FreeType, then why don't you use a list of licenses? > The license text says to pick one, and I wanted to indicate that in some way in the absense of more descriptive license operators. `~Eric