From: Jonathan Brielmaier <jonathan.brielmaier@web.de>
To: Tobias Geerinckx-Rice <me@tobias.gr>, Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."
Date: Thu, 27 Jun 2019 10:05:30 +0200 [thread overview]
Message-ID: <d1c51f72-62f7-81f5-ead7-dcd6f9f74fa6@web.de> (raw)
In-Reply-To: <87d0izd032.fsf@nckx>
On 6/27/19 8:16 AM, Tobias Geerinckx-Rice wrote:
> Mark,
>
> Mark H Weaver wrote:
>> I don't doubt that reverting these commits was the right thing to do,
>> but it would be good to know _why_ they were reverted. Can you provide
>> a link to a relevant discussion, or else explain it here?
>
> They remove .../var/empty which breaks ssh-daemon.
>
>> In general, when reverting commits, I think it would be useful to
>> include an explanation in the commit log. What do you think?
>
> You're probably asking the wrong person. I'm all for it. It's not the
> done thing in Guix, tho'.
I don't think that the GNU standard forbids explanations additionally to
the required change description. Personally I often miss this, because
the commit description describes often only the obvious and not the
_reasoning_ :(
A good example for that are commit messages from IBM at the kernel :)
next prev parent reply other threads:[~2019-06-27 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190626222130.32023.24888@vcs0.savannah.gnu.org>
[not found] ` <20190626222130.F3AE520A01@vcs0.savannah.gnu.org>
2019-06-27 5:52 ` 01/02: Revert "gnu: openssh: Clean-up custom install phase." Mark H Weaver
2019-06-27 6:16 ` Tobias Geerinckx-Rice
2019-06-27 6:39 ` Mark H Weaver
2019-06-27 6:52 ` Tobias Geerinckx-Rice
2019-06-27 8:05 ` Jonathan Brielmaier [this message]
2019-06-27 15:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c51f72-62f7-81f5-ead7-dcd6f9f74fa6@web.de \
--to=jonathan.brielmaier@web.de \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.