From: Fatima Toothpaste via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54273@debbugs.gnu.org
Subject: [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1.
Date: Sun, 13 Mar 2022 10:14:11 +0900 [thread overview]
Message-ID: <d0b1fbe9-9909-d238-7158-2fb06dcc201f@disroot.org> (raw)
In-Reply-To: <87lexgw34t.fsf@gnu.org>
Sorry, I fixed what you said, and other messes i made.
Thanks for reviewing.
On 3/12/22 07:11, Ludovic Courtès wrote:
> Hi,
>
> Fatima Toothpaste <fatimatoothpaste@disroot.org> skribis:
>
>> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1.
>> [arguments]: Delete check phase.
>> [inputs]: Add bash-minimal.
>> [home-page]: Update URL.
> [...]
>
>> + ;;Tests require network connection
>> + (delete 'check))))
> Tests should rather be disabled with #:tests? #f.
>
> However, could you check if we can just skip (or tweak?) the tests that
> specifically depend on networking?
>
> The rest of the patch looks good to me.
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2022-03-13 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 5:45 [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1 Fatima Toothpaste via Guix-patches via
2022-03-11 22:11 ` Ludovic Courtès
2022-03-13 1:14 ` Fatima Toothpaste via Guix-patches via [this message]
2022-03-12 13:59 ` [bug#54273] [PATCH V2] gnu : nicotine+: Update " Fatima Toothpaste via Guix-patches via
2022-03-13 1:14 ` Fatima Toothpaste via Guix-patches via
2022-03-13 11:06 ` Maxime Devos
2022-03-13 15:45 ` Fatima Toothpaste via Guix-patches via
2022-03-13 15:41 ` [bug#54273] [PATCH V3] " Fatima Toothpaste via Guix-patches via
2022-03-15 9:52 ` bug#54273: [PATCH] gnu: nicotine+: update " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b1fbe9-9909-d238-7158-2fb06dcc201f@disroot.org \
--to=guix-patches@gnu.org \
--cc=54273@debbugs.gnu.org \
--cc=fatimatoothpaste@disroot.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.