From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kNx+AMcUvmGGcAAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 18:05:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kKC1N8YUvmEvNQAAbx9fmQ (envelope-from ) for ; Sat, 18 Dec 2021 17:05:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA85212626 for ; Sat, 18 Dec 2021 18:05:10 +0100 (CET) Received: from localhost ([::1]:48046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myd8v-00010K-TI for larch@yhetil.org; Sat, 18 Dec 2021 12:05:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd7r-0007uF-Dz for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myd7r-0007hl-5r for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myd7r-00050i-2x for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 17:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52247 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 52247@debbugs.gnu.org Received: via spool by 52247-submit@debbugs.gnu.org id=B52247.163984699919172 (code B ref 52247); Sat, 18 Dec 2021 17:04:03 +0000 Received: (at 52247) by debbugs.gnu.org; 18 Dec 2021 17:03:19 +0000 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd78-0004zA-UA for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:57577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd76-0004yv-Qs for 52247@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:17 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8CC27240104 for <52247@debbugs.gnu.org>; Sat, 18 Dec 2021 18:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1639846990; bh=gIiJWsdBz/eRW9yOCvg42+rKHwffIpzHUUjA4sMpgGU=; h=Subject:From:To:Cc:Date:From; b=YLZDHJKyO7de3KCnFsR3SLNsnjEt5VDGEx1f1scNkGr0mCOTj7M2TFrEXrkOCodAi wH1GRwzym6EdxsVoqGzTlRtHAbmQBQ3Ae3edlepiuMpdchgEN+xuOmCXV6knPkSD1Y DywJvwGw8/4MIvKWAQ4ZtEDn+ByyQutDEB+uTsdwhBjy+QPq/jIKbLbVLy0gIJo7V/ lvDR3uwOKWnv9YhpOb/7O95Q8QYl10pNbA7SRJGbF6iLb4FzK2elLsUsU3SZ/ff0bZ t3OdnYfOU+14+bPmgS93cv33eWYpxB10lpicXorXyxIuINEZpMsN/7SE29cy7Rcewh L0Yk/ZbcF7J6g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JGXH03qM6z9rxS; Sat, 18 Dec 2021 18:03:08 +0100 (CET) Message-ID: From: Vinicius Monego Date: Sat, 18 Dec 2021 17:02:59 +0000 In-Reply-To: References: <20211202161817.554276-1-monego@posteo.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639847110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JCgYFIkJumHW+O8nb5ks4RTS3JY8Vk9HHu5IeOlfWyo=; b=X7LVdjYi40w1L/K3KGkUHUqEGLKuCdFBPmxEoIhzCR7IQB90WIaXjDj8G7Zyp0MpbISlDO XSJ3ukHHbJbTupY2g/uT7yJVmfVPXIWe1qpcK9NnNJmMX98e1VPUe8gaP362ZGdtsbd/r7 qmJSNndAsU2R72XNHgqSVs3YLTxHO6DxIRkVVzW2xeV0zEzDqjBIXVgQiPp1j9gTGfo6RU AUzCCMWoq1crLDl7SOS29C2riZ/r/iVNaLFX95OtxfIM11X1O9w6fRDa1ftmt6gOSWEBCo 3M+rWzcZrqzQq94kx9UiRy3CwAF9B6IrlABfMCctYZ+OSmDl5XFczdd+gSW3BQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639847110; a=rsa-sha256; cv=none; b=UnY2MynXqf82/jRFeCarBeSBEdVgLl6Wyta4N3VVDmVXsP3jTqE1jUuQAfIIktJE1Nnc8M 62BARKowsX4Js4OFyyEUjLfdsAVoEXy64OxDfali3C0ezwNcT10mVQTs4kcDQLhKmZmC4I 5fcactnyZiV38tf8ihTKq2Ur6jztIko8d920JJNrGiQaCrBU/2RBZoWF7s0g8O6JhZ1JPv m9S8cNsruCuKcH8zWHYzSnhN0xfbJ2ROw/1oZRwc6W7ADPF8q6G1T246kUhUBQ/uAVfjMt Kle9hF0zLsYH1Oge2VVWhgT9jLYG1DOsmuFnNAH5f3nLqgbKpqeITkhIFezmOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=YLZDHJKy; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=YLZDHJKy; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BA85212626 X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: m1xFrHg6tKJA Em qui, 2021-12-02 às 14:16 -0500, Leo Famulari escreveu: > On Thu, Dec 02, 2021 at 04:18:17PM +0000, Vinicius Monego wrote: > > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink > > ffmpeg and > > mlt binaries to the Shotcut bin folder and remove unused PATH and > > MLT_PREFIX > > environment variables in the 'wrap-executable phase. > > I read your message about this in #50433: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50433#17 > > The first link, which points to code that copies "files from other > projects to its bin directory", is in a function named deploy_mac, so > I > don't think it's relevant for us. > > Overall, I think it's unusual that we would copy or symlink one > program > into another like this. I read build-shotcut.sh and it seems they > actually intend to compile ffmpeg themselves... > > https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1352 > > ... and then use a wrapper script to point to it: > > https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1369 > > That's weird for something as common as ffmpeg, although I actually > have > some private packages based on custom ffmpeg, so I am sympathetic. > > I think we should ask upstream for advice. They do support distro > packagers, apparently: > > https://github.com/mltframework/shotcut/issues/769#issuecomment-528686712 > > Can you do that? I can do it if you'd rather not. And I'm sorry if > you > already knew all this and I'm just wasting your time. Hi, How about this solution? https://github.com/NixOS/nixpkgs/blob/aecab6adbd682960b1b341cf20e4c53ddf722104/pkgs/applications/video/shotcut/default.nix#L59 It expands the executable names to the full store paths in the files where they are called. Could be done with substitutions in a phase.