From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMeAf-0005mE-PJ for guix-patches@gnu.org; Sat, 26 May 2018 14:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMeAc-0006nq-HA for guix-patches@gnu.org; Sat, 26 May 2018 14:44:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMeAc-0006mU-9Y for guix-patches@gnu.org; Sat, 26 May 2018 14:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMeAb-0001Tf-QH for guix-patches@gnu.org; Sat, 26 May 2018 14:44:01 -0400 Subject: [bug#30693] Xonotic Resent-Message-ID: References: <20180525164150.046d365d@mykolab.com> <20180525165254.cp5p7ygrduttoa5p@abyayala> <20180526182505.1d49f5b2@mykolab.com> From: Charlie Ritter In-reply-to: <20180526182505.1d49f5b2@mykolab.com> Date: Sat, 26 May 2018 14:43:13 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rutger Helling Cc: Nils Gillmann , 30693-done@debbugs.gnu.org Rutger Helling writes: > I pushed the patch with two minor changes (licenses, invoke instead of > system for xonotic-data). Thanks again! > > I didn't open a new bug, no. > > I agree it's a shame about patches sometimes being in limbo for so > long. I don't see a solution other than to try to get more people > involved in Guix. > > On Fri, 25 May 2018 16:52:54 +0000 > Nils Gillmann wrote: > >> Rutger Helling transcribed 1.1K bytes: >> > This patch has been open for quite a while! Which is a shame >> > because it works well. >> > >> > The license talked about seems to be GPL2+, see this commit: >> > >> > https://github.com/xonotic/xonotic/commit/12105b36a21e7472f72933b6dd409465b5133396 >> > >> > They recently changed it to GPL3+, but this current release in the >> > patch is still GPL2+. >> > >> > Is it alright if I make those changes in the licenses and push? >> >> The software would still be GPL2+. Only when we use the new one >> it will be GPL3+. >> >> As long as you keep my copyright and add yours its fine for me >> (I worked some time to get this working). >> >> Offtopic: >> Did you open a new issue number to reference the old number? >> I was able to see threading in notmuch but not in my actual >> email client. >> >> Ontopic: >> I continued working on this in a version which only applies to >> my work. A friend reported to me that there are issues with >> one or two of the 3 possible runtime modes which should be >> fixed. >> >> Offtopic: >> I've had some patches open waiting for months (after 3 months >> I stopped counting), so for now I only submit what's necessary >> and still (freshly) applies. >> FYI, the vim-build-system is working just fine and >> I'm integrating it in my part of the software already. It just >> seems like we have no people at all interested (or with time >> on their hands) to review Vim related code. >> This is no critique on work done by mostly volunteers, but we >> could do better. It's not criticism because I have no constructive >> ideas how it could be managed better. Yay! Good work!