From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types. Date: Mon, 27 Feb 2017 11:27:47 +0100 Message-ID: References: <20170226194203.25746-1-clement@lassieur.org> <87tw7gugze.fsf@lassieur.org> <87shn0ug4w.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciIXA-0002Nf-41 for guix-devel@gnu.org; Mon, 27 Feb 2017 05:28:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciIX6-0001eO-2F for guix-devel@gnu.org; Mon, 27 Feb 2017 05:28:00 -0500 Received: from pb-sasl2.pobox.com ([64.147.108.67]:63659 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciIX5-0001eF-Ui for guix-devel@gnu.org; Mon, 27 Feb 2017 05:27:55 -0500 In-Reply-To: <87shn0ug4w.fsf@lassieur.org> (=?utf-8?Q?=22Cl=C3=A9ment?= Lassieur"'s message of "Mon, 27 Feb 2017 10:39:27 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Cc: guix-devel@gnu.org On Mon 27 Feb 2017 10:39, Cl=C3=A9ment Lassieur writ= es: > Cl=C3=A9ment Lassieur writes: > >> Andy Wingo writes: >> >>> On Sun 26 Feb 2017 20:42, Cl=C3=A9ment Lassieur = writes: >>> >>>> * gnu/services/mail.scm (unix-listener-configuration)[path] >>>> (fifo-listener-configuration)[path]: Change type from 'file-name' to= 'string'. >>>> * doc/guix.texi (Mail Services): Document it. >>> >>> Why's that? Is the extra checking from the file-name type (that the >>> string start with "/") getting in the way of something? >> >> Yes, because the path is also used as the section name (see >> http://wiki2.dovecot.org/Services#Service_listeners). >> >> So for example, this code (from gnu/services/mail.scm:445) raises an >> error because "lmtp" doesn't start with "/": >> >> (service-configuration >> (kind "lmtp") >> (listeners >> (list (unix-listener-configuration (path "lmtp") (mode "0666"))))) >> >> I don't understand how it could work before. Maybe the check wasn't >> done. > > Well, maybe here "lmtp" is not the section name, but the path, relative > to "base_dir". Sould I update the documentation to specify that "path" > may be relative to "base_dir" too? Sure, anyway patch LGTM. Thanks for taking the time to explain. Andy