From mboxrd@z Thu Jan 1 00:00:00 1970 From: mikadoZero Subject: Re: Automated linting before master branch commit Date: Wed, 27 Mar 2019 09:01:26 -0400 Message-ID: References: <20190325182412.40b822db@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:47413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h98C2-0008Rr-8t for guix-devel@gnu.org; Wed, 27 Mar 2019 09:02:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h98C1-0002Lo-DC for guix-devel@gnu.org; Wed, 27 Mar 2019 09:02:10 -0400 Received: from forward101o.mail.yandex.net ([2a02:6b8:0:1a2d::601]:46390) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h98C0-0002Ja-Kl for guix-devel@gnu.org; Wed, 27 Mar 2019 09:02:09 -0400 In-reply-to: <20190325182412.40b822db@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: Guix-devel Danny Milosavljevic writes: > Hi, > >> What do people think about automating package linting? This would be to >> make sure a package is linted before it is committed to the Guix >> repository master branch? > > A linter by its nature will in some cases flag things which are not wrong, > otherwise one could just check the stuff while compiling in the first place. > >> I am not familiar with what Guix uses for continuous integration / >> deployment. > > We can manually make cuirass and/or Hydra evaluate custom branches--but it's > not automated. > > Christopher Baines is working on making patch review better--see thread > "Patchwork + automated checking and testing of patches". Thanks for sharing that thread. >> Estimated number of packages with autogenerated tarball: >> >> 389 > > Yeah, those should be updated. With that many packages, writing a script > to do it would be less annoying.