From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRKeF-0007up-Uh for guix-patches@gnu.org; Wed, 22 Apr 2020 15:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRKeE-0000hm-HF for guix-patches@gnu.org; Wed, 22 Apr 2020 15:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRKeE-0000hd-4z for guix-patches@gnu.org; Wed, 22 Apr 2020 15:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRKeE-0005Fl-1F for guix-patches@gnu.org; Wed, 22 Apr 2020 15:03:02 -0400 Subject: [bug#40767] [PATCH] gnu: Add maradns. Resent-Message-ID: From: Arun Isaac In-Reply-To: <87lfmnock3.fsf@gmail.com> References: <20200422132922.9539-1-arunisaac@systemreboot.net> <87lfmnock3.fsf@gmail.com> Date: Thu, 23 Apr 2020 00:31:49 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 40767@debbugs.gnu.org --=-=-= Content-Type: text/plain > Hello, Thanks for the patch review! >> + #:make-flags (list "CC=gcc" >> + (string-append "PREFIX=" %output) >> + (string-append "RPM_BUILD_ROOT=" %output)) > > Hard-coding CC variable this way prevents cross-compilation. Oops, I overlooked that. > If you run: > > --8<---------------cut here---------------start------------->8--- > ./pre-inst-env guix build maradns --target=aarch64-linux-gnu --target=aarch64-linux-gnu > --8<---------------cut here---------------end--------------->8--- > > you will obtain a native version of the binaries. Something like that > would work better: > > --8<---------------cut here---------------start------------->8--- > (string-append "CC=" (if target > (string-append (assoc-ref %build-inputs "cross-gcc") > "/bin/" target "-gcc") > "gcc")) > --8<---------------cut here---------------end--------------->8--- Sure, I'll fix this. Any other changes? > As this is a recurrent problem we may need to put this snippet into a > gnu-build-system function? I think that's a good idea. The build phase of the gnu-build-system should include this snippet. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl6glJ0ACgkQLiXui2GA K7MnAggAhADLc3nzWBLga72Mzop/cAX+DgbnkeM+WGUUooEpsSIAIgoles1CXfVf NzMpWQ7MOzKXv7KpD4b1PfBNU2DwJhpM16Q5kGr0RbsmtYBcHbP/7Sb1gZzP4kBH lEfCTYT/iOkZakiJVuGh6yckxGaxdjFp+ZIrmjHpefLBFPccUdC429nsw5ImtLNQ G9nWmBF1eGM+lERJXBruTYlHwwZrdsbSbpdyBhjoWN1UT581TrylvE6kiFz0WH9B W1MNfgb/8uuTHLu3MQk9Okn8golvhoEla2UsKcHGnZ2BX2UeZmy62oF6mWmshMO3 aM/lqtg9ZzwOmdrRHSVjzikj82tXjg== =zXlA -----END PGP SIGNATURE----- --=-=-=--