From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43410) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSdyC-0006CO-1i for guix-patches@gnu.org; Sun, 26 Apr 2020 05:53:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSdyA-0005gX-Sz for guix-patches@gnu.org; Sun, 26 Apr 2020 05:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSdyA-0005f2-GL for guix-patches@gnu.org; Sun, 26 Apr 2020 05:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSdyA-0005j5-Cw for guix-patches@gnu.org; Sun, 26 Apr 2020 05:53:02 -0400 Subject: [bug#40767] [PATCH] gnu: Add maradns. Resent-Message-ID: From: Arun Isaac In-Reply-To: <87mu6yfwgu.fsf@gmail.com> References: <20200422132922.9539-1-arunisaac@systemreboot.net> <87lfmnock3.fsf@gmail.com> <87blnioawj.fsf@gmail.com> <87y2qkx9sh.fsf@gmail.com> <87v9lng2hx.fsf@gmail.com> <87mu6yfwgu.fsf@gmail.com> Date: Sun, 26 Apr 2020 15:21:38 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 40767@debbugs.gnu.org --=-=-= Content-Type: text/plain >> guix lint checks for lines longer than 90 characters. Perhaps that's the >> new policy? See the function report-long-line in guix/lint.scm. It even >> has a comment noting that we don't warn at 80 characters. > > Yes it's to avoid false positives with hashes and URLs. On the other > hand, in .dir-locals.el, fill-column variable is set to 78. Maybe we > would need to be more explicit in the "Coding style" section of the > manual. Do please raise this in guix-devel and we could get some consensus on this. > Nitpicking, you can use the target argument instead of > %current-target-system, this way: > > --8<---------------cut here---------------start------------->8--- > (lambda* (#:key native-inputs target #:allow-other-keys) > ;; make_32bit_tables generates a header file that is used during > ;; compilation. Hence, during cross compilation, it should be > ;; built for the host system. > (when target > (substitute* "rng/Makefile" > (("\\$\\(CC\\) -o make_32bit_tables") > (string-append (assoc-ref native-inputs "gcc") > "/bin/gcc -o make_32bit_tables"))))) > --8<---------------cut here---------------end--------------->8--- > > Feel free to go ahead with this one, Pushed with suggested change. Thanks! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl6lWaoACgkQLiXui2GA K7NASgf/fabkg7eew649wJ0XJdc6ho5W871BwlcFHWme/zcNWBosIfA85pnI88Eh ONqPZPcM0NiUeWUt6teN0/WFZ6kfBsWD6C8FP/mfP0TqvyjqA0x8I4iCeINfutOi ZnSpCR6u8b9zZBher4tlp6I5Ut6g75BXKnesitFFGbfNfIcvaaMKlETByE95DqMV OhcDi4VwXwwBUtqeLEECUrSHHpQ1JGswonI75/qaUJHETjEnSCeJqeSgfwI2fi7n ComFYikAH2WlQAqF/wZ1B9+1kLK37SIPxy/ZLMYHi7nxDd817G0DpvxGLh1txqO+ shHAAIm3w9QG1L6nrqF2STTCfjsEVA== =xSo8 -----END PGP SIGNATURE----- --=-=-=--