From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48727)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4nA-00085y-BF
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:41:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4n9-0007AW-CA
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:41:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43003)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hj4n8-00079x-Hc
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:41:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4n8-0000VG-E2
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:41:02 -0400
Subject: [bug#36415] [PATCH] gnu: Add qlogo.
Resent-Message-ID: <handler.36415.B36415.15622584251883@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <20190702072132.GB22794@macbook41>
References: <20190628080358.14910-1-arunisaac@systemreboot.net>
 <20190702072132.GB22794@macbook41>
Date: Thu, 04 Jul 2019 22:10:04 +0530
Message-ID: <cu7k1cx21p7.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36415@debbugs.gnu.org

--=-=-=
Content-Type: text/plain


> On Fri, Jun 28, 2019 at 01:33:57PM +0530, Arun Isaac wrote:
>> +         ;; The check phase rebuilds the source for tests. So, it needs to be
>> +         ;; run after the install phase has installed the outputs of the build
>> +         ;; phase.
>> +         (delete 'check)
>> +         (add-after 'install 'check
>> +           (lambda _
>> +             ;; Clean files created by the build phase.
>> +             (invoke "make" "clean")
>> +             ;; QLogo tries to create its "dribble file" in the home
>> +             ;; directory. So, set HOME.
>> +             (setenv "HOME" "/tmp")
>> +             ;; Build and run tests.
>> +             (invoke "qmake" "TestQLogo.pro")
>
> Doesn't this efectively just rebuild the binary we just built in the
> 'configure and 'build phases?

No. There are two qmake project files -- QLogo.pro and
TestQLogo.pro. QLogo.pro builds the "QLogo" executable and TestQLogo.pro
builds the "testqlogo" executable. "QLogo" is the actual qlogo
executable that we install. "testqlogo" simply runs the tests.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl0eK+QACgkQLiXui2GA
K7NI2ggAoahdRxXZLp2+D6NvD6VsZ0bcTUmsY4Ft5AQZZNqwyG6XVL44y0ZREmSD
GzkEiDR/zKRmHnd3mPkTagm4PLHhoGonJc9riLwKe4ZGT0lnaHpyIxZl++l/xaC7
P+7F5TDA4++vB0Oh4uUlK+yvT8HB/BohKr9xoWM4gvEkJAv7XKI/sTCaYUAohklT
7oTKUqbqL37k80gi3pQlJ28AX/XyuoMVqC9joen5X/ZDdPnAq96Jx6wJFLlZf+0S
n02qoMJkdBJoKGp5vBWEJatsMry358NYGv/4bdvwdeft3JXSM7Isbf2ZIolR9kml
ukV216cngMcLqE9ukSQCK4kCFgNdxQ==
=G5mF
-----END PGP SIGNATURE-----
--=-=-=--