all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Catonano <catonano@gmail.com>
Cc: 29878@debbugs.gnu.org
Subject: [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.
Date: Tue, 02 Jan 2018 18:10:21 +0530	[thread overview]
Message-ID: <cu7h8s4igcq.fsf@systemreboot.net> (raw)
In-Reply-To: <CAJ98PDy+HpyJBgrJnMY09C7Hf5HWGFqKAhESqDn7ho4avHZqng@mail.gmail.com>


> I didn't run it because I can't use Vi(m) so maybe it's better if someone
> else tests this

I do use this package. I installed it and checked. It works properly,
and I'm quite confident there are no issues. It's a very trivial
package, after all.

> I would say
>
> @code{emacs-evil-smartparens} is an Emacs minor mode which
> makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
> with Smartparens.
>
> I wouldn't assume that people reading the description know what Evil is
> Or, maybe a link to the Evil home page would be better, instead of a quite
> long sentence between commas ?

In the new patch I just sent, I have added a second sentence explaining
what Evil is. I don't think it's very useful to add a link in the
description text. IMHO, descriptions are better if they are
self-contained. The user can always search on the web if they want to
know more.

> Thanks !

Thanks for the review!

  reply	other threads:[~2018-01-02 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 11:39 [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens Arun Isaac
2017-12-31  6:54 ` Catonano
2018-01-02 12:40   ` Arun Isaac [this message]
     [not found]   ` <10e3dcdc.AEEASwxsv3wAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABaS33A@mailjet.com>
2018-01-02 14:08     ` Catonano
2018-01-02 18:07       ` bug#29878: " Arun Isaac
2018-01-02 12:28 ` [bug#29878] " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cu7h8s4igcq.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=29878@debbugs.gnu.org \
    --cc=catonano@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.