* [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
@ 2018-06-15 19:26 Arun Isaac
[not found] ` <handler.31850.B.15290908242382.ack@debbugs.gnu.org>
2018-06-16 16:13 ` [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs" Ludovic Courtès
0 siblings, 2 replies; 7+ messages in thread
From: Arun Isaac @ 2018-06-15 19:26 UTC (permalink / raw)
To: 31850
* gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
the absolute path to "gs" in the store.
---
gnu/packages/tex.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index b6bc9dda6..91081c64b 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -176,14 +176,16 @@
(string-prefix? "mips64" s))))
#:phases
(modify-phases %standard-phases
- (add-after 'unpack 'fix-unix-detection
+ (add-after 'unpack 'configure-ghostscript-executable
;; ps2eps.pl uses the "gswin32c" ghostscript executable on Windows,
;; and the "gs" ghostscript executable on Unix. It detects Unix by
;; checking for the existence of the /usr/bin directory. Since
;; GuixSD does not have /usr/bin, it is also detected as Windows.
- (lambda _
+ (lambda* (#:key inputs #:allow-other-keys)
(substitute* "utils/ps2eps/ps2eps-src/bin/ps2eps.pl"
(("gswin32c") "gs"))
+ (substitute* "texk/texlive/linked_scripts/epstopdf/epstopdf.pl"
+ (("\"gs\"") (string-append "\"" (assoc-ref inputs "ghostscript") "/bin/gs\"")))
#t))
(add-after 'install 'postint
(lambda* (#:key inputs outputs #:allow-other-keys #:rest args)
--
2.15.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <handler.31850.B.15290908242382.ack@debbugs.gnu.org>]
* [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
2018-06-15 19:26 [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs" Arun Isaac
[not found] ` <handler.31850.B.15290908242382.ack@debbugs.gnu.org>
@ 2018-06-16 16:13 ` Ludovic Courtès
2018-06-16 20:46 ` Ricardo Wurmus
1 sibling, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2018-06-16 16:13 UTC (permalink / raw)
To: Arun Isaac; +Cc: 31850, Ricardo Wurmus
Hello,
Arun Isaac <arunisaac@systemreboot.net> skribis:
> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
> the absolute path to "gs" in the store.
LGTM.
> I seem to have made one of the lines way too long. I'll fix that before
> pushing, once someone has reviewed this patch. Also, should this patch
> go to core-updates considering that the texlive package is very tedious
> to build?
‘texlive-bin’ has just 252 dependent it seems, many of which are
‘texlive-’ packages, which are usually quickly built. So I’d say it’s
OK for master, but I could be missing some other way in which
‘texlive-bin’ is depended on. Ricardo, WDYT?
Ludo’.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
2018-06-16 16:13 ` [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs" Ludovic Courtès
@ 2018-06-16 20:46 ` Ricardo Wurmus
2018-06-17 7:06 ` Arun Isaac
0 siblings, 1 reply; 7+ messages in thread
From: Ricardo Wurmus @ 2018-06-16 20:46 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 31850
Ludovic Courtès <ludo@gnu.org> writes:
> Hello,
>
> Arun Isaac <arunisaac@systemreboot.net> skribis:
>
>> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
>> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
>> the absolute path to "gs" in the store.
>
> LGTM.
>
>> I seem to have made one of the lines way too long. I'll fix that before
>> pushing, once someone has reviewed this patch. Also, should this patch
>> go to core-updates considering that the texlive package is very tedious
>> to build?
>
> ‘texlive-bin’ has just 252 dependent it seems, many of which are
> ‘texlive-’ packages, which are usually quickly built. So I’d say it’s
> OK for master, but I could be missing some other way in which
> ‘texlive-bin’ is depended on. Ricardo, WDYT?
Yes, this should be fine.
Thanks!
--
Ricardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
2018-06-16 20:46 ` Ricardo Wurmus
@ 2018-06-17 7:06 ` Arun Isaac
2018-06-17 11:44 ` Ricardo Wurmus
0 siblings, 1 reply; 7+ messages in thread
From: Arun Isaac @ 2018-06-17 7:06 UTC (permalink / raw)
To: Ricardo Wurmus, Ludovic Courtès; +Cc: 31850
>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>> ‘texlive-’ packages, which are usually quickly built. So I’d say it’s
>> OK for master, but I could be missing some other way in which
>> ‘texlive-bin’ is depended on.
But, we'd be forcing people to download the huge (~ 2.2 GB)
texlive-texmf source tarball. And, the texlive package which depends on
texlive-bin spends a good deal of time in the install phase. Is this
fine?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
2018-06-17 7:06 ` Arun Isaac
@ 2018-06-17 11:44 ` Ricardo Wurmus
2018-06-17 16:01 ` bug#31850: " Arun Isaac
0 siblings, 1 reply; 7+ messages in thread
From: Ricardo Wurmus @ 2018-06-17 11:44 UTC (permalink / raw)
To: Arun Isaac; +Cc: 31850
Arun Isaac <arunisaac@systemreboot.net> writes:
>>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>>> ‘texlive-’ packages, which are usually quickly built. So I’d say it’s
>>> OK for master, but I could be missing some other way in which
>>> ‘texlive-bin’ is depended on.
>
> But, we'd be forcing people to download the huge (~ 2.2 GB)
> texlive-texmf source tarball. And, the texlive package which depends on
> texlive-bin spends a good deal of time in the install phase. Is this
> fine?
Only until this is built, which in the case of texlive should not take a
very long time on the build farm.
--
Ricardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#31850: [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".
2018-06-17 11:44 ` Ricardo Wurmus
@ 2018-06-17 16:01 ` Arun Isaac
0 siblings, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2018-06-17 16:01 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 31850-done
>> But, we'd be forcing people to download the huge (~ 2.2 GB)
>> texlive-texmf source tarball. And, the texlive package which depends on
>> texlive-bin spends a good deal of time in the install phase. Is this
>> fine?
>
> Only until this is built, which in the case of texlive should not take a
> very long time on the build farm.
Ok, done. Pushed!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-17 16:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-15 19:26 [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs" Arun Isaac
[not found] ` <handler.31850.B.15290908242382.ack@debbugs.gnu.org>
2018-06-15 19:56 ` [bug#31850] Acknowledgement ([PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".) Arun Isaac
2018-06-16 16:13 ` [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs" Ludovic Courtès
2018-06-16 20:46 ` Ricardo Wurmus
2018-06-17 7:06 ` Arun Isaac
2018-06-17 11:44 ` Ricardo Wurmus
2018-06-17 16:01 ` bug#31850: " Arun Isaac
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.