From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcl89-0006dV-Kt
	for guix-patches@gnu.org; Tue, 10 Jul 2018 01:24:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcl86-0005av-FP
	for guix-patches@gnu.org; Tue, 10 Jul 2018 01:24:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45064)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fcl86-0005an-Bp
	for guix-patches@gnu.org; Tue, 10 Jul 2018 01:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcl86-00058Q-3A
	for guix-patches@gnu.org; Tue, 10 Jul 2018 01:24:02 -0400
Subject: [bug#32053] [PATCH 2/2] gnu: Add quaternion.
Resent-Message-ID: <handler.32053.B32053.153120022119711@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <87efgch9et.fsf@gnu.org>
References: <20180704174239.30870-1-arunisaac@systemreboot.net>
	<20180704174637.31129-1-arunisaac@systemreboot.net>
	<87efgch9et.fsf@gnu.org>
Date: Tue, 10 Jul 2018 10:53:27 +0530
Message-ID: <cu78t6jmzow.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 32053@debbugs.gnu.org


>> +    (inputs
>> +     `(("libqmatrixclient-source" ,(package-source libqmatrixclient))
>> +       ("qt" ,qt)))
>> +    (arguments
>> +     `(#:tests? #f ; No tests
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'unpack-libqmatrixclient
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (invoke "tar" "-C" "lib" "-xvf"
>> +                     (assoc-ref inputs "libqmatrixclient-source")
>> +                     "--strip-components=3D1"))))))
>
> That doesn=E2=80=99t sound great.  :-)
>
> Could we arrange to have it use an externally-built libqtmatrixclient.so?
> Perhaps that=E2=80=99ll involve modifying the CMake/Qt/whatever build fil=
es?

Yes, it isn't great. But I did that because that's the build process
upstream recommends. :-( I will explore alternatives and get back to
you.

>> +    (synopsis "Qt5 desktop client for the Matrix protocol")
>
> What about: =E2=80=9CGraphical client for the Matrix instant messaging pr=
otocol=E2=80=9D?
>
>> +    (description "Quaternion is a Qt5 desktop client for the Matrix pro=
tocol.
>
> s/protocol/instant messaging protocol/
>
> It=E2=80=99s all about giving enough context so that people know what kin=
d of
> matrix we=E2=80=99re talking about.  ;-)

Sure, I'll make these synopsis and description changes (for both
libqmatrixclient and quaternion). In my opinion, upstream calling their
protocol "Matrix" is a somewhat poor choice. The word "Matrix" is easily
confused with many other things.