From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdtZZ-0001MQ-Pk
	for guix-patches@gnu.org; Fri, 13 Jul 2018 04:37:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdtZV-0004SA-UC
	for guix-patches@gnu.org; Fri, 13 Jul 2018 04:37:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49767)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fdtZV-0004Rc-Nz
	for guix-patches@gnu.org; Fri, 13 Jul 2018 04:37:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdtZV-0001Sx-I3
	for guix-patches@gnu.org; Fri, 13 Jul 2018 04:37:01 -0400
Subject: [bug#32102] [PATCH v2 1/2] build-system: python: Only wrap non-hidden
	executable files.
Resent-Message-ID: <handler.32102.B32102.15314709725574@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <87a7qvmvjp.fsf@lassieur.org>
References: <20180711192652.20186-1-arunisaac@systemreboot.net>
	<20180711192652.20186-2-arunisaac@systemreboot.net>
	<87a7qvmvjp.fsf@lassieur.org>
Date: Fri, 13 Jul 2018 14:05:31 +0530
Message-ID: <cu77elzttws.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: mhw@netris.org, 32102@debbugs.gnu.org


> What about adding a function like 'is-wrapped?'?  Because it could be
> used somewhere else, and it would make the code self-descriptive.
>
> It would check that the name looks like .xxx-real, and also check that
> xxx exists.  (And check that it's an executable.)

Yes, that's a good idea. I'll add `is-wrapped?' to (guix build utils)
and export it. That way, both `wrap-program' from (guix build utils) and
the wrap phase from python-build-system can make use of it. I will send
an updated patchset once I'm done.