From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrXf-0005Lz-9I for guix-patches@gnu.org; Wed, 16 Jan 2019 15:12:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjrXe-0005zG-Cr for guix-patches@gnu.org; Wed, 16 Jan 2019 15:12:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gjrXe-0005yE-8P for guix-patches@gnu.org; Wed, 16 Jan 2019 15:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gjrXd-0004c6-UO for guix-patches@gnu.org; Wed, 16 Jan 2019 15:12:01 -0500 Subject: [bug#34108] [PATCH] import: github: Use prereleases when package has no releases. Resent-Message-ID: Received: from eggs.gnu.org ([209.51.188.92]:57326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrWr-0005J8-KG for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjrWq-00033h-Lq for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:13 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:54304) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjrWq-0002nn-6b for guix-patches@gnu.org; Wed, 16 Jan 2019 15:11:12 -0500 From: Arun Isaac Date: Thu, 17 Jan 2019 01:40:57 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 34108@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain For github packages with only prereleases (that is, no releases), `guix refresh PACKAGE` prints out the no-updater warning. This is incorrect behavior. It should instead fall back to using preleases. This patch fixes that. For an example, see the package quaternion in (gnu packages messaging). --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-import-github-Use-prereleases-when-package-has-no-re.patch Content-Transfer-Encoding: quoted-printable From=20df660be0d7756b792a8356c7b02855cc327a7494 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 17 Jan 2019 01:34:07 +0530 Subject: [PATCH] import: github: Use prereleases when package has no releas= es. * guix/import/github.scm (latest-released-version): Use preleases when pack= age has no releases. =2D-- guix/import/github.scm | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/guix/import/github.scm b/guix/import/github.scm index b287313d98..624b8c5a66 100644 =2D-- a/guix/import/github.scm +++ b/guix/import/github.scm @@ -179,14 +179,16 @@ API. This may be fixed by using an access token and s= etting the environment variable GUIX_GITHUB_TOKEN, for instance one procured from https://github.com/settings/tokens")) (let loop ((releases =2D (filter =2D (lambda (x) =2D ;; example pre-release: =2D ;; https://github.com/wwood/OrfM/releases/tag/v0.= 5.1 =2D ;; or an all-prerelease set =2D ;; https://github.com/powertab/powertabeditor/rel= eases =2D (not (hash-ref x "prerelease"))) =2D json))) + (if (null? + (filter + (lambda (x) + ;; example pre-release: + ;; https://github.com/wwood/OrfM/releases/tag/= v0.5.1 + ;; or an all-prerelease set + ;; https://github.com/powertab/powertabeditor/= releases + (not (hash-ref x "prerelease"))) + json)) + json))) (match releases (() ;empty release list #f) =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlw/j9IACgkQLiXui2GA K7N17wgAmfYlSFZmozIpxg36sqRydzA8PAXHiBKsvutVErmmUK3c/ty+QcruM0Ij rq1/Bt5bKtcFb5KqCi6YDim2X3HihHjsgx7ffcrzEl2zgV5UOeEmnlEFZtR95BFS euZgWLPozvvl86XM8Iqod1b4wIzL2IV+hkC7vGhVhzitHnXnq2rNgtRrlPHMwBzn uu2a9qcEvCOirPyEl4c58TeKFNQhS8fmXn8wvqZ7ua030K0AQNI+jrwUg9WcjbE5 tkpew8fxfPBTRZEDh670lVpXBMHbiPRPLrR47aTiwuvUdpCet/KCWp7Tdy2owoXP 6YV50OiEhB4pvT3vGDrd3E9+4P7JkA== =DsxX -----END PGP SIGNATURE----- --==-=-=--