From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fahKI-0004ab-06
	for guix-patches@gnu.org; Wed, 04 Jul 2018 08:56:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fahKE-0003AV-UO
	for guix-patches@gnu.org; Wed, 04 Jul 2018 08:56:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38107)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fahKE-0003A4-QR
	for guix-patches@gnu.org; Wed, 04 Jul 2018 08:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fahKE-0004ms-Id
	for guix-patches@gnu.org; Wed, 04 Jul 2018 08:56:02 -0400
Subject: bug#32008: [PATCH] gnu: ledger: Skip failing test.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.32008.D32008.153070890518320.done@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <87r2kkgm49.fsf@gnu.org>
References: <20180629170749.4211-1-arunisaac@systemreboot.net>
	<87r2klejgo.fsf@gnu.org> <cu71sckvgsh.fsf@systemreboot.net>
	<87r2kkgm49.fsf@gnu.org>
Date: Wed, 04 Jul 2018 18:24:42 +0530
Message-ID: <cu736wzjh4d.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 32008-done@debbugs.gnu.org


>>> It would be nice to make separate patches for unrelated things (for
>>> instance invoke and phase returns have nothing to do with skipping the
>>> test), but otherwise LGTM.
>>
> Honestly it doesn=E2=80=99t matter much here, but what I like about
> one-patch-for-one-thing is that it makes review and bug hunting (when
> you later run =E2=80=98git annotate=E2=80=99 to understand what happened)=
 easier.

I understand the concerns. I used to split commits a lot. But, then I
saw others using more bunched commits. So, I thought I was overdoing the
splitting.

>> Shall I push with the above mentioned changes?
>
> Sure!

Pushed as three separate commits! Thank you for the review!