From: Arun Isaac <arunisaac@systemreboot.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 32008-done@debbugs.gnu.org
Subject: bug#32008: [PATCH] gnu: ledger: Skip failing test.
Date: Wed, 04 Jul 2018 18:24:42 +0530 [thread overview]
Message-ID: <cu736wzjh4d.fsf@systemreboot.net> (raw)
In-Reply-To: <87r2kkgm49.fsf@gnu.org>
>>> It would be nice to make separate patches for unrelated things (for
>>> instance invoke and phase returns have nothing to do with skipping the
>>> test), but otherwise LGTM.
>>
> Honestly it doesn’t matter much here, but what I like about
> one-patch-for-one-thing is that it makes review and bug hunting (when
> you later run ‘git annotate’ to understand what happened) easier.
I understand the concerns. I used to split commits a lot. But, then I
saw others using more bunched commits. So, I thought I was overdoing the
splitting.
>> Shall I push with the above mentioned changes?
>
> Sure!
Pushed as three separate commits! Thank you for the review!
prev parent reply other threads:[~2018-07-04 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 17:07 [bug#32008] [PATCH] gnu: ledger: Skip failing test Arun Isaac
2018-07-02 15:38 ` Ludovic Courtès
[not found] ` <cu71sckvgsh.fsf@systemreboot.net>
2018-07-03 19:22 ` Ludovic Courtès
2018-07-04 12:54 ` Arun Isaac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cu736wzjh4d.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=32008-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.