From: 45mg <45mg.writes@gmail.com>
To: 75145@debbugs.gnu.org
Cc: guix-devel@gnu.org, 45mg <45mg.writes@gmail.com>
Subject: [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Date: Thu, 9 Jan 2025 12:24:30 +0000 [thread overview]
Message-ID: <cover.1736423822.git.45mg.writes@gmail.com> (raw)
In-Reply-To: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@gmail.com>
Hi Guix,
As the first revision of this patch failed to get any attention in two weeks,
I'm CC'ing guix-devel on this one, hoping it'll get reviewed this time. Let me
know if I should have done anything differently; I'm still relatively new to
contributing.
This patch allows users to specify configuration files for NetworkManager.
While perhaps it would be more Guix-y to instead have a field in
`network-manager-configuration` for every configuration option, this would be
a monumental undertaking (look at the number of options listed in
NetworkManager.conf(5)!). At any rate, I think any means of configuring
NetworkManager is better than none.
The difference from the first revision is that instead of specifying a single
directory (file-like object) containing the configuration files (which was
then symlinked to /etc/NetworkManager/conf.d), you now specify an alist
mapping file names to file-like objects, like with `etc-service-type`; and
those are then added to /etc/NetworkManager/conf.d. The rationale behind this
change is that it doesn't rule out putting our own stuff in
/etc/NetworkManager/conf.d. For example, if we wanted a default set of files
in there, we could modify the procedure
`network-manager-configuration-directory` to add the files supplied via the
field to our default set; in the first revision, this wouldn't be possible as
the user specifies the entire directory. (I don't know whether we'd ever
actually want to do this, but I thought it best to leave our options open.)
45mg (1):
services: network-manager: Add extra-configuration-files field.
doc/guix.texi | 21 +++++++++++++++++++++
gnu/services/networking.scm | 26 ++++++++++++++++++++++++--
2 files changed, 45 insertions(+), 2 deletions(-)
base-commit: 7f27dc47c52886b785359799b6dc67b61f638544
--
2.47.1
next prev parent reply other threads:[~2025-01-09 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 18:18 [bug#75145] [PATCH] services: NetworkManager: configuration-directory 45mg
2025-01-09 12:24 ` 45mg [this message]
2025-01-09 14:44 ` [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field Arnaud Daby-Seesaram
2025-01-09 17:03 ` 45mg
2025-01-09 19:34 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2025-01-09 12:24 ` [PATCH v2 1/1] " 45mg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1736423822.git.45mg.writes@gmail.com \
--to=45mg.writes@gmail.com \
--cc=75145@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.