From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CHs1OGP6XWeLFgAAe85BDQ:P1 (envelope-from ) for ; Sat, 14 Dec 2024 21:36:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id CHs1OGP6XWeLFgAAe85BDQ (envelope-from ) for ; Sat, 14 Dec 2024 22:36:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=OSwl9KbA; dkim=fail ("headers rsa verify failed") header.d=freakingpenguin.com header.s=x header.b=EP9Uqrqn; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734212195; a=rsa-sha256; cv=none; b=BJqyL6deoh5TASMyujpLtzZ0/OxS2QJDRw6/H7YU3AqpkAxqH8Q2s2+oivsbf7ciWbWWuB HN0NPCkAKIbVcbDMQbWZEjn6RTffJcRTX1SxA9mqsqOyOJLHGU4PmWmBWwH4orxn+buJ5q 4a3YIgPEm4wiXWyNXA3aUB+9fekOpIPVzouJx0NiuiEn811723R484W57DzpF4Zm2YiPZT p6Vc7lPmqg6hzgACk/RW80eMIDiOt8OEkPL/fk8L78VY9x1v6eTA+KMaxzfZ0RKHS/ADGQ qsWXlPXvvwxryuu130eRhwnTiZhCPWVCAP5khsi9BM7zngtfj85UGuSNVo5flw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=OSwl9KbA; dkim=fail ("headers rsa verify failed") header.d=freakingpenguin.com header.s=x header.b=EP9Uqrqn; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734212195; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5ji+rAeJDqUJSqdYMHAwSkxR6sRU4ZPTBsb6hVImEf0=; b=kpmcExCzEfpfU8TPWty2HItoi/R3B+CLdO0/MM4Y7YZ/PkI1PDjdBSFNwitt4gMQ9Pz2T0 6sPDHssDEE+GKUZ5qAvO9y0gXEJVoTndERCLN58sNonHB3fnBGt09hYAKDqVcj+F8IPmPk ln+CEScjwOgHjVuYjBvmU5L4BZeKkfI4M61vwtIjO9AJ+Ri5RXUDhmswaLA+82Q5p54no4 GJlc03Pbrui9KiP5pynLrxAFafbyItzuTqZV5T0ep7H9avW5zQsY9/DhtlVm6+RD7EvuBu 3RBUMS1FG3MakOyDtP/MpuM13jJEibCRW9tnXkwvOFaMSfar3XIsIjO5GrPFXQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5B45647B0 for ; Sat, 14 Dec 2024 22:36:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMZo3-0001Zn-3t; Sat, 14 Dec 2024 16:36:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMZnw-0001YQ-36 for guix-patches@gnu.org; Sat, 14 Dec 2024 16:36:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMZnv-0002rm-No; Sat, 14 Dec 2024 16:36:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=5ji+rAeJDqUJSqdYMHAwSkxR6sRU4ZPTBsb6hVImEf0=; b=OSwl9KbA6s+85f4lTzJxvxBkZfzKF/VkTZTEUshMDdciXal64rc047MUXR2+K7KDSB1Wir9pifLCEggYGfAUWnTLQ3o7mnSJRbXCu+GEgMtXhCtiTayi+LQA1sKjQyhWlNqubxxHuR4wodoFFKyIjJadmlXZ9NJ1bRsAwIPRxXMK7+S4SUpCMe0GxzTrNxIsa/ZMBqpIhTwKQGfJ20wu00N6gE986EX0psQOVvcfzlFyhuukQKJXL9pNSzqCXllIn9JU+dqQSaUr8Ek2sz5RKtVVZ1uDJ1ntHR3Ze+MZcgG0rv4r9IsVlK9Ck1Lj0CGR/nmqZ+LLYVzmaaYtzeiM+g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMZnu-00011o-I7; Sat, 14 Dec 2024 16:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74837] [PATCH v3 0/2] resize-file-system-service References: In-Reply-To: Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Sat, 14 Dec 2024 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74837 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74837@debbugs.gnu.org Cc: Richard Sent , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 74837-submit@debbugs.gnu.org id=B74837.17342121513913 (code B ref 74837); Sat, 14 Dec 2024 21:36:02 +0000 Received: (at 74837) by debbugs.gnu.org; 14 Dec 2024 21:35:51 +0000 Received: from localhost ([127.0.0.1]:48607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMZnj-00010y-A3 for submit@debbugs.gnu.org; Sat, 14 Dec 2024 16:35:51 -0500 Received: from mail-108-mta68.mxroute.com ([136.175.108.68]:43317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMZng-00010o-I5 for 74837@debbugs.gnu.org; Sat, 14 Dec 2024 16:35:49 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta68.mxroute.com (ZoneMTA) with ESMTPSA id 193c71955d20003e01.001 for <74837@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 14 Dec 2024 21:35:46 +0000 X-Zone-Loop: 53f995a4adf7e929b8417eaa86582b4a0bd4d50ba2d5 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5ji+rAeJDqUJSqdYMHAwSkxR6sRU4ZPTBsb6hVImEf0=; b=EP9UqrqnWu+PeSsEVRMXZoxcGv Q6dnq0kiqLkzlMFLUvQ+mO//ak+Uz2MH82bRBOxg9Wvm6TkkxqZ9q5jVifEU5NbCyia0FmYqZ0tdK f+Ab+ZLe64cfSXjA46fsiAIfPLltCcDtVMl+mVZaYY2rtTOJ7ZJZ+QGsdg8lovaKNGWDMWCMOI63H K4/BeFIXuY3Br4RzkDGxjGS9I0+Sv6pWuJ3f6YmWzzbjWleAFD2TL1+PdKIdFsfbCnya6ehbQDkfE iMxBvD9dsQKl/Ezo6QPdDMH30VZc0rJ5THAjKYHCnxIMv8KxgV8iUzo7PO/hGHnJZktf0n8wyxDSi GmfUnHxQ==; From: Richard Sent Date: Sat, 14 Dec 2024 16:18:21 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.11 X-Spam-Score: -3.11 X-Migadu-Queue-Id: B5B45647B0 X-Migadu-Scanner: mx12.migadu.com X-TUID: RPUX/+FvCckB > I would avoid abbreviations as usual and go for > ‘file-system-resizing-service-type’. WDYT? Sounds good to me. > I wonder if Guile-Parted could be used instead of ‘growpart’ (shouldn’t > be a blocker though). This is an interesting idea. parted can tell us the file system type at runtime, reducing the amount of information the user needs to provide (at the cost of not catching invalid file-system-type values at build-time.) > No need for ‘let/ec’ here, you can just return from the ‘guard’ handler. What would that look like? We don't want to capture an error in grow-filesystem-command with an exit-status of 1, so it lives outside the guard, and we don't want to raise an exception if the partition was already resized. (Side note, should Shepherd consider a service perpetually starting if the start constructor exits without returning a value?) V3 should have all other feedback implemented. Richard Sent (2): packages: cloud-utils: Add missing growpart programs to path. gnu: services: Add resize-file-system-service. doc/guix.texi | 54 +++++++++++++++++ gnu/packages/admin.scm | 15 ++++- gnu/services/admin.scm | 133 ++++++++++++++++++++++++++++++++++++++++- 3 files changed, 198 insertions(+), 4 deletions(-) base-commit: 0787a180b3ca64d3958438920ca1b58a2a27fba4 -- 2.46.0