From: Dariqq <dariqq@posteo.net>
To: 73859@debbugs.gnu.org
Cc: Dariqq <dariqq@posteo.net>, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#73859: [PATCH 0/2] lightdm: Fix empty session list.
Date: Sat, 2 Nov 2024 10:18:31 +0000 [thread overview]
Message-ID: <cover.1730541249.git.dariqq@posteo.net> (raw)
In-Reply-To: <8fe9bf90-158c-4e03-a257-6ebf9da5ad54@posteo.net>
This changes lightdm and the service to use the config file from a well-known location in /etc/lightdm/lightdm.conf s.t. the gtk-greeter knows about our custom "sessions-directory".
I then removed the custom config file from the lightdm servcice and removed passing XDG_CONFIG_DIRS which are no longer neccesary.
Renamed lightdm-configuration->greeters-config-dir to just lightdm-configuration-directory (inspired by how the dbus-service names its directory) and also moved the etc-extension into a seperate procedure for consistency with other services.
I tested this on my i686 pc and ran 'make check-system TESTS=lightdm' successfully
This is also the approach done on NixOS, see
* https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/display-managers/lightdm/default.nix#L93
*https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/x11/display-managers/lightdm.nix#L259
Fixes https://issues.guix.gnu.org/68055
Dariqq (2):
gnu: lightdm: Use global sysconfdir.
gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm.
gnu/packages/display-managers.scm | 7 ++++-
gnu/services/lightdm.scm | 48 ++++++++++++++-----------------
2 files changed, 27 insertions(+), 28 deletions(-)
base-commit: ea11d3608566174c4bae70faa4f9d0c67748d2db
--
2.46.0
next prev parent reply other threads:[~2024-11-02 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 9:23 bug#73859: lightdm-service-type is almost unusable Dariqq
2024-10-23 14:48 ` Maxim Cournoyer
2024-10-23 18:15 ` Dariqq
2024-10-24 0:51 ` bug#73859: lightdm Feng Shu
2024-10-25 8:41 ` Feng Shu
2024-11-02 10:18 ` Dariqq [this message]
2024-11-02 10:18 ` bug#73859: [PATCH 1/2] gnu: lightdm: Use global sysconfdir Dariqq
2024-11-02 10:18 ` bug#73859: [PATCH 2/2] gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm Dariqq
2024-12-16 2:35 ` bug#73859: [PATCH 0/2] lightdm: Fix empty session list Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1730541249.git.dariqq@posteo.net \
--to=dariqq@posteo.net \
--cc=73859@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.