From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id GGkYNNcvHWfmegEAqHPOHw:P1 (envelope-from ) for ; Sat, 26 Oct 2024 18:07:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id GGkYNNcvHWfmegEAqHPOHw (envelope-from ) for ; Sat, 26 Oct 2024 20:07:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=D4Fcb5F0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=free.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729966039; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HHv03w6vZqLdcF/mXjSzW0dLeftg25tNPkNufeX7Xno=; b=hFtKkFFtlAkSYRppZAK1jR3R1omg9YthlviXNF/H7YVgonJF16G8d3vhcVpQae29tGx+hk F4fq58gvcoLHwveBIpjTFoSg4FgpeOhJw0/I7FGQEPPTB2cdjdsWuB/tKXF2iiIMCADnLe 6zCO2LYgKzrDylzl9HwkBADRTITV8U/sek2yJKvsZhuuZILy57qzMZHBJVlGOEKUDLcCik JqXvZirXucsV/M6xKaZsHbrIjFrYz+CGmKG26Wl3TIIe5HaMaHMKxpCm+TrlPOy5MRpvL7 sRB4lVDXeZyYCvD29QYX0rAnRh6aVVkbJSC0uI5VLVwilV4F6MWH70C39ttGBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=D4Fcb5F0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=free.fr (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729966039; a=rsa-sha256; cv=none; b=a7PKsff6t2t23ftkStxoMPFkp3iVv9xqmf2OOgrDaIx/CAaNWyLiqVlYH48/U+NcXJr4it W1vtIH/w8JmtoURNT9eLCPrTkvY+BdE5ll+bN9mpj8af2aw92tr9bVKIEMIeczoR+p7jH1 zI6B5lLiH1EF5kEl9nUyAfe9bDSW17d0FHkUCRKEKQOfpLKvtiP1D39zmnuIcQwoptoSmc 3wtxAeAWr0Ba7lOv9dibMvL8cSbVDnemdhize6jiTeYvgyGiLw20jHQuJHCjaW5FEMqLsv PpY99/DJPpl9Q6KBe6z1xxvIlkJg0uc9kVPFq/SQmidEKfA1i+gqzhpyjdUyJg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 703ED8E275 for ; Sat, 26 Oct 2024 20:07:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4kuA-0007KE-CC; Sat, 26 Oct 2024 13:48:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4ktu-0007DY-Q3 for guix-patches@gnu.org; Sat, 26 Oct 2024 13:48:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4ktt-00033k-DG for guix-patches@gnu.org; Sat, 26 Oct 2024 13:48:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=HHv03w6vZqLdcF/mXjSzW0dLeftg25tNPkNufeX7Xno=; b=D4Fcb5F0gtXLMxAexFBI0GyWpjmSmZSpOkOUV1wQ6GN28zQQ+8hFdhR3VKL3P4JWgdCOnonEh/lKRQXPoQGr9ZiFZJ6Cmkzc9PMgEdOO48gABrxhxsD7gpsUAibNvk9AOoOurMr0bcx1OG69csxTfzq+UG+5zHF3UflThJvsldBXOamRESZrcaG6SN36qOTRhWpujFw4tRWnEg8b+sT1mHSn6hB8uf0kWZ284v9O1f7XX54S2H22x4Dxn267l13tC69+RTScmovkoSCSR1oYBPS0oT6KKe8mft9s0eWuLpYMFPWee5//2juYiTOAVKJXKc4ZuyeWHQ3eNvxVG2SbeA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t4kuN-0001R4-5P; Sat, 26 Oct 2024 13:49:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73842] [PATCH v2 0/3] pack: Add support for AppImage pack format. References: In-Reply-To: Resent-From: =?UTF-8?Q?No=C3=A9?= Lopez Original-Sender: "Debbugs-submit" Resent-CC: pelzflorian@pelzflorian.de, julien@lepiller.eu, guix-patches@gnu.org Resent-Date: Sat, 26 Oct 2024 17:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73842@debbugs.gnu.org Cc: =?UTF-8?Q?No=C3=A9?= Lopez , Florian Pelz , Julien Lepiller X-Debbugs-Original-Xcc: Florian Pelz , Julien Lepiller Received: via spool by 73842-submit@debbugs.gnu.org id=B73842.17299648995422 (code B ref 73842); Sat, 26 Oct 2024 17:49:03 +0000 Received: (at 73842) by debbugs.gnu.org; 26 Oct 2024 17:48:19 +0000 Received: from localhost ([127.0.0.1]:42495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4kte-0001PM-PN for submit@debbugs.gnu.org; Sat, 26 Oct 2024 13:48:19 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:39290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4ktd-0001PF-2u for 73842@debbugs.gnu.org; Sat, 26 Oct 2024 13:48:17 -0400 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:990:a960:b4f3:8f44:ec4:5af5]) by smtp1-g21.free.fr (Postfix) with ESMTP id C8EFFB00579; Sat, 26 Oct 2024 19:47:09 +0200 (CEST) From: =?UTF-8?Q?No=C3=A9?= Lopez Date: Sat, 26 Oct 2024 19:28:08 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 4.53 X-Spam-Score: 4.53 X-Migadu-Queue-Id: 703ED8E275 X-TUID: 8zDseTIQ4zt2 Hi Ludovic, Thank you for the complete review, here is a new version of the patch containing the changes you asked for. Sebastian did the news entry in three languages (!!!) while I made the tests and git magic. Can you explain why you want support for symlinks? I can’t think of a use for it since AppImages are only meant to be ran through their entrypoint, not unpacked. A summary of changes since previous patch: – Improved package definition for [squash]fuse-for-appimage and bumped versions; – Added news entry; – Added tests; – Applied code suggestions from review: – Don’t use (use-modules) on non-toplevel; – Change -R warning in documentation, and ensure two spaces after dots; – Change appimage-type2-runtime synopsis and description; – Document and improve (concatenate-files) – Use better lambdas for `profile' and populating the store. – chmod 555 the resulting AppImage Have a wonderful week-end, Noé Lopez Noé Lopez (1): gnu: appimage: New packages for the appimage runtime. Sebastian Dümcke (2): pack: Add support for AppImage pack format. news: Add entry for guix pack’s AppImage format doc/guix.texi | 55 +++++++++++++++- etc/news.scm | 38 +++++++++++ gnu/packages/appimage.scm | 133 ++++++++++++++++++++++++++++++++++++++ guix/scripts/pack.scm | 104 ++++++++++++++++++++++++++++- tests/pack.scm | 41 +++++++++++- 5 files changed, 368 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/appimage.scm base-commit: df666602c7936f7d87354374b148ef6269844c01 -- 2.46.0