From: "Noé Lopez" <noelopez@free.fr>
To: 73842@debbugs.gnu.org
Cc: "Noé Lopez" <noelopez@free.fr>,
"Florian Pelz" <pelzflorian@pelzflorian.de>,
"Julien Lepiller" <julien@lepiller.eu>
Subject: [bug#73842] [PATCH v2 0/3] pack: Add support for AppImage pack format.
Date: Sat, 26 Oct 2024 19:28:08 +0200 [thread overview]
Message-ID: <cover.1729963690.git.noelopez@free.fr> (raw)
In-Reply-To: <da8f8eca32729bf35117107993b83359267e5638.1729115489.git.noelopez@free.fr>
Hi Ludovic,
Thank you for the complete review, here is a new version of the patch
containing the changes you asked for. Sebastian did the news entry in
three languages (!!!) while I made the tests and git magic.
Can you explain why you want support for symlinks? I can’t think of a
use for it since AppImages are only meant to be ran through their
entrypoint, not unpacked.
A summary of changes since previous patch:
– Improved package definition for [squash]fuse-for-appimage and
bumped versions;
– Added news entry;
– Added tests;
– Applied code suggestions from review:
– Don’t use (use-modules) on non-toplevel;
– Change -R warning in documentation, and ensure two spaces
after dots;
– Change appimage-type2-runtime synopsis and description;
– Document and improve (concatenate-files)
– Use better lambdas for `profile' and populating the store.
– chmod 555 the resulting AppImage
Have a wonderful week-end,
Noé Lopez
Noé Lopez (1):
gnu: appimage: New packages for the appimage runtime.
Sebastian Dümcke (2):
pack: Add support for AppImage pack format.
news: Add entry for guix pack’s AppImage format
doc/guix.texi | 55 +++++++++++++++-
etc/news.scm | 38 +++++++++++
gnu/packages/appimage.scm | 133 ++++++++++++++++++++++++++++++++++++++
guix/scripts/pack.scm | 104 ++++++++++++++++++++++++++++-
tests/pack.scm | 41 +++++++++++-
5 files changed, 368 insertions(+), 3 deletions(-)
create mode 100644 gnu/packages/appimage.scm
base-commit: df666602c7936f7d87354374b148ef6269844c01
--
2.46.0
next prev parent reply other threads:[~2024-10-26 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 21:51 [bug#73842] [PATCH] pack: Add support for AppImage pack format Noé Lopez
2024-10-18 12:20 ` Ludovic Courtès
2024-10-18 12:22 ` Ludovic Courtès
2024-10-18 20:34 ` Ludovic Courtès
2024-10-26 17:28 ` Noé Lopez [this message]
2024-10-26 17:28 ` [bug#73842] [PATCH v2 1/3] gnu: appimage: New packages for the appimage runtime Noé Lopez
2024-10-26 17:28 ` [bug#73842] [PATCH v2 2/3] pack: Add support for AppImage pack format Noé Lopez
2024-10-26 17:28 ` [bug#73842] [PATCH v2 3/3] news: Add entry for guix pack’s AppImage format Noé Lopez
2024-10-27 13:38 ` pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1729963690.git.noelopez@free.fr \
--to=noelopez@free.fr \
--cc=73842@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.