From: Herman Rimm via Guix-patches via <guix-patches@gnu.org>
To: 73126@debbugs.gnu.org
Subject: [bug#73126] [PATCH v2 0/2] Add git-source procedure.
Date: Mon, 16 Sep 2024 18:29:56 +0200 [thread overview]
Message-ID: <cover.1726495443.git.herman@rimm.ee> (raw)
In-Reply-To: <20240908203024.4762-1-herman@rimm.ee>
Hi,
A procedure is shorter for sure and so is its invocation, see patch #2.
On the one hand the hash line is close to the version line, but there
are no field names anymore; it may be unclear that a 'version' variable
is used as a 'commit' argument.
I keep a 'host' argument separate from 'author' in case we want to use
symbols for popular hosts or ones that use protocols other than HTTPS.
I could add a version keyword argument, which would be useful for
packages which have their version field generated by git-version.
Cheers,
Herman
Herman Rimm (2):
download: Add git-source.
gnu: Add inadyn.
doc/guix.texi | 7 +++++++
gnu/packages/dns.scm | 27 +++++++++++++++++++++++++--
guix/git-download.scm | 12 +++++++++++-
3 files changed, 43 insertions(+), 3 deletions(-)
base-commit: ee64bcfb796ef36db4b63f79540627fb25f3320a
--
2.45.2
next prev parent reply other threads:[~2024-09-16 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 20:30 [bug#73126] [PATCH] git-download: Add git-origin macro Herman Rimm via Guix-patches via
2024-09-16 16:29 ` Herman Rimm via Guix-patches via [this message]
2024-09-16 16:29 ` [bug#73126] [PATCH v2 1/2] download: Add git-source Herman Rimm via Guix-patches via
2024-09-16 16:29 ` [bug#73126] [PATCH v2 2/2] gnu: Add inadyn Herman Rimm via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1726495443.git.herman@rimm.ee \
--to=guix-patches@gnu.org \
--cc=73126@debbugs.gnu.org \
--cc=herman@rimm.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.