From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms9.migadu.com with LMTPS
	id kFSxHuqwWmT5IwEASxT56A
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 09 May 2023 22:45:30 +0200
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id aFuqHuqwWmS9CwAAauVa8A
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 09 May 2023 22:45:30 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 576622E855
	for <larch@yhetil.org>; Tue,  9 May 2023 22:45:25 +0200 (CEST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1pwUCo-0001v1-9j; Tue, 09 May 2023 16:45:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1pwUCm-0001up-1u
 for guix-patches@gnu.org; Tue, 09 May 2023 16:45:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1pwUCl-0007VT-NZ
 for guix-patches@gnu.org; Tue, 09 May 2023 16:45:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pwUCk-0007Ch-Eh
 for guix-patches@gnu.org; Tue, 09 May 2023 16:45:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#63400] [PATCH 0/1] gnu: vulkan-loader: Skip x86-specific tests
 on non-x86 platforms.
Resent-From: Simon South <simon@simonsouth.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Tue, 09 May 2023 20:45:02 +0000
Resent-Message-ID: <handler.63400.B.168366504827605@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 63400
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 63400@debbugs.gnu.org
X-Debbugs-Original-To: guix-patches@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.168366504827605
 (code B ref -1); Tue, 09 May 2023 20:45:02 +0000
Received: (at submit) by debbugs.gnu.org; 9 May 2023 20:44:08 +0000
Received: from localhost ([127.0.0.1]:44591 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1pwUBs-0007BA-25
 for submit@debbugs.gnu.org; Tue, 09 May 2023 16:44:08 -0400
Received: from lists.gnu.org ([209.51.188.17]:44296)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <simon@simonsouth.net>) id 1pwUBp-0007B2-UV
 for submit@debbugs.gnu.org; Tue, 09 May 2023 16:44:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <simon@simonsouth.net>)
 id 1pwUBp-0001I7-Aj
 for guix-patches@gnu.org; Tue, 09 May 2023 16:44:05 -0400
Received: from mailout.easymail.ca ([64.68.200.34])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <simon@simonsouth.net>)
 id 1pwUBn-0007PI-2r
 for guix-patches@gnu.org; Tue, 09 May 2023 16:44:05 -0400
Received: from localhost (localhost [127.0.0.1])
 by mailout.easymail.ca (Postfix) with ESMTP id 24AAFEA3A3
 for <guix-patches@gnu.org>; Tue,  9 May 2023 20:44:00 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn
Received: from mailout.easymail.ca ([127.0.0.1])
 by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id A-8gbFV8ZCNr for <guix-patches@gnu.org>;
 Tue,  9 May 2023 20:43:59 +0000 (UTC)
Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mailout.easymail.ca (Postfix) with ESMTPSA id AA7ABEA056
 for <guix-patches@gnu.org>; Tue,  9 May 2023 20:43:59 +0000 (UTC)
From: Simon South <simon@simonsouth.net>
Date: Tue,  9 May 2023 16:43:27 -0400
Message-Id: <cover.1683661648.git.simon@simonsouth.net>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; 
 helo=mailout.easymail.ca
X-Spam_score_int: -41
X-Spam_score: -4.2
X-Spam_bar: ----
X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683665125; a=rsa-sha256; cv=none;
	b=ObLI0z7Dm5ldoDpuCglcRgoAi0BeCdLPfDDLka0fORLBcFgscg2WFnrUFvL/NuqJS+gUQC
	KC6FGrudcrQY60B+SomBJLBhXxRuWxkR1MbffbvuAzwUuv8nCNF9i6nEdadXeOs+B8kqsk
	jUeYffFok33asW6PF1iqpYvHZ8Qze66YpKtnSeAO/IxOAQG8EIeROm8JhK0+02wVZVdbV+
	9Kk0SgUjVeYfsnRwDkjAf+sEcvzQ9lVTpNfV70kisRcQ+bzFUHW0ymSE7QrezsvvQSY22a
	3KR9BafRXJEc5obQvQkA8rNt/OT+El/vN//lftC0KEMlUa3PbLxIupr7OkHxcg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1683665125;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=ymAQAZ3hOg2XkfoJlk/WnZFy5PrEPmo6+eCNcWVolM8=;
	b=L0YyKy6keyq/y+XBj+DAt5QYwzi9bFRClphyuPCOgl6cil3hMjw5OzlHK6aMoruRKU68aL
	2iaH5XJKx1nJqrwVnDsNsZY56gmRrzvIW6RpSoM+FZmB9/IIia0DO02Ol59xAmug8+62Uf
	OQJExZNMSaUEaDF8th7UmRkJ05oAOB5Jn185dDJNIfly2cGgGB3/GJcSTmwnxijdxoNd5j
	wVsA9AmaaYawtgNcxK6dWd4cU+fXO2iqf33Z1L37jD22qD/TfN39xXHa8dzHmGpTuM+kjK
	9+JHe1SNd+F8763U5lzE/aA3eqdOOAShZ9AkUNOcfdyuvtEGe8BUnRTZtNiV1Q==
X-Migadu-Scanner: scn1.migadu.com
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -0.58
X-Spam-Score: -0.58
X-Migadu-Queue-Id: 576622E855
X-TUID: 4NSLSNVP+u/v

This patch fixes the build of vulkan-loader on aarch64-linux by
causing five tests that require an x86 or x86-64 host to be skipped.

I've tested this change on x86-64 (to confirm the patch has no real
effect) and AArch64 and everything seems fine.

The tests that are skipped use pre-built, dummy libraries supplied in
the source package to check the loader's ability to detect a request
for a 32-bit library on a 64-bit system, and vice-versa.  This is done
by checking for a specific error message generated by a call to
dlopen().  The dummy libraries provided are built only for x86 and
x86-64, though, so on other platforms dlopen() produces a different
error ("No such file" instead of "wrong ELF class") and the tests
fail.

The source package supplies a makefile that could be used to
regenerate these dummy libraries, but as written the makefile assumes
that

  - gcc recognizes "-m32" and "-m64" options to select a target
    subarchitecture, which is true on x86 and PowerPC but not on
    AArch64 or RISC-V, for instance; and that

  - The system's linker is able to output libraries for multiple
    architectures, requiring (among other things) that multiple
    versions of glibc be available, and even using "cross-gcc" and
    "cross-libc" I haven't found a straightforward way to achieve this
    within a single package build.

So I expect modifying things to make these tests work on other
platforms would be more trouble than it's worth.

---

Simon South (1):
  gnu: vulkan-loader: Skip x86-specific tests on non-x86 platforms.

 gnu/local.mk                                  |  1 +
 ...ulkan-loader-skip-incompatible-tests.patch | 62 +++++++++++++++++++
 gnu/packages/vulkan.scm                       |  2 +
 3 files changed, 65 insertions(+)
 create mode 100644 gnu/packages/patches/vulkan-loader-skip-incompatible-tests.patch


base-commit: c1ffe2f21bd1b9ba6bd527bbabe130144a69af71
-- 
2.39.2